mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
4970333621
These comments were added to enforce using the correct import path for
our packages ("github.com/docker/docker", not "github.com/moby/moby").
However, when working in go module mode (not GOPATH / vendor), they have
no effect, so their impact is limited.
Remove these imports in preparation of migrating our code to become an
actual go module.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
107 lines
3.3 KiB
Go
107 lines
3.3 KiB
Go
//go:build !windows
|
|
|
|
package system
|
|
|
|
import (
|
|
"encoding/json"
|
|
"io"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/client"
|
|
"github.com/docker/docker/testutil/request"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func TestInfoBinaryCommits(t *testing.T) {
|
|
ctx := setupTest(t)
|
|
|
|
t.Run("current", func(t *testing.T) {
|
|
apiClient := testEnv.APIClient()
|
|
|
|
info, err := apiClient.Info(ctx)
|
|
assert.NilError(t, err)
|
|
|
|
assert.Check(t, info.ContainerdCommit.ID != "N/A")
|
|
assert.Check(t, is.Equal(info.ContainerdCommit.Expected, "")) //nolint:staticcheck // ignore SA1019: field is deprecated, but still used on API < v1.49.
|
|
|
|
assert.Check(t, info.InitCommit.ID != "N/A")
|
|
assert.Check(t, is.Equal(info.InitCommit.Expected, "")) //nolint:staticcheck // ignore SA1019: field is deprecated, but still used on API < v1.49.
|
|
|
|
assert.Check(t, info.RuncCommit.ID != "N/A")
|
|
assert.Check(t, is.Equal(info.RuncCommit.Expected, "")) //nolint:staticcheck // ignore SA1019: field is deprecated, but still used on API < v1.49.
|
|
})
|
|
|
|
// Expected commits are omitted in API 1.49, but should still be included in older versions.
|
|
t.Run("1.48", func(t *testing.T) {
|
|
apiClient, err := client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.48"))
|
|
assert.NilError(t, err)
|
|
|
|
info, err := apiClient.Info(ctx)
|
|
assert.NilError(t, err)
|
|
|
|
assert.Check(t, info.ContainerdCommit.ID != "N/A")
|
|
assert.Check(t, is.Equal(info.ContainerdCommit.Expected, info.ContainerdCommit.ID)) //nolint:staticcheck // ignore SA1019: field is deprecated, but still used on API < v1.49.
|
|
|
|
assert.Check(t, info.InitCommit.ID != "N/A")
|
|
assert.Check(t, is.Equal(info.InitCommit.Expected, info.InitCommit.ID)) //nolint:staticcheck // ignore SA1019: field is deprecated, but still used on API < v1.49.
|
|
|
|
assert.Check(t, info.RuncCommit.ID != "N/A")
|
|
assert.Check(t, is.Equal(info.RuncCommit.Expected, info.RuncCommit.ID)) //nolint:staticcheck // ignore SA1019: field is deprecated, but still used on API < v1.49.
|
|
})
|
|
}
|
|
|
|
func TestInfoLegacyFields(t *testing.T) {
|
|
ctx := setupTest(t)
|
|
|
|
const notPresent = "expected field to not be present"
|
|
|
|
tests := []struct {
|
|
name string
|
|
url string
|
|
expectedFields map[string]any
|
|
}{
|
|
{
|
|
name: "api v1.49 legacy bridge-nftables",
|
|
url: "/v1.49/info",
|
|
expectedFields: map[string]any{
|
|
"BridgeNfIp6tables": false,
|
|
"BridgeNfIptables": false,
|
|
},
|
|
},
|
|
{
|
|
name: "api v1.50 legacy bridge-nftables",
|
|
url: "/v1.50/info",
|
|
expectedFields: map[string]any{
|
|
"BridgeNfIp6tables": notPresent,
|
|
"BridgeNfIptables": notPresent,
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
res, _, err := request.Get(ctx, tc.url)
|
|
assert.NilError(t, err)
|
|
assert.Equal(t, res.StatusCode, http.StatusOK)
|
|
body, err := io.ReadAll(res.Body)
|
|
assert.NilError(t, err)
|
|
|
|
actual := map[string]any{}
|
|
err = json.Unmarshal(body, &actual)
|
|
assert.NilError(t, err, string(body))
|
|
|
|
for field, expectedValue := range tc.expectedFields {
|
|
if expectedValue == notPresent {
|
|
_, found := actual[field]
|
|
assert.Assert(t, !found, "field %s should not be present", field)
|
|
} else {
|
|
_, found := actual[field]
|
|
assert.Assert(t, found, "field %s should be present", field)
|
|
assert.Check(t, is.DeepEqual(actual[field], expectedValue))
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|