Sebastiaan van Stijn
d49e068e55
client: TestImageTagInvalidSourceImageName remove invalid test-case
...
The test considered `Foo/bar` to be an invalid name, with the assumption
that it was `[docker.io]/Foo/bar`. However, this was incorrect, and the
test passed because the reference parsing had a bug; if the first element
(`Foo`) is not lowercase (so not a valid namespace / "path element"), then
it *should* be considered a domain (as uppercase domain names are valid).
The reference parser did not account for this, and running the test with
a version of the parser with a fix caused the test to fail:
=== Failed
=== FAIL: client TestImageTagInvalidSourceImageName/invalidRepo/FOO/bar (0.00s)
image_tag_test.go:54: assertion failed: expected error to contain "not a valid repository/tag", got "Error response from daemon: client should not have made an API call"
Error response from daemon: client should not have made an API call
=== FAIL: client TestImageTagInvalidSourceImageName (0.00s)
This patch removes the faulty test-case.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
(cherry picked from commit c243efb0cd )
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-24 09:57:13 +01:00
..
2023-03-29 16:59:44 +00:00
2016-09-07 11:05:58 -07:00
2021-02-16 10:07:44 -05:00
2022-10-08 17:41:39 +02:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-03-31 16:15:01 -04:00
2021-08-27 14:56:57 +08:00
2023-01-01 13:35:16 +01:00
2023-01-01 13:35:16 +01:00
2023-01-01 13:35:16 +01:00
2023-07-14 20:36:33 +02:00
2021-08-27 14:56:57 +08:00
2021-02-16 10:07:44 -05:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2022-05-13 02:40:14 +02:00
2022-07-08 19:56:23 +02:00
2021-08-27 14:56:57 +08:00
2021-02-16 10:07:44 -05:00
2022-04-19 08:28:20 +02:00
2022-04-19 08:28:20 +02:00
2022-04-28 22:39:20 +02:00
2023-06-01 17:22:49 +02:00
2023-05-03 21:25:07 +02:00
2023-05-03 21:23:42 +02:00
2021-08-27 14:56:57 +08:00
2022-06-24 11:54:25 +02:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2022-04-19 17:40:33 +02:00
2023-04-25 15:11:32 +02:00
2022-03-31 19:59:17 +02:00
2021-08-27 14:56:57 +08:00
2022-07-08 19:56:23 +02:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2022-03-20 19:04:52 +01:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2022-04-20 21:29:34 +02:00
2022-04-20 21:29:34 +02:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2020-02-28 09:54:37 -08:00
2022-04-20 21:29:34 +02:00
2022-04-20 21:29:34 +02:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2021-02-16 10:07:44 -05:00
2023-12-27 14:18:13 +01:00
2023-12-27 14:18:13 +01:00
2021-08-27 14:56:57 +08:00
2021-07-27 12:17:45 +02:00
2020-02-11 00:06:42 +01:00
2022-07-29 23:04:34 +02:00
2022-03-07 12:35:55 +01:00
2022-08-23 23:21:21 +02:00
2023-04-25 15:11:32 +02:00
2022-09-28 01:58:52 +02:00
2021-08-27 14:56:57 +08:00
2023-07-17 09:41:41 +02:00
2022-07-29 23:05:15 +02:00
2021-02-16 10:07:44 -05:00
2022-07-29 23:04:34 +02:00
2022-07-29 23:04:34 +02:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2021-02-16 10:07:44 -05:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2022-11-30 17:08:00 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2022-07-29 23:05:22 +02:00
2019-03-16 00:42:42 +01:00
2022-07-29 23:05:22 +02:00
2022-07-29 23:04:34 +02:00
2022-03-20 19:04:52 +01:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2023-04-25 15:11:32 +02:00
2022-07-29 23:04:34 +02:00
2024-01-24 09:57:13 +01:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2018-04-23 13:52:44 -07:00
2018-02-05 16:51:57 -05:00
2023-06-01 17:22:49 +02:00
2022-07-29 23:05:15 +02:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2022-03-20 19:04:52 +01:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2019-10-18 00:45:33 +02:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2022-05-13 02:40:14 +02:00
2023-01-01 13:35:16 +01:00
2022-08-23 23:27:35 +02:00
2022-03-25 23:57:58 +01:00
2022-12-21 11:09:01 +01:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2022-08-23 23:21:21 +02:00
2023-04-25 15:11:32 +02:00
2022-03-20 19:04:52 +01:00
2022-07-29 23:05:22 +02:00
2022-07-29 23:04:34 +02:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2022-07-29 23:04:34 +02:00
2019-01-03 22:49:00 +01:00
2023-07-14 20:36:33 +02:00
2023-07-14 20:36:33 +02:00
2021-08-27 14:56:57 +08:00
2021-02-16 10:07:44 -05:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2022-05-13 02:40:14 +02:00
2023-06-01 17:22:49 +02:00
2022-07-29 23:04:34 +02:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2019-10-14 10:43:00 -05:00
2021-08-27 14:56:57 +08:00
2018-05-20 13:07:17 +02:00
2022-03-20 19:04:52 +01:00
2022-03-20 19:04:52 +01:00
2021-08-27 14:56:57 +08:00
2022-07-29 23:04:34 +02:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2018-04-23 13:52:44 -07:00
2021-08-27 14:56:57 +08:00
2022-05-13 02:40:14 +02:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2023-04-25 15:11:32 +02:00
2019-03-18 15:26:21 +01:00
2018-04-23 13:52:44 -07:00
2018-02-05 16:51:57 -05:00
2018-02-05 16:51:57 -05:00
2019-03-18 15:26:21 +01:00
2022-04-28 22:39:14 +02:00
2022-04-28 22:39:14 +02:00
2022-04-28 22:39:04 +02:00
2022-04-21 19:50:59 +02:00
2023-04-25 15:11:32 +02:00
2022-08-03 23:30:28 +02:00
2019-03-18 15:26:21 +01:00
2021-08-27 14:56:57 +08:00
2022-03-20 19:04:52 +01:00
2022-05-13 00:55:44 +02:00
2022-05-13 02:40:14 +02:00