package client // import "github.com/docker/docker/client" import ( "bytes" "context" "encoding/json" "fmt" "io" "math/rand" "net/http" "strings" "testing" "time" "github.com/docker/docker/api/types" "github.com/docker/docker/api/types/container" "github.com/docker/docker/errdefs" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" ) // TestSetHostHeader should set fake host for local communications, set real host // for normal communications. func TestSetHostHeader(t *testing.T) { const testEndpoint = "/test" testCases := []struct { host string expectedHost string expectedURLHost string }{ { host: "unix:///var/run/docker.sock", expectedHost: DummyHost, expectedURLHost: "/var/run/docker.sock", }, { host: "npipe:////./pipe/docker_engine", expectedHost: DummyHost, expectedURLHost: "//./pipe/docker_engine", }, { host: "tcp://0.0.0.0:4243", expectedHost: "", expectedURLHost: "0.0.0.0:4243", }, { host: "tcp://localhost:4243", expectedHost: "", expectedURLHost: "localhost:4243", }, } for _, tc := range testCases { t.Run(tc.host, func(t *testing.T) { hostURL, err := ParseHostURL(tc.host) assert.Check(t, err) client := &Client{ client: newMockClient(func(req *http.Request) (*http.Response, error) { if !strings.HasPrefix(req.URL.Path, testEndpoint) { return nil, fmt.Errorf("expected URL %q, got %q", testEndpoint, req.URL) } if req.Host != tc.expectedHost { return nil, fmt.Errorf("wxpected host %q, got %q", tc.expectedHost, req.Host) } if req.URL.Host != tc.expectedURLHost { return nil, fmt.Errorf("expected URL host %q, got %q", tc.expectedURLHost, req.URL.Host) } return &http.Response{ StatusCode: http.StatusOK, Body: io.NopCloser(bytes.NewReader([]byte(""))), }, nil }), proto: hostURL.Scheme, addr: hostURL.Host, basePath: hostURL.Path, } _, err = client.sendRequest(context.Background(), http.MethodGet, testEndpoint, nil, nil, nil) assert.Check(t, err) }) } } // TestPlainTextError tests the server returning an error in plain text for // backwards compatibility with API versions <1.24. All other tests use // errors returned as JSON func TestPlainTextError(t *testing.T) { client := &Client{ client: newMockClient(plainTextErrorMock(http.StatusInternalServerError, "Server error")), } _, err := client.ContainerList(context.Background(), container.ListOptions{}) assert.Check(t, is.ErrorType(err, errdefs.IsSystem)) } // TestResponseErrors tests handling of error responses returned by the API. // It includes test-cases for malformed and invalid error-responses, as well // as plain text errors for backwards compatibility with API versions <1.24. func TestResponseErrors(t *testing.T) { errorResponse, err := json.Marshal(&types.ErrorResponse{ Message: "Some error occurred", }) assert.NilError(t, err) tests := []struct { doc string apiVersion string contentType string response string expected string }{ { // Valid (types.ErrorResponse) error, but not using a fixture, to validate current implementation.. doc: "JSON error (non-fixture)", contentType: "application/json", response: string(errorResponse), expected: `Error response from daemon: Some error occurred`, }, { // Valid (types.ErrorResponse) error. doc: "JSON error", contentType: "application/json", response: `{"message":"Some error occurred"}`, expected: `Error response from daemon: Some error occurred`, }, { // Valid (types.ErrorResponse) error with additional fields. doc: "JSON error with extra fields", contentType: "application/json", response: `{"message":"Some error occurred", "other_field": "some other field that's not part of types.ErrorResponse"}`, expected: `Error response from daemon: Some error occurred`, }, { // API versions before 1.24 did not support JSON errors, and return response as-is. doc: "JSON error on old API", apiVersion: "1.23", contentType: "application/json", response: `{"message":"Some error occurred"}`, expected: `Error response from daemon: {"message":"Some error occurred"}`, }, { doc: "plain-text error", contentType: "text/plain", response: `Some error occurred`, expected: `Error response from daemon: Some error occurred`, }, { // TODO(thaJeztah): consider returning (partial) raw response for these doc: "malformed JSON", contentType: "application/json", response: `{"message":"Some error occurred`, expected: `Error reading JSON: unexpected end of JSON input`, }, { // Server response that's valid JSON, but not the expected (types.ErrorResponse) scheme // TODO(thaJeztah): consider returning (partial) raw response for these doc: "incorrect JSON scheme", contentType: "application/json", response: `{"error":"Some error occurred"}`, expected: `Error response from daemon: `, }, { // TODO(thaJeztah): improve handling of such errors; we can return the generic "502 Bad Gateway" instead doc: "html error", contentType: "text/html", response: `
The server was unable to complete your request. Please try again later.
If this problem persists, please contact support.
`, expected: `Error response from daemon:The server was unable to complete your request. Please try again later.
If this problem persists, please contact support.
`, }, { // TODO(thaJeztah): improve handling of these errors (JSON: invalid character '<' looking for beginning of value) doc: "html error masquerading as JSON", contentType: "application/json", response: `The server was unable to complete your request. Please try again later.
If this problem persists, please contact support.
`, expected: `Error reading JSON: invalid character '<' looking for beginning of value`, }, } for _, tc := range tests { t.Run(tc.doc, func(t *testing.T) { client := &Client{ version: tc.apiVersion, client: newMockClient(func(req *http.Request) (*http.Response, error) { return &http.Response{ StatusCode: http.StatusBadRequest, Header: http.Header{"Content-Type": []string{tc.contentType}}, Body: io.NopCloser(bytes.NewReader([]byte(tc.response))), }, nil }), } _, err := client.Ping(context.Background()) assert.Check(t, is.Error(err, tc.expected)) assert.Check(t, is.ErrorType(err, errdefs.IsInvalidParameter)) }) } } func TestInfiniteError(t *testing.T) { infinitR := rand.New(rand.NewSource(42)) client := &Client{ client: newMockClient(func(req *http.Request) (*http.Response, error) { resp := &http.Response{ StatusCode: http.StatusInternalServerError, Header: http.Header{}, Body: io.NopCloser(infinitR), } return resp, nil }), } _, err := client.Ping(context.Background()) assert.Check(t, is.ErrorContains(err, "request returned Internal Server Error")) } func TestCanceledContext(t *testing.T) { const testEndpoint = "/test" client := &Client{ client: newMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.ErrorType(req.Context().Err(), context.Canceled)) return nil, context.Canceled }), } ctx, cancel := context.WithCancel(context.Background()) cancel() _, err := client.sendRequest(ctx, http.MethodGet, testEndpoint, nil, nil, nil) assert.Check(t, is.ErrorType(err, errdefs.IsCancelled)) assert.Check(t, is.ErrorIs(err, context.Canceled)) } func TestDeadlineExceededContext(t *testing.T) { const testEndpoint = "/test" client := &Client{ client: newMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.ErrorType(req.Context().Err(), context.DeadlineExceeded)) return nil, context.DeadlineExceeded }), } ctx, cancel := context.WithDeadline(context.Background(), time.Now()) defer cancel() <-ctx.Done() _, err := client.sendRequest(ctx, http.MethodGet, testEndpoint, nil, nil, nil) assert.Check(t, is.ErrorType(err, errdefs.IsDeadline)) assert.Check(t, is.ErrorIs(err, context.DeadlineExceeded)) }