package image import ( "strings" "testing" "github.com/moby/moby/api/types/image" "github.com/moby/moby/client" "github.com/moby/moby/v2/integration/internal/container" iimage "github.com/moby/moby/v2/integration/internal/image" "github.com/moby/moby/v2/internal/testutil" "github.com/moby/moby/v2/internal/testutil/daemon" "github.com/moby/moby/v2/internal/testutil/specialimage" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" "gotest.tools/v3/skip" ) // Regression test for: https://github.com/moby/moby/issues/45732 func TestPruneDontDeleteUsedDangling(t *testing.T) { skip.If(t, testEnv.DaemonInfo.OSType == "windows", "cannot start multiple daemons on windows") skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon") ctx := setupTest(t) d := daemon.New(t) d.Start(t) defer d.Stop(t) apiClient := d.NewClientT(t) danglingID := iimage.Load(ctx, t, apiClient, specialimage.Dangling) _, err := apiClient.ImageInspect(ctx, danglingID) assert.NilError(t, err, "Test dangling image doesn't exist") container.Create(ctx, t, apiClient, container.WithImage(danglingID), container.WithCmd("sleep", "60")) res, err := apiClient.ImagePrune(ctx, client.ImagePruneOptions{ Filters: make(client.Filters).Add("dangling", "true"), }) assert.NilError(t, err) for _, deleted := range res.Report.ImagesDeleted { if strings.Contains(deleted.Deleted, danglingID) || strings.Contains(deleted.Untagged, danglingID) { t.Errorf("used dangling image %s shouldn't be deleted", danglingID) } } _, err = apiClient.ImageInspect(ctx, danglingID) assert.NilError(t, err, "Test dangling image should still exist") } func TestPruneLexographicalOrder(t *testing.T) { skip.If(t, testEnv.DaemonInfo.OSType == "windows", "cannot start multiple daemons on windows") skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon") ctx := setupTest(t) d := daemon.New(t) d.Start(t) defer d.Stop(t) apiClient := d.NewClientT(t) d.LoadBusybox(ctx, t) inspect, err := apiClient.ImageInspect(ctx, "busybox:latest") assert.NilError(t, err) id := inspect.ID tags := []string{"h", "a", "j", "o", "s", "q", "w", "e", "r", "t"} for _, tag := range tags { _, err = apiClient.ImageTag(ctx, client.ImageTagOptions{Source: id, Target: "busybox:" + tag}) assert.NilError(t, err) } _, err = apiClient.ImageTag(ctx, client.ImageTagOptions{Source: id, Target: "busybox:z"}) assert.NilError(t, err) _, err = apiClient.ImageRemove(ctx, "busybox:latest", client.ImageRemoveOptions{Force: true}) assert.NilError(t, err) // run container cid := container.Create(ctx, t, apiClient, container.WithImage(id)) defer container.Remove(ctx, t, apiClient, cid, client.ContainerRemoveOptions{Force: true}) res, err := apiClient.ImagePrune(ctx, client.ImagePruneOptions{ Filters: make(client.Filters).Add("dangling", "false"), }) assert.NilError(t, err) assert.Check(t, is.Len(res.Report.ImagesDeleted, len(tags))) for _, p := range res.Report.ImagesDeleted { assert.Check(t, is.Equal(p.Deleted, "")) assert.Check(t, p.Untagged != "busybox:z") } } // Regression test for https://github.com/moby/moby/issues/48063 func TestPruneDontDeleteUsedImage(t *testing.T) { skip.If(t, testEnv.DaemonInfo.OSType == "windows", "cannot start multiple daemons on windows") skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon") ctx := setupTest(t) for _, env := range []struct { name string prepare func(t *testing.T, client *daemon.Daemon, apiClient *client.Client) error check func(t *testing.T, apiClient *client.Client, pruned image.PruneReport) }{ { // Container uses the busybox:latest image and it's the only image // tag with the same target. name: "single tag", check: func(t *testing.T, apiClient *client.Client, pruned image.PruneReport) { assert.Check(t, is.Len(pruned.ImagesDeleted, 0)) _, err := apiClient.ImageInspect(ctx, "busybox:latest") assert.NilError(t, err, "Busybox image should still exist") }, }, { // Container uses the busybox:latest image and there's also a second // busybox:other tag pointing to the same image. name: "two tags", prepare: func(t *testing.T, d *daemon.Daemon, apiClient *client.Client) error { _, err := apiClient.ImageTag(ctx, client.ImageTagOptions{Source: "busybox:latest", Target: "busybox:a"}) return err }, check: func(t *testing.T, apiClient *client.Client, pruned image.PruneReport) { if assert.Check(t, is.Len(pruned.ImagesDeleted, 1)) { assert.Check(t, is.Equal(pruned.ImagesDeleted[0].Deleted, "")) assert.Check(t, is.Equal(pruned.ImagesDeleted[0].Untagged, "busybox:a")) } _, err := apiClient.ImageInspect(ctx, "busybox:a") assert.Check(t, err != nil, "Busybox:a image should be deleted") _, err = apiClient.ImageInspect(ctx, "busybox:latest") assert.Check(t, err == nil, "Busybox:latest image should still exist") }, }, } { for _, tc := range []struct { name string imageID func(t *testing.T, inspect client.ImageInspectResult) string }{ { name: "full id", imageID: func(t *testing.T, inspect client.ImageInspectResult) string { return inspect.ID }, }, { name: "full id without sha256 prefix", imageID: func(t *testing.T, inspect client.ImageInspectResult) string { return strings.TrimPrefix(inspect.ID, "sha256:") }, }, { name: "truncated id (without sha256 prefix)", imageID: func(t *testing.T, inspect client.ImageInspectResult) string { return strings.TrimPrefix(inspect.ID, "sha256:")[:8] }, }, { name: "repo and digest without tag", imageID: func(t *testing.T, inspect client.ImageInspectResult) string { skip.If(t, !testEnv.UsingSnapshotter()) return "busybox@" + inspect.ID }, }, { name: "tagged and digested", imageID: func(t *testing.T, inspect client.ImageInspectResult) string { skip.If(t, !testEnv.UsingSnapshotter()) return "busybox:latest@" + inspect.ID }, }, { name: "repo digest", imageID: func(t *testing.T, inspect client.ImageInspectResult) string { // graphdriver won't have a repo digest skip.If(t, len(inspect.RepoDigests) == 0, "no repo digest") return inspect.RepoDigests[0] }, }, } { t.Run(env.name+"/"+tc.name, func(t *testing.T) { ctx := testutil.StartSpan(ctx, t) d := daemon.New(t) d.Start(t) defer d.Stop(t) apiClient := d.NewClientT(t) d.LoadBusybox(ctx, t) if env.prepare != nil { err := env.prepare(t, d, apiClient) assert.NilError(t, err, "prepare failed") } inspect, err := apiClient.ImageInspect(ctx, "busybox:latest") assert.NilError(t, err) img := tc.imageID(t, inspect) t.Log(img) cid := container.Run(ctx, t, apiClient, container.WithImage(img), container.WithCmd("sleep", "60")) defer container.Remove(ctx, t, apiClient, cid, client.ContainerRemoveOptions{Force: true}) // dangling=false also prunes unused images res, err := apiClient.ImagePrune(ctx, client.ImagePruneOptions{ Filters: make(client.Filters).Add("dangling", "false"), }) assert.NilError(t, err) env.check(t, apiClient, res.Report) }) } } }