InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
55,463 Commits 21 Branches 532 Tags
master
Commit Graph

185 Commits

Author SHA1 Message Date
Cristina Yenyxe Gonzalez Garcia
0154dc7a23 Using test names instead of hardcoded ones in integration/image directory 
Signed-off-by: Cristina Yenyxe Gonzalez Garcia <cristina.yenyxe@gmail.com>
 2020-05-18 16:37:09 +01:00
Akihiro Suda
5e1b246b9a test-integration: support more rootless tests 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2020-03-16 17:37:38 +09:00
Sebastiaan van Stijn
562880b276 Fix more goimports 
```
daemon/logger/splunk/splunk_test.go:33: File is not `goimports`-ed (goimports)
        envKey:      "a",
        envRegexKey: "^foo",
        labelsKey:   "b",
        tagKey:      "c",
integration/build/build_test.go:41: File is not `goimports`-ed (goimports)
            rm:      false,
            forceRm: false,
integration/image/remove_unix_test.go:49: File is not `goimports`-ed (goimports)
        Root: d.Root,
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2020-02-11 18:56:25 +01:00
Sebastiaan van Stijn
9f0b3f5609 bump gotest.tools v3.0.1 for compatibility with Go 1.14 
full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2020-02-11 00:06:42 +01:00
Olli Janatuinen
446fe7f263 Make sure that layers are removed from layerdb after succefull layer removal 
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
 2019-11-28 20:06:09 +02:00
Sam Whited
ae0a878b86 testutil, integration: untangle image dependency 
Signed-off-by: Sam Whited <sam@samwhited.com>
 2019-09-24 14:50:59 -05:00
Sebastiaan van Stijn
d948306255 integration: remove unused constants and fields (unused) 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-09-18 12:57:10 +02:00
Sam Whited
b37c214e3c testutil: make testing packages public 
This was done with something along the lines of:

```
mv internal/test testutil
pushd testutil/; grep -IRl "package test" | xargs -I '{}' sed -i -e 's|package test|package testutil|g' {}; popd
mv internal/testutil/*.go testutil/ && rm -rf internal/
grep -IRl "github.com\/docker\/docker\/internal\/test" | xargs -I '{}' sed -i -e 's|github.com/docker/docker/internal/test|github.com/docker/docker/test|g' {}
goimports .
```

I also modified the basic plugin path in testutil/fixtures/plugin.

Signed-off-by: Sam Whited <sam@samwhited.com>
 2019-09-11 07:47:23 -05:00
Michael Crosby
d6cbeee470 Add extra permission check in removal test 
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
 2019-07-22 20:39:22 +00:00
Sebastiaan van Stijn
9d1b4f5fc3 Add regression tests for invalid platform status codes 
Before we handled containerd errors, using an invalid platform produced a 500 status:

```bash
curl -v \
  -X POST \
  --unix-socket /var/run/docker.sock \
  "http://localhost:2375/v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest" \
  -H "Content-Type: application/json"
```

```
* Connected to localhost (docker.sock) port 80 (#0)
> POST /v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest HTTP/1.1
> Host: localhost:2375
> User-Agent: curl/7.54.0
> Accept: */*
> Content-Type: application/json
>
< HTTP/1.1 500 Internal Server Error
< Api-Version: 1.40
< Content-Length: 85
< Content-Type: application/json
< Date: Mon, 15 Jul 2019 15:25:44 GMT
< Docker-Experimental: true
< Ostype: linux
< Server: Docker/19.03.0-rc2 (linux)
<
{"message":"\"foobar\": unknown operating system or architecture: invalid argument"}
```

That problem is now fixed, and the API correctly returns a 4xx status:

```bash
curl -v \
  -X POST \
  --unix-socket /var/run/docker.sock \
  "http://localhost:2375/v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest" \
  -H "Content-Type: application/json"
```

```
* Connected to localhost (/var/run/docker.sock) port 80 (#0)
> POST /v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest HTTP/1.1
> Host: localhost:2375
> User-Agent: curl/7.52.1
> Accept: */*
> Content-Type: application/json
>
< HTTP/1.1 400 Bad Request
< Api-Version: 1.41
< Content-Type: application/json
< Docker-Experimental: true
< Ostype: linux
< Server: Docker/dev (linux)
< Date: Mon, 15 Jul 2019 15:13:42 GMT
< Content-Length: 85
<
{"message":"\"foobar\": unknown operating system or architecture: invalid argument"}
* Curl_http_done: called premature == 0
```

This patch adds tests to validate the behaviour

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-07-15 20:37:00 +02:00
Yong Tang
b10cd5c0e6 Merge pull request #39332 from thaJeztah/fix_golint_again 
Integration: change signatures to fix golint warnings
 2019-06-07 06:46:58 -07:00
Sebastiaan van Stijn
b4c46b0dac integration: change container.Create signature to fix linting 
```
Line 25: warning: context.Context should be the first parameter of a function (golint)
Line 44: warning: context.Context should be the first parameter of a function (golint)
Line 52: warning: context.Context should be the first parameter of a function (golint)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-06-07 13:04:44 +02:00
Olli Janatuinen
213681b66a First step to implement full garbage collector for image layers 
Refactored exiting logic on way that layers are first marked to be under
removal so if actual removal fails they can be found from disk and
cleaned up.

Full garbage collector will be implemented as part of containerd
migration.

Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
 2019-06-05 22:02:42 +03:00
Sebastiaan van Stijn
83ac2b4c13 Skip TestImagesFilterMultiReference on API < v1.40 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-04-24 17:52:21 -07:00
Yong Tang
32f6aeee8a Replace t.Fatal(err) with assert.NilError(err) 
so that they are consistent with other places

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2019-01-13 21:36:25 +00:00
Sebastiaan van Stijn
ae3ca7bb97 Run TestImportExtremelyLargeImageWorks in parallel 
This is a slow test, taking over two minutes to complete,
so spin up a new daemon for this test and run it in parallel

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-01-04 01:51:52 +01:00
Sebastiaan van Stijn
0de62d9bbc Integration: use testenv.APIClient() 
A client is already created in testenv.New(), so we can just
as well use that one, instead of creating a new client.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-01-03 11:53:41 +01:00
zhangyue
5007c36d71 cli: fix images filter when use multi reference filter 
Signed-off-by: zhangyue <zy675793960@yeah.net>
 2018-11-22 10:33:45 +08:00
Salahuddin Khan
4c8b1fd5a2 Enabling Windows integration tests 
Signed-off-by: Salahuddin Khan <salah@docker.com>
 2018-09-26 15:57:40 -07:00
Vincent Demeester
d3cc071bb9 Windows: Start of enabling tests under integration/ 
- Add windows CI entrypoint script.

Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-09-26 12:28:22 -07:00
Vincent Demeester
3845728524 Update tests to use gotest.tools 👼 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-06-13 09:04:30 +02:00
Sebastiaan van Stijn
55bebbaecf Replace deprecated testutil.ErrorContains() 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-05-21 00:13:04 +02:00
Anda Xu
e440831802 fix and skip some tests based on API version 
Signed-off-by: Anda Xu <anda.xu@docker.com>

Co-authored-by: Anda Xu <anda.xu@docker.com>
Co-authored-by: Tibor Vass <tibor@docker.com>
 2018-05-15 16:05:04 -07:00
Vincent Demeester
42f6fdf059 Move integration-cli/request to internal/test/request… 
… and change a bit the method signature

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-04-17 16:25:59 +02:00
Yong Tang
9bcb960508 Migrate image tag tests from integration-cli to api tests 
This fix migrates image tag tests from integration-cli to api tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-04-13 14:46:40 +00:00
Daniel Nephin
6be0f70983 Automated migration using 
gty-migrate-from-testify --ignore-build-tags

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-16 11:03:43 -04:00
Yong Tang
ed58ba99fb Migrate docker rm tests to api tests 
This fix migrates docker rm test in integration-cli
to api tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-03-05 20:35:14 +00:00
Yong Tang
6ab465804b Improvement in integration tests 
This fix adds several improvement:
1. No need for explicit ContainerRemove as it has been handled in setupTest()
2. Added `container.WithImage` helper function and used it in commit tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 2018-03-02 19:03:59 +00:00
Vincent Demeester
af306d149e Rename integration/util to integration/internal 
Both names have no real sense, but one allows to make sure these packages
aren't used outside of `integration`.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-02-10 09:16:32 +01:00
Daniel Nephin
4f0d95fa6e Add canonical import comment 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-02-05 16:51:57 -05:00
Anthony Sottile
0785836c4b Fix environ substitutions in docker commit --change ... 
The building machinery was being handed an uninitialized container
Config.  This changes it to use the target container's Config.

Resolves #30538

Signed-off-by: Anthony Sottile <asottile@umich.edu>
 2017-12-20 11:03:38 -08:00
Vincent Demeester
c307e0ce49 Merge pull request #35572 from arm64b/big-image-imp-test-aarch64 
image: skip the import test on AArch64
 2017-11-28 13:51:15 +01:00
Dennis Chen
6395b8b3dc image: skip the import test on AArch64 
The commit '0a13f827a10d3bf61744d9b3f7165c5885a39c5d' introduces an
import test for CVE-2017-14992, it uses a 8GB image to make sure we
don't revert CVE-2017-14992, but unfortunately this test can't finish
in 5-min on AArch64, as a fact, in most cases we have to crate a very
big image to make the test effective on AArch64, but this will result
in a test panic, so now we skip it order to avoid termination of others
tests followed.

Signed-off-by: Dennis Chen <dennis.chen@arm.com>
 2017-11-28 01:48:49 +00:00
Christopher Jones
be83f42612 [integration] add main_test for image test 
Adds a main_test for the image integration test, so we can download
frozen images, and clean up after the image test is ran

Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>
 2017-11-22 11:13:32 -05:00
Aleksa Sarai
0a13f827a1 image: add import test for CVE-2017-14992 
To ensure that we don't revert CVE-2017-14992, add a test that is quite
similar to that upstream tar-split test (create an empty archive with
lots of junk and make sure the daemon doesn't crash).

Signed-off-by: Aleksa Sarai <asarai@suse.de>
 2017-11-08 05:37:52 +11:00