From f633e8f03fb656d079e80a0596465400610754c8 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 7 Nov 2024 18:02:12 +0100 Subject: [PATCH] libnetwork/cmd/diagnostic: fix vars that shadowed (govet) libnetwork/cmd/diagnostic/main.go:198:5: shadow: declaration of "resp" shadows declaration at line 147 (govet) resp, err := http.Get(fmt.Sprintf(deleteEntry, ip, port, network, tableName, k)) ^ Signed-off-by: Sebastiaan van Stijn --- libnetwork/cmd/diagnostic/main.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libnetwork/cmd/diagnostic/main.go b/libnetwork/cmd/diagnostic/main.go index d57bd1e676..fc70976c7f 100644 --- a/libnetwork/cmd/diagnostic/main.go +++ b/libnetwork/cmd/diagnostic/main.go @@ -171,11 +171,11 @@ func fetchTable(ip string, port int, network, tableName string, clusterPeers, ne switch tableName { case "endpoint_table": var elem libnetwork.EndpointRecord - elem.Unmarshal(decoded) + _ = elem.Unmarshal(decoded) log.G(context.TODO()).Debugf("key:%s value:%+v owner:%s", v.Key, elem, v.Owner) case "overlay_peer_table": var elem overlay.PeerRecord - elem.Unmarshal(decoded) + _ = elem.Unmarshal(decoded) log.G(context.TODO()).Debugf("key:%s value:%+v owner:%s", v.Key, elem, v.Owner) } @@ -195,12 +195,12 @@ func fetchTable(ip string, port int, network, tableName string, clusterPeers, ne text = strings.ReplaceAll(text, "\n", "") if strings.Compare(text, "Yes") == 0 { for _, k := range orphanKeys { - resp, err := http.Get(fmt.Sprintf(deleteEntry, ip, port, network, tableName, k)) + r, err := http.Get(fmt.Sprintf(deleteEntry, ip, port, network, tableName, k)) if err != nil { log.G(context.TODO()).WithError(err).Errorf("Failed deleting entry k:%s", k) break } - resp.Body.Close() + _ = r.Body.Close() } } else { log.G(context.TODO()).Infof("Deletion skipped")