InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

pkg/pools: fix naked returns

Browse Source 
pkg/pools/pools.go:83:2: naked return in func `Copy` with 5 lines of code (nakedret)
        return
        ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-02-19 10:04:59 +01:00
parent 52b8298975
commit d3d84bde4b
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/pools/pools.go
View File

@@ -76,11 +76,11 @@ func (bp *bufferPool) Put(b *[]byte) {
}
// Copy is a convenience wrapper which uses a buffer to avoid allocation in io.Copy.
func Copy(dst io.Writer, src io.Reader) (written int64, err error) {
func Copy(dst io.Writer, src io.Reader) (written int64, _ error) {
buf := buffer32KPool.Get()
written, err = io.CopyBuffer(dst, src, *buf)
written, err := io.CopyBuffer(dst, src, *buf)
buffer32KPool.Put(buf)
return
return written, err
}
// NewReadCloserWrapper returns a wrapper which puts the bufio.Reader back
@@ -88,7 +88,7 @@ func Copy(dst io.Writer, src io.Reader) (written int64, err error) {
func (bufPool *BufioReaderPool) NewReadCloserWrapper(buf *bufio.Reader, r io.Reader) io.ReadCloser {
return ioutils.NewReadCloserWrapper(r, func() error {
if readCloser, ok := r.(io.ReadCloser); ok {
readCloser.Close()
_ = readCloser.Close()
}
bufPool.Put(buf)
return nil
@@ -127,9 +127,9 @@ func (bufPool *BufioWriterPool) Put(b *bufio.Writer) {
// into the pool and closes the writer if it's an io.WriteCloser.
func (bufPool *BufioWriterPool) NewWriteCloserWrapper(buf *bufio.Writer, w io.Writer) io.WriteCloser {
return ioutils.NewWriteCloserWrapper(w, func() error {
buf.Flush()
_ = buf.Flush()
if writeCloser, ok := w.(io.WriteCloser); ok {
writeCloser.Close()
_ = writeCloser.Close()
}
bufPool.Put(buf)
return nil