client: deprecate NewClientWithOpts in favor of New

Use a more idiomatic name so that it can be used as `client.New()`.

We should look if we want `New()` to have different / updated defaults
i.e., enable `WithEnv` as default, and have an opt-out and have API-
version negotiation enabled by default (with an opt-out option).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-10-29 17:20:49 +01:00
parent a96bc9e93c
commit d1f70d4f54
129 changed files with 411 additions and 391 deletions

View File

@@ -85,7 +85,7 @@ func (d *Daemon) inspectFieldWithError(name, field string) (string, error) {
func (d *Daemon) CheckActiveContainerCount(ctx context.Context) func(t *testing.T) (any, string) {
return func(t *testing.T) (any, string) {
t.Helper()
apiClient, err := client.NewClientWithOpts(client.FromEnv, client.WithHost(d.Sock()))
apiClient, err := client.New(client.FromEnv, client.WithHost(d.Sock()))
assert.NilError(t, err)
list, err := apiClient.ContainerList(ctx, client.ContainerListOptions{})