From c279c48a0eee071e4e174b72a6c643336a4ecffb Mon Sep 17 00:00:00 2001 From: Djordje Lukic Date: Thu, 12 Oct 2023 15:47:48 +0200 Subject: [PATCH] Skip TestPullAllTagsFromCentralRegistry The image that this test pulls contains an error in the linux/amd64 manifest description, the reported size is 424 but the actual size is 524, making this test fail with containerd. Signed-off-by: Djordje Lukic --- integration-cli/docker_cli_pull_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/integration-cli/docker_cli_pull_test.go b/integration-cli/docker_cli_pull_test.go index 95701c2aa2..0e349b6e98 100644 --- a/integration-cli/docker_cli_pull_test.go +++ b/integration-cli/docker_cli_pull_test.go @@ -10,6 +10,7 @@ import ( "github.com/opencontainers/go-digest" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" + "gotest.tools/v3/skip" ) type DockerCLIPullSuite struct { @@ -133,6 +134,8 @@ func (s *DockerHubPullSuite) TestPullScratchNotAllowed(c *testing.T) { // TestPullAllTagsFromCentralRegistry pulls using `all-tags` for a given image and verifies that it // results in more images than a naked pull. func (s *DockerHubPullSuite) TestPullAllTagsFromCentralRegistry(c *testing.T) { + // See https://github.com/moby/moby/issues/46632 + skip.If(c, testEnv.UsingSnapshotter, "The image dockercore/engine-pull-all-test-fixture is a hand-made image that contains an error in the manifest, the size is reported as 424 but its real size is 524, containerd fails to pull it because it checks that the sizes reported are right") testRequires(c, DaemonIsLinux) s.Cmd(c, "pull", "dockercore/engine-pull-all-test-fixture") outImageCmd := s.Cmd(c, "images", "dockercore/engine-pull-all-test-fixture")