InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Daemon.createContainerOSSpecificSettings - remove redundant param

Browse Source 
Also:
- remove the hostConfig param from Daemon.createContainerVolumesOS.
- rename var container -> ctr

Signed-off-by: Rob Murray <rob.murray@docker.com>
This commit is contained in:
Rob Murray
2025-11-14 12:15:21 +00:00
parent 33032b0454
commit 96b8f9c8ca
3 changed files with 26 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
daemon/create.go
View File

@@ -246,7 +246,7 @@ func (daemon *Daemon) create(ctx context.Context, daemonCfg *config.Config, opts
if err := daemon.registerLinks(ctr); err != nil { if err := daemon.registerLinks(ctr); err != nil {
return nil, err return nil, err
} }
if err := daemon.createContainerOSSpecificSettings(ctx, ctr, opts.params.HostConfig); err != nil { if err := daemon.createContainerOSSpecificSettings(ctx, ctr); err != nil {
return nil, err return nil, err
} }
@@ -264,7 +264,7 @@ func (daemon *Daemon) create(ctx context.Context, daemonCfg *config.Config, opts
if err := daemon.registerMountPoints(ctr, opts.params.DefaultReadOnlyNonRecursive); err != nil { if err := daemon.registerMountPoints(ctr, opts.params.DefaultReadOnlyNonRecursive); err != nil {
return nil, err return nil, err
} }
if err := daemon.createContainerVolumesOS(ctx, ctr, opts.params.Config, opts.params.HostConfig); err != nil { if err := daemon.createContainerVolumesOS(ctx, ctr, opts.params.Config); err != nil {
return nil, err return nil, err
} }

34
daemon/create_unix.go
View File

@@ -22,27 +22,25 @@ import (
) )
// createContainerOSSpecificSettings performs host-OS specific container create functionality // createContainerOSSpecificSettings performs host-OS specific container create functionality
func (daemon *Daemon) createContainerOSSpecificSettings(ctx context.Context, container *container.Container, hostConfig *containertypes.HostConfig) error { func (daemon *Daemon) createContainerOSSpecificSettings(ctx context.Context, ctr *container.Container) error {
// Set the default masked and readonly paths with regard to the host config options if they are not set. // Set the default masked and readonly paths with regard to the host config options if they are not set.
if hostConfig.MaskedPaths == nil && !hostConfig.Privileged { if ctr.HostConfig.MaskedPaths == nil && !ctr.HostConfig.Privileged {
hostConfig.MaskedPaths = oci.DefaultSpec().Linux.MaskedPaths // Set it to the default if nil ctr.HostConfig.MaskedPaths = oci.DefaultSpec().Linux.MaskedPaths // Set it to the default if nil
container.HostConfig.MaskedPaths = hostConfig.MaskedPaths
} }
if hostConfig.ReadonlyPaths == nil && !hostConfig.Privileged { if ctr.HostConfig.ReadonlyPaths == nil && !ctr.HostConfig.Privileged {
hostConfig.ReadonlyPaths = oci.DefaultSpec().Linux.ReadonlyPaths // Set it to the default if nil ctr.HostConfig.ReadonlyPaths = oci.DefaultSpec().Linux.ReadonlyPaths // Set it to the default if nil
container.HostConfig.ReadonlyPaths = hostConfig.ReadonlyPaths
} }
return nil return nil
} }
// createContainerVolumesOS performs host-OS specific volume creation // createContainerVolumesOS performs host-OS specific volume creation
func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, container *container.Container, config *containertypes.Config, hostConfig *containertypes.HostConfig) error { func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, ctr *container.Container, config *containertypes.Config) error {
if err := daemon.Mount(container); err != nil { if err := daemon.Mount(ctr); err != nil {
return err return err
} }
defer daemon.Unmount(container) defer daemon.Unmount(ctr)
if err := container.SetupWorkingDirectory(daemon.idMapping.RootPair()); err != nil { if err := ctr.SetupWorkingDirectory(daemon.idMapping.RootPair()); err != nil {
return err return err
} }
@@ -51,12 +49,12 @@ func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, container *c
// Skip volumes for which we already have something mounted on that // Skip volumes for which we already have something mounted on that
// destination because of a --volume-from. // destination because of a --volume-from.
if container.HasMountFor(destination) { if ctr.HasMountFor(destination) {
log.G(ctx).WithField("container", container.ID).WithField("destination", spec).Debug("mountpoint already exists, skipping anonymous volume") log.G(ctx).WithField("container", ctr.ID).WithField("destination", spec).Debug("mountpoint already exists, skipping anonymous volume")
// Not an error, this could easily have come from the image config. // Not an error, this could easily have come from the image config.
continue continue
} }
path, err := container.GetResourcePath(destination) path, err := ctr.GetResourcePath(destination)
if err != nil { if err != nil {
return err return err
} }
@@ -66,18 +64,18 @@ func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, container *c
return fmt.Errorf("cannot mount volume over existing file, file exists %s", path) return fmt.Errorf("cannot mount volume over existing file, file exists %s", path)
} }
v, err := daemon.volumes.Create(context.TODO(), "", hostConfig.VolumeDriver, volumeopts.WithCreateReference(container.ID)) v, err := daemon.volumes.Create(context.TODO(), "", ctr.HostConfig.VolumeDriver, volumeopts.WithCreateReference(ctr.ID))
if err != nil { if err != nil {
return err return err
} }
if err := label.Relabel(v.Mountpoint, container.MountLabel, true); err != nil { if err := label.Relabel(v.Mountpoint, ctr.MountLabel, true); err != nil {
return err return err
} }
container.AddMountPointWithVolume(destination, &volumeWrapper{v: v, s: daemon.volumes}, true) ctr.AddMountPointWithVolume(destination, &volumeWrapper{v: v, s: daemon.volumes}, true)
} }
return daemon.populateVolumes(ctx, container) return daemon.populateVolumes(ctx, ctr)
} }
// populateVolumes copies data from the container's rootfs into the volume for non-binds. // populateVolumes copies data from the container's rootfs into the volume for non-binds.

18
daemon/create_windows.go
View File

@@ -11,35 +11,33 @@ import (
) )
// createContainerOSSpecificSettings performs host-OS specific container create functionality // createContainerOSSpecificSettings performs host-OS specific container create functionality
func (daemon *Daemon) createContainerOSSpecificSettings(ctx context.Context, container *container.Container, hostConfig *containertypes.HostConfig) error { func (daemon *Daemon) createContainerOSSpecificSettings(ctx context.Context, ctr *container.Container) error {
if containertypes.Isolation.IsDefault(hostConfig.Isolation) { if containertypes.Isolation.IsDefault(ctr.HostConfig.Isolation) {
// Make sure the host config has the default daemon isolation if not specified by caller. // Make sure the host config has the default daemon isolation if not specified by caller.
hostConfig.Isolation = daemon.defaultIsolation ctr.HostConfig.Isolation = daemon.defaultIsolation
} }
return nil return nil
} }
// createContainerVolumesOS performs host-OS specific volume creation // createContainerVolumesOS performs host-OS specific volume creation
func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, container *container.Container, config *containertypes.Config, hostConfig *containertypes.HostConfig) error { func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, ctr *container.Container, config *containertypes.Config) error {
parser := volumemounts.NewParser() parser := volumemounts.NewParser()
for spec := range config.Volumes { for spec := range config.Volumes {
mp, err := parser.ParseMountRaw(spec, hostConfig.VolumeDriver) mp, err := parser.ParseMountRaw(spec, ctr.HostConfig.VolumeDriver)
if err != nil { if err != nil {
return fmt.Errorf("Unrecognised volume spec: %v", err) return fmt.Errorf("Unrecognised volume spec: %v", err)
} }
// Skip volumes for which we already have something mounted on that // Skip volumes for which we already have something mounted on that
// destination because of a --volume-from. // destination because of a --volume-from.
if container.IsDestinationMounted(mp.Destination) { if ctr.IsDestinationMounted(mp.Destination) {
continue continue
} }
volumeDriver := hostConfig.VolumeDriver
// Create the volume in the volume driver. If it doesn't exist, // Create the volume in the volume driver. If it doesn't exist,
// a new one will be created. // a new one will be created.
v, err := daemon.volumes.Create(ctx, "", volumeDriver, volumeopts.WithCreateReference(container.ID)) v, err := daemon.volumes.Create(ctx, "", ctr.HostConfig.VolumeDriver, volumeopts.WithCreateReference(ctr.ID))
if err != nil { if err != nil {
return err return err
} }
@@ -75,7 +73,7 @@ func (daemon *Daemon) createContainerVolumesOS(ctx context.Context, container *c
// } // }
// Add it to container.MountPoints // Add it to container.MountPoints
container.AddMountPointWithVolume(mp.Destination, &volumeWrapper{v: v, s: daemon.volumes}, mp.RW) ctr.AddMountPointWithVolume(mp.Destination, &volumeWrapper{v: v, s: daemon.volumes}, mp.RW)
} }
return nil return nil
} }