InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add helpers to create errdef errors

Browse Source 
Instead of having to create a bunch of custom error types that are doing
nothing but wrapping another error in sub-packages, use a common helper
to create errors of the requested type.

e.g. instead of re-implementing this over and over:

```go
type notFoundError struct {
  cause error
}

func(e notFoundError) Error() string {
  return e.cause.Error()
}

func(e notFoundError) NotFound() {}

func(e notFoundError) Cause() error {
  return e.cause
}
```

Packages can instead just do:

```
  errdefs.NotFound(err)
```

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This commit is contained in:
Brian Goff
2017-11-28 23:09:37 -05:00
parent 92309e34e4
commit 87a12421a9
65 changed files with 682 additions and 661 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
daemon/stop.go
View File

@@ -4,6 +4,7 @@ import (
"context"
"time"
"github.com/docker/docker/api/errdefs"
containerpkg "github.com/docker/docker/container"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
@@ -28,7 +29,7 @@ func (daemon *Daemon) ContainerStop(name string, seconds *int) error {
seconds = &stopTimeout
}
if err := daemon.containerStop(container, *seconds); err != nil {
return errors.Wrapf(systemError{err}, "cannot stop container: %s", name)
return errdefs.System(errors.Wrapf(err, "cannot stop container: %s", name))
}
return nil
}