InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

integration: migrate TestAPIImagesSizeCompatibility to integration test

Browse Source 
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
This commit is contained in:
Aditya Mishra
2025-11-19 15:43:20 +05:30
parent 9a84135d52
commit 87583c9029
2 changed files with 41 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
integration-cli/docker_api_images_test.go
View File

@@ -6,7 +6,6 @@ import (
"strings"
"testing"
"github.com/moby/moby/client"
"github.com/moby/moby/v2/internal/testutil"
"github.com/moby/moby/v2/internal/testutil/request"
"gotest.tools/v3/assert"
@@ -47,28 +46,3 @@ func (s *DockerAPISuite) TestAPIImagesSearchJSONContentType(c *testing.T) {
assert.Equal(c, res.StatusCode, http.StatusOK)
assert.Equal(c, res.Header.Get("Content-Type"), "application/json")
}
// Test case for 30027: image size reported as -1 in v1.12 client against v1.13 daemon.
// This test checks to make sure both v1.12 and v1.13 client against v1.13 daemon get correct `Size` after the fix.
func (s *DockerAPISuite) TestAPIImagesSizeCompatibility(c *testing.T) {
apiclient := testEnv.APIClient()
defer apiclient.Close()
imageList, err := apiclient.ImageList(testutil.GetContext(c), client.ImageListOptions{})
assert.NilError(c, err)
assert.Assert(c, len(imageList.Items) != 0)
for _, img := range imageList.Items {
assert.Assert(c, img.Size != int64(-1))
}
apiclient, err = client.New(client.FromEnv, client.WithAPIVersion("v1.24"))
assert.NilError(c, err)
defer apiclient.Close()
v124Images, err := apiclient.ImageList(testutil.GetContext(c), client.ImageListOptions{})
assert.NilError(c, err)
assert.Assert(c, len(v124Images.Items) != 0)
for _, img := range v124Images.Items {
assert.Assert(c, img.Size != int64(-1))
}
}