From 9f2faa5cec0a6a797757b59e33b5d29ce4632a1a Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 9 Jan 2026 13:58:04 +0100 Subject: [PATCH] client: fix TestWithUserAgent This test was testing the /_ping endpoint, which is intercepted by the default MockClient. Signed-off-by: Sebastiaan van Stijn --- client/client_options_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/client/client_options_test.go b/client/client_options_test.go index 6f4cdc643c..a0af40f349 100644 --- a/client/client_options_test.go +++ b/client/client_options_test.go @@ -301,7 +301,7 @@ func TestWithUserAgent(t *testing.T) { t.Run("user-agent", func(t *testing.T) { c, err := New( WithUserAgent(userAgent), - WithMockClient(func(req *http.Request) (*http.Response, error) { + WithBaseMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.Equal(req.Header.Get("User-Agent"), userAgent)) return &http.Response{StatusCode: http.StatusOK}, nil }), @@ -315,7 +315,7 @@ func TestWithUserAgent(t *testing.T) { c, err := New( WithUserAgent(userAgent), WithHTTPHeaders(map[string]string{"User-Agent": "should-be-ignored/1.0.0", "Other-Header": "hello-world"}), - WithMockClient(func(req *http.Request) (*http.Response, error) { + WithBaseMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.Equal(req.Header.Get("User-Agent"), userAgent)) assert.Check(t, is.Equal(req.Header.Get("Other-Header"), "hello-world")) return &http.Response{StatusCode: http.StatusOK}, nil @@ -329,7 +329,7 @@ func TestWithUserAgent(t *testing.T) { t.Run("custom headers", func(t *testing.T) { c, err := New( WithHTTPHeaders(map[string]string{"User-Agent": "from-custom-headers/1.0.0", "Other-Header": "hello-world"}), - WithMockClient(func(req *http.Request) (*http.Response, error) { + WithBaseMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.Equal(req.Header.Get("User-Agent"), "from-custom-headers/1.0.0")) assert.Check(t, is.Equal(req.Header.Get("Other-Header"), "hello-world")) return &http.Response{StatusCode: http.StatusOK}, nil @@ -343,7 +343,7 @@ func TestWithUserAgent(t *testing.T) { t.Run("no user-agent set", func(t *testing.T) { c, err := New( WithHTTPHeaders(map[string]string{"Other-Header": "hello-world"}), - WithMockClient(func(req *http.Request) (*http.Response, error) { + WithBaseMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.Equal(req.Header.Get("User-Agent"), "")) assert.Check(t, is.Equal(req.Header.Get("Other-Header"), "hello-world")) return &http.Response{StatusCode: http.StatusOK}, nil @@ -358,7 +358,7 @@ func TestWithUserAgent(t *testing.T) { c, err := New( WithUserAgent(""), WithHTTPHeaders(map[string]string{"User-Agent": "from-custom-headers/1.0.0", "Other-Header": "hello-world"}), - WithMockClient(func(req *http.Request) (*http.Response, error) { + WithBaseMockClient(func(req *http.Request) (*http.Response, error) { assert.Check(t, is.Equal(req.Header.Get("User-Agent"), "")) assert.Check(t, is.Equal(req.Header.Get("Other-Header"), "hello-world")) return &http.Response{StatusCode: http.StatusOK}, nil