remove uses of deprecated go-archive consts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-12-19 17:51:03 +01:00
parent 2142a4444c
commit 7239c72eca
14 changed files with 28 additions and 15 deletions

View File

@@ -8,6 +8,7 @@ import (
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/chrootarchive" "github.com/moby/go-archive/chrootarchive"
"github.com/moby/go-archive/compression"
containertypes "github.com/moby/moby/api/types/container" containertypes "github.com/moby/moby/api/types/container"
"github.com/moby/moby/api/types/events" "github.com/moby/moby/api/types/events"
"github.com/moby/moby/v2/daemon/container" "github.com/moby/moby/v2/daemon/container"
@@ -278,7 +279,7 @@ func (daemon *Daemon) containerCopy(container *container.Container, resource str
filter = []string{f} filter = []string{f}
} }
archv, err := chrootarchive.Tar(basePath, &archive.TarOptions{ archv, err := chrootarchive.Tar(basePath, &archive.TarOptions{
Compression: archive.Uncompressed, Compression: compression.None,
IncludeFiles: filter, IncludeFiles: filter,
}, container.BaseFS) }, container.BaseFS)
if err != nil { if err != nil {

View File

@@ -7,6 +7,7 @@ import (
"github.com/moby/buildkit/frontend/dockerfile/instructions" "github.com/moby/buildkit/frontend/dockerfile/instructions"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/v2/daemon/builder/remotecontext" "github.com/moby/moby/v2/daemon/builder/remotecontext"
"github.com/moby/sys/reexec" "github.com/moby/sys/reexec"
"gotest.tools/v3/assert" "gotest.tools/v3/assert"
@@ -105,7 +106,7 @@ func TestDispatch(t *testing.T) {
createTestTempFile(t, contextDir, filename, content, 0o777) createTestTempFile(t, contextDir, filename, content, 0o777)
} }
tarStream, err := archive.Tar(contextDir, archive.Uncompressed) tarStream, err := archive.Tar(contextDir, compression.None)
if err != nil { if err != nil {
t.Fatalf("Error when creating tar stream: %s", err) t.Fatalf("Error when creating tar stream: %s", err)
} }

View File

@@ -7,6 +7,7 @@ import (
"testing" "testing"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/api/types/container" "github.com/moby/moby/api/types/container"
"github.com/moby/moby/api/types/network" "github.com/moby/moby/api/types/network"
"github.com/moby/moby/v2/daemon/builder" "github.com/moby/moby/v2/daemon/builder"
@@ -61,7 +62,7 @@ func readAndCheckDockerfile(t *testing.T, testName, contextDir, dockerfilePath,
if runtime.GOOS != "windows" { if runtime.GOOS != "windows" {
skip.If(t, os.Getuid() != 0, "skipping test that requires root") skip.If(t, os.Getuid() != 0, "skipping test that requires root")
} }
tarStream, err := archive.Tar(contextDir, archive.Uncompressed) tarStream, err := archive.Tar(contextDir, compression.None)
assert.NilError(t, err) assert.NilError(t, err)
defer func() { defer func() {

View File

@@ -6,6 +6,7 @@ import (
"github.com/containerd/log" "github.com/containerd/log"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/v2/daemon/builder" "github.com/moby/moby/v2/daemon/builder"
"github.com/moby/moby/v2/daemon/builder/remotecontext/git" "github.com/moby/moby/v2/daemon/builder/remotecontext/git"
) )
@@ -17,7 +18,7 @@ func MakeGitContext(gitURL string) (builder.Source, error) {
return nil, err return nil, err
} }
c, err := archive.Tar(root, archive.Uncompressed) c, err := archive.Tar(root, compression.None)
if err != nil { if err != nil {
return nil, err return nil, err
} }

View File

@@ -6,6 +6,7 @@ import (
"testing" "testing"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/v2/daemon/builder" "github.com/moby/moby/v2/daemon/builder"
"github.com/moby/sys/reexec" "github.com/moby/sys/reexec"
"github.com/pkg/errors" "github.com/pkg/errors"
@@ -128,7 +129,7 @@ func TestRemoveDirectory(t *testing.T) {
func makeTestArchiveContext(t *testing.T, dir string) builder.Source { func makeTestArchiveContext(t *testing.T, dir string) builder.Source {
skip.If(t, os.Getuid() != 0, "skipping test that requires root") skip.If(t, os.Getuid() != 0, "skipping test that requires root")
tarStream, err := archive.Tar(dir, archive.Uncompressed) tarStream, err := archive.Tar(dir, compression.None)
if err != nil { if err != nil {
t.Fatalf("error: %s", err) t.Fatalf("error: %s", err)
} }

View File

@@ -15,6 +15,7 @@ import (
cerrdefs "github.com/containerd/errdefs" cerrdefs "github.com/containerd/errdefs"
"github.com/containerd/platforms" "github.com/containerd/platforms"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/v2/daemon/server/imagebackend" "github.com/moby/moby/v2/daemon/server/imagebackend"
"github.com/moby/moby/v2/internal/testutil/labelstore" "github.com/moby/moby/v2/internal/testutil/labelstore"
"github.com/moby/moby/v2/internal/testutil/specialimage" "github.com/moby/moby/v2/internal/testutil/specialimage"
@@ -39,7 +40,7 @@ func TestImageLoad(t *testing.T) {
imgSvc.defaultPlatformOverride = platforms.Only(linuxAmd64) imgSvc.defaultPlatformOverride = platforms.Only(linuxAmd64)
tryLoad := func(ctx context.Context, t *testing.T, dir string, platformList []ocispec.Platform) error { tryLoad := func(ctx context.Context, t *testing.T, dir string, platformList []ocispec.Platform) error {
tarRc, err := archive.Tar(dir, archive.Uncompressed) tarRc, err := archive.Tar(dir, compression.None)
assert.NilError(t, err) assert.NilError(t, err)
defer tarRc.Close() defer tarRc.Close()

View File

@@ -9,6 +9,7 @@ import (
"github.com/containerd/log" "github.com/containerd/log"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/chrootarchive" "github.com/moby/go-archive/chrootarchive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/api/types/events" "github.com/moby/moby/api/types/events"
"github.com/moby/moby/v2/daemon/container" "github.com/moby/moby/v2/daemon/container"
"github.com/moby/moby/v2/errdefs" "github.com/moby/moby/v2/errdefs"
@@ -65,7 +66,7 @@ func (daemon *Daemon) containerExport(ctx context.Context, ctr *container.Contai
}() }()
archv, err := chrootarchive.Tar(basefs, &archive.TarOptions{ archv, err := chrootarchive.Tar(basefs, &archive.TarOptions{
Compression: archive.Uncompressed, Compression: compression.None,
IDMap: daemon.idMapping, IDMap: daemon.idMapping,
}, basefs) }, basefs)
if err != nil { if err != nil {

View File

@@ -8,6 +8,7 @@ import (
"github.com/containerd/log" "github.com/containerd/log"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/chrootarchive" "github.com/moby/go-archive/chrootarchive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/v2/pkg/ioutils" "github.com/moby/moby/v2/pkg/ioutils"
"github.com/moby/sys/user" "github.com/moby/sys/user"
) )
@@ -64,7 +65,7 @@ func (gdw *NaiveDiffDriver) Diff(id, parent string) (arch io.ReadCloser, retErr
}() }()
if parent == "" { if parent == "" {
tarArchive, err := archive.Tar(layerFs, archive.Uncompressed) tarArchive, err := archive.Tar(layerFs, compression.None)
if err != nil { if err != nil {
return nil, err return nil, err
} }

View File

@@ -19,6 +19,7 @@ import (
"github.com/docker/go-units" "github.com/docker/go-units"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/chrootarchive" "github.com/moby/go-archive/chrootarchive"
"github.com/moby/go-archive/compression"
"github.com/moby/locker" "github.com/moby/locker"
"github.com/moby/moby/v2/daemon/graphdriver" "github.com/moby/moby/v2/daemon/graphdriver"
"github.com/moby/moby/v2/daemon/graphdriver/overlayutils" "github.com/moby/moby/v2/daemon/graphdriver/overlayutils"
@@ -721,7 +722,7 @@ func (d *Driver) Diff(id, parent string) (io.ReadCloser, error) {
diffPath := d.getDiffPath(id) diffPath := d.getDiffPath(id)
logger.Debugf("Tar with options on %s", diffPath) logger.Debugf("Tar with options on %s", diffPath)
return archive.TarWithOptions(diffPath, &archive.TarOptions{ return archive.TarWithOptions(diffPath, &archive.TarOptions{
Compression: archive.Uncompressed, Compression: compression.None,
IDMap: d.idMap, IDMap: d.idMap,
WhiteoutFormat: archive.OverlayWhiteoutFormat, WhiteoutFormat: archive.OverlayWhiteoutFormat,
}) })

View File

@@ -17,6 +17,7 @@ import (
"github.com/distribution/reference" "github.com/distribution/reference"
"github.com/docker/distribution" "github.com/docker/distribution"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/api/types/events" "github.com/moby/moby/api/types/events"
"github.com/moby/moby/v2/daemon/internal/image" "github.com/moby/moby/v2/daemon/internal/image"
v1 "github.com/moby/moby/v2/daemon/internal/image/v1" v1 "github.com/moby/moby/v2/daemon/internal/image/v1"
@@ -395,7 +396,7 @@ func (s *saveSession) writeTar(ctx context.Context, tempDir string, outStream io
ctx, span := tracing.StartSpan(ctx, "writeTar") ctx, span := tracing.StartSpan(ctx, "writeTar")
defer span.End() defer span.End()
fs, err := archive.Tar(tempDir, archive.Uncompressed) fs, err := archive.Tar(tempDir, compression.None)
if err != nil { if err != nil {
span.SetStatus(err) span.SetStatus(err)
return err return err

View File

@@ -12,6 +12,7 @@ import (
"github.com/containerd/continuity/driver" "github.com/containerd/continuity/driver"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/v2/daemon/graphdriver" "github.com/moby/moby/v2/daemon/graphdriver"
"github.com/moby/moby/v2/daemon/graphdriver/vfs" "github.com/moby/moby/v2/daemon/graphdriver/vfs"
"github.com/moby/moby/v2/daemon/internal/stringid" "github.com/moby/moby/v2/daemon/internal/stringid"
@@ -587,7 +588,7 @@ func tarFromFiles(files ...FileApplier) ([]byte, error) {
} }
} }
r, err := archive.Tar(td, archive.Uncompressed) r, err := archive.Tar(td, compression.None)
if err != nil { if err != nil {
return nil, err return nil, err
} }

View File

@@ -2025,11 +2025,11 @@ CMD ["cat", "/foo"]`),
} }
func (s *DockerCLIBuildSuite) TestBuildContextTarGzip(c *testing.T) { func (s *DockerCLIBuildSuite) TestBuildContextTarGzip(c *testing.T) {
testContextTar(c, archive.Gzip) testContextTar(c, compression.Gzip)
} }
func (s *DockerCLIBuildSuite) TestBuildContextTarNoCompression(c *testing.T) { func (s *DockerCLIBuildSuite) TestBuildContextTarNoCompression(c *testing.T) {
testContextTar(c, archive.Uncompressed) testContextTar(c, compression.None)
} }
func (s *DockerCLIBuildSuite) TestBuildNoContext(c *testing.T) { func (s *DockerCLIBuildSuite) TestBuildNoContext(c *testing.T) {

View File

@@ -10,6 +10,7 @@ import (
"time" "time"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/moby/moby/api/types/events" "github.com/moby/moby/api/types/events"
plugintypes "github.com/moby/moby/api/types/plugin" plugintypes "github.com/moby/moby/api/types/plugin"
"github.com/moby/moby/api/types/registry" "github.com/moby/moby/api/types/registry"
@@ -209,7 +210,7 @@ func makePluginBundle(inPath string, opts ...CreateOpt) (io.ReadCloser, error) {
if err := archive.NewDefaultArchiver().CopyFileWithTar(cfg.binPath, filepath.Join(inPath, "rootfs", p.Entrypoint[0])); err != nil { if err := archive.NewDefaultArchiver().CopyFileWithTar(cfg.binPath, filepath.Join(inPath, "rootfs", p.Entrypoint[0])); err != nil {
return nil, errors.Wrap(err, "error copying plugin binary to rootfs path") return nil, errors.Wrap(err, "error copying plugin binary to rootfs path")
} }
tar, err := archive.Tar(inPath, archive.Uncompressed) tar, err := archive.Tar(inPath, compression.None)
return tar, errors.Wrap(err, "error making plugin archive") return tar, errors.Wrap(err, "error making plugin archive")
} }

View File

@@ -11,6 +11,7 @@ import (
"github.com/distribution/reference" "github.com/distribution/reference"
"github.com/google/uuid" "github.com/google/uuid"
"github.com/moby/go-archive" "github.com/moby/go-archive"
"github.com/moby/go-archive/compression"
"github.com/opencontainers/go-digest" "github.com/opencontainers/go-digest"
"github.com/opencontainers/image-spec/specs-go" "github.com/opencontainers/image-spec/specs-go"
ocispec "github.com/opencontainers/image-spec/specs-go/v1" ocispec "github.com/opencontainers/image-spec/specs-go/v1"
@@ -137,7 +138,7 @@ func fileArchive(dir string, name string, content []byte) (io.ReadCloser, error)
return nil, err return nil, err
} }
return archive.Tar(tmp, archive.Uncompressed) return archive.Tar(tmp, compression.None)
} }
func writeLayerWithOneFile(dir string, filename string, content []byte) (ocispec.Descriptor, error) { func writeLayerWithOneFile(dir string, filename string, content []byte) (ocispec.Descriptor, error) {