test: migrate test api client version old not supported

Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
This commit is contained in:
Muhammad Daffa Dinaya
2025-07-22 14:49:43 +00:00
parent c9a83e3161
commit 34fb2486ef
2 changed files with 19 additions and 30 deletions

View File

@@ -1,18 +1,12 @@
package main
import (
"bytes"
"context"
"fmt"
"net/http"
"runtime"
"strconv"
"strings"
"testing"
"github.com/docker/docker/testutil"
"github.com/docker/docker/testutil/request"
"github.com/moby/moby/api/types/versions"
"gotest.tools/v3/assert"
is "gotest.tools/v3/assert/cmp"
)
@@ -47,30 +41,6 @@ func (s *DockerAPISuite) TestAPIGetEnabledCORS(c *testing.T) {
// assert.Equal(c, res.Header.Get("Access-Control-Allow-Headers"), "Origin, X-Requested-With, Content-Type, Accept, X-Registry-Auth")
}
func (s *DockerAPISuite) TestAPIClientVersionOldNotSupported(c *testing.T) {
if testEnv.DaemonInfo.OSType != runtime.GOOS {
c.Skip("Daemon platform doesn't match test platform")
}
major, minor, _ := strings.Cut(testEnv.DaemonVersion.MinAPIVersion, ".")
vMinInt, err := strconv.Atoi(minor)
assert.NilError(c, err)
vMinInt--
version := fmt.Sprintf("%s.%d", major, vMinInt)
resp, body, err := request.Get(testutil.GetContext(c), "/v"+version+"/version")
assert.NilError(c, err)
assert.Equal(c, resp.StatusCode, http.StatusBadRequest)
expected := fmt.Sprintf("client version %s is too old. Minimum supported API version is %s, please upgrade your client to a newer version", version, testEnv.DaemonVersion.MinAPIVersion)
b, err := request.ReadBody(body)
assert.NilError(c, err)
errMessage := string(bytes.TrimSpace(b))
if versions.GreaterThanOrEqualTo(version, "1.24") {
errMessage = getErrorMessage(c, b)
}
assert.Equal(c, errMessage, expected)
}
func (s *DockerAPISuite) TestAPIErrorJSON(c *testing.T) {
httpResp, body, err := request.Post(testutil.GetContext(c), "/containers/create", request.JSONBody(struct{}{}))
assert.NilError(c, err)