InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

api/types/events: define "Action" type and consts

Browse Source 
Define consts for the Actions we use for events, instead of "ad-hoc" strings.
Having these consts makes it easier to find where specific events are triggered,
makes the events less error-prone, and allows documenting each Action (if needed).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2023-08-26 15:24:46 +02:00
parent 10a3a3bc49
commit 0f871f8cb7
70 changed files with 284 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
daemon/attach.go
View File

@@ -7,6 +7,7 @@ import (
"github.com/containerd/containerd/log"
"github.com/docker/docker/api/types/backend"
"github.com/docker/docker/api/types/events"
"github.com/docker/docker/container"
"github.com/docker/docker/container/stream"
"github.com/docker/docker/daemon/logger"
@@ -146,7 +147,7 @@ func (daemon *Daemon) containerAttach(c *container.Container, cfg *stream.Attach
}
}
daemon.LogContainerEvent(c, "attach")
daemon.LogContainerEvent(c, events.ActionAttach)
if !doStream {
return nil
@@ -179,7 +180,7 @@ func (daemon *Daemon) containerAttach(c *container.Container, cfg *stream.Attach
if err != nil {
var ierr term.EscapeError
if errors.Is(err, context.Canceled) || errors.As(err, &ierr) {
daemon.LogContainerEvent(c, "detach")
daemon.LogContainerEvent(c, events.ActionDetach)
} else {
log.G(ctx).Errorf("attach failed with error: %v", err)
}