From 0ea20c9f722828c76f9274193d98c8de72bd216b Mon Sep 17 00:00:00 2001
From: Kevin Alvarez <github@crazymax.dev>
Date: Thu, 26 Jun 2025 15:46:41 +0200
Subject: [PATCH] cmd: fix winresources and move them out cli package

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
---
 .dockerignore                                      |   4 ++--
 .gitignore                                         |   4 ++--
 Dockerfile                                         |   1 -
 cmd/dockerd/builtins/builtins.go                   |   1 -
 cmd/dockerd/builtins/genwinres_windows.go          |   5 -----
 cmd/dockerd/main.go                                |   2 --
 cmd/dockerd/main_windows.go                        |   5 +++++
 {cli => cmd/dockerd}/winresources/docker.ico       | Bin
 .../dockerd}/winresources/event_messages.bin       | Bin
 .../dockerd}/winresources/event_messages.mc        |   0
 .../dockerd/winresources}/winresources.go          |   4 ++--
 hack/make/.go-autogen.ps1                          |  12 +++---------
 hack/make/.mkwinres                                |  13 ++++---------
 13 files changed, 18 insertions(+), 33 deletions(-)
 delete mode 100644 cmd/dockerd/builtins/builtins.go
 delete mode 100644 cmd/dockerd/builtins/genwinres_windows.go
 create mode 100644 cmd/dockerd/main_windows.go
 rename {cli => cmd/dockerd}/winresources/docker.ico (100%)
 rename {cli => cmd/dockerd}/winresources/event_messages.bin (100%)
 rename {cli => cmd/dockerd}/winresources/event_messages.mc (100%)
 rename {cli/winresources/dockerd => cmd/dockerd/winresources}/winresources.go (71%)

diff --git a/.dockerignore b/.dockerignore
index e96d479eea..bb9472f10d 100644
--- a/.dockerignore
+++ b/.dockerignore
@@ -2,5 +2,5 @@
 
 # build artifacts
 /bundles/
-/cli/winresources/dockerd/winres.json
-/cli/winresources/dockerd/*.syso
+/cmd/dockerd/winresources/winres.json
+/cmd/dockerd/*.syso
diff --git a/.gitignore b/.gitignore
index 1b8bf27fce..15a6913ab5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,8 +15,8 @@ thumbs.db
 
 # build artifacts
 /bundles/
-/cli/winresources/dockerd/*.syso
-/cli/winresources/dockerd/winres.json
+/cmd/dockerd/winresources/winres.json
+/cmd/dockerd/*.syso
 
 # ci artifacts
 *.exe
diff --git a/Dockerfile b/Dockerfile
index 041a40c899..6191381ad3 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -579,7 +579,6 @@ RUN <<EOT
   fi
 EOT
 RUN --mount=type=bind,target=.,rw \
-    --mount=type=tmpfs,target=cli/winresources/dockerd \
     --mount=type=cache,target=/root/.cache/go-build,id=moby-build-$TARGETPLATFORM <<EOT
   set -e
   target=$([ "$DOCKER_STATIC" = "1" ] && echo "binary" || echo "dynbinary")
diff --git a/cmd/dockerd/builtins/builtins.go b/cmd/dockerd/builtins/builtins.go
deleted file mode 100644
index 6c14e39f38..0000000000
--- a/cmd/dockerd/builtins/builtins.go
+++ /dev/null
@@ -1 +0,0 @@
-package builtins
diff --git a/cmd/dockerd/builtins/genwinres_windows.go b/cmd/dockerd/builtins/genwinres_windows.go
deleted file mode 100644
index f58997f5cb..0000000000
--- a/cmd/dockerd/builtins/genwinres_windows.go
+++ /dev/null
@@ -1,5 +0,0 @@
-//go:generate go-winres make --arch=386,amd64,arm,arm64 --in=../../../cli/winresources/dockerd/winres.json --out=../../../cli/winresources/dockerd/resource
-
-package builtins
-
-import _ "github.com/docker/docker/cli/winresources/dockerd"
diff --git a/cmd/dockerd/main.go b/cmd/dockerd/main.go
index 899ac06b96..1e46409fa4 100644
--- a/cmd/dockerd/main.go
+++ b/cmd/dockerd/main.go
@@ -11,8 +11,6 @@ import (
 	"github.com/moby/term"
 
 	"github.com/docker/docker/daemon/command"
-
-	_ "github.com/docker/docker/cmd/dockerd/builtins"
 )
 
 func main() {
diff --git a/cmd/dockerd/main_windows.go b/cmd/dockerd/main_windows.go
new file mode 100644
index 0000000000..4d5405735a
--- /dev/null
+++ b/cmd/dockerd/main_windows.go
@@ -0,0 +1,5 @@
+//go:generate go-winres make --arch=386,amd64,arm,arm64 --in=./winresources/winres.json --out=./resource
+
+package main
+
+import _ "github.com/docker/docker/cmd/dockerd/winresources"
diff --git a/cli/winresources/docker.ico b/cmd/dockerd/winresources/docker.ico
similarity index 100%
rename from cli/winresources/docker.ico
rename to cmd/dockerd/winresources/docker.ico
diff --git a/cli/winresources/event_messages.bin b/cmd/dockerd/winresources/event_messages.bin
similarity index 100%
rename from cli/winresources/event_messages.bin
rename to cmd/dockerd/winresources/event_messages.bin
diff --git a/cli/winresources/event_messages.mc b/cmd/dockerd/winresources/event_messages.mc
similarity index 100%
rename from cli/winresources/event_messages.mc
rename to cmd/dockerd/winresources/event_messages.mc
diff --git a/cli/winresources/dockerd/winresources.go b/cmd/dockerd/winresources/winresources.go
similarity index 71%
rename from cli/winresources/dockerd/winresources.go
rename to cmd/dockerd/winresources/winresources.go
index b71057bafe..82e44ba696 100644
--- a/cli/winresources/dockerd/winresources.go
+++ b/cmd/dockerd/winresources/winresources.go
@@ -7,6 +7,6 @@
 // * Events message table
 //
 // The resource object files are generated when building with go-winres
-// in hack/make/.go-autogen and are located in cli/winresources.
-// This occurs automatically when you cross build against Windows OS.
+// in hack/make/.go-autogen. This occurs automatically when you cross build
+// against Windows OS.
 package winresources
diff --git a/hack/make/.go-autogen.ps1 b/hack/make/.go-autogen.ps1
index 1db8dac9bf..0a95818d80 100644
--- a/hack/make/.go-autogen.ps1
+++ b/hack/make/.go-autogen.ps1
@@ -72,7 +72,7 @@ try {
     $mkwinresContents = '{
   "RT_GROUP_ICON": {
     "#1": {
-      "0409": "../../winresources/docker.ico"
+      "0409": "docker.ico"
     }
   },
   "RT_MANIFEST": {
@@ -99,7 +99,7 @@ try {
   },
   "RT_MESSAGETABLE": {
     "#1": {
-      "0409": "../../winresources/event_messages.bin"
+      "0409": "event_messages.bin"
     }
   },
   "RT_VERSION": {
@@ -127,17 +127,11 @@ try {
 }'
 
     # Write the file
-    $outputFile="$(Get-Location)\cli\winresources\dockerd\winres.json"
+    $outputFile="$(Get-Location)\cmd\dockerd\winresources\winres.json"
     if (Test-Path $outputFile) { Remove-Item $outputFile }
     [System.IO.File]::WriteAllText($outputFile, $mkwinresContents)
     Get-Content $outputFile | Out-Host
 
-    # Create winresources package stub if removed while using tmpfs in Dockerfile
-    $stubPackage="$(Get-Location)\cli\winresources\dockerd\winresources.go"
-    if(![System.IO.File]::Exists($stubPackage)){
-        Set-Content -NoNewline -Path $stubPackage -Value 'package winresources'
-    }
-
     # Generate
     go generate -v "github.com/docker/docker/cmd/dockerd"
     if ($LASTEXITCODE -ne 0) { Throw "Failed to generate version info" }
diff --git a/hack/make/.mkwinres b/hack/make/.mkwinres
index 70d66814c2..0bef6288f6 100644
--- a/hack/make/.mkwinres
+++ b/hack/make/.mkwinres
@@ -16,11 +16,11 @@ VERSION_QUAD=$(printf "%s" "$VERSION" | sed -re 's/^([0-9.]*).*$/\1/' | sed -re
 # Microsoft Windows Version Information and an icon using go-winres.
 # https://docs.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block
 # https://github.com/tc-hib/go-winres#json-format
-cat > "./cli/winresources/${BINARY_NAME}/winres.json" << EOL
+cat > "./cmd/${BINARY_NAME}/winresources/winres.json" << EOL
 {
   "RT_GROUP_ICON": {
     "#1": {
-      "0409": "../../winresources/docker.ico"
+      "0409": "docker.ico"
     }
   },
   "RT_MANIFEST": {
@@ -47,7 +47,7 @@ cat > "./cli/winresources/${BINARY_NAME}/winres.json" << EOL
   },
   "RT_MESSAGETABLE": {
     "#1": {
-      "0409": "../../winresources/event_messages.bin"
+      "0409": "event_messages.bin"
     }
   },
   "RT_VERSION": {
@@ -76,10 +76,5 @@ cat > "./cli/winresources/${BINARY_NAME}/winres.json" << EOL
 EOL
 (
 	set -x
-	cat "./cli/winresources/${BINARY_NAME}/winres.json"
+	cat "./cmd/${BINARY_NAME}/winresources/winres.json"
 )
-
-# Create winresources package stub if removed while using tmpfs in Dockerfile
-if [ ! -f "./cli/winresources/${BINARY_NAME}/winresources.go" ]; then
-	echo "package winresources" > "./cli/winresources/${BINARY_NAME}/winresources.go"
-fi