Scott Lee fa62515ecb presubmit: emit errors instead of warnings for bad copyright headers ...

This is an effective revert of https://crrev.com/c/4895337 with
additional patches to support a footer.

https://crrev.com/c/3887721 updated CheckLicense() to emit errors
for bad copyright headers. However, https://crrev.com/c/4895337
was changed the finding type from error to warning, claiming that
the check is N/A for moved third files, but it's not so easy
to programatiically distinguish moved third-party files.

After discussions, it was decided to change the finding type back
to error to prevent accidental submissions for new files without
correct CopyRight headers.

To mitigate moved, third-party files, this CL adds support for
"Bypass-Check-License: <reason>" footer.

If the check should be ignored in a given CL, CL authors should
use the footer instead.

Bug: 435696543,40237859
Change-Id: I177915c65932a3d76ea60ee6a0e396f726bc400d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6842238
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>

2025-08-14 09:55:48 -07:00

..

gerrit_util_test.inputs

[gerrit_util] Add some additional tests and fixes for SSOAuthenticator.

2024-06-21 21:54:38 +00:00

git_common_test.inputs

Prefer direct git installation for Windows

2024-11-13 03:10:47 +00:00

gstools

Upload script for first class gcs deps

2024-03-26 16:54:20 +00:00

split_cl_test.inputs

git cl split: Save and load splittings from files

2025-02-11 07:38:29 -08:00

auth_test.py

[auth] Be able to generate id_token

2023-09-28 22:02:04 +00:00

autoninja_test.py

autoninja: disable siso native by --reapi_address=

2025-06-24 17:43:48 -07:00

bazel_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

bot_update_coverage_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

build_telemetry_test.py

build_telemetry: Set timeout to 'cipd auth-info' command.

2024-09-06 11:01:14 +00:00

cipd_bootstrap_test.py

Update cipd_bootstrap_test to use a newer cipd client binary.

2024-01-12 02:06:06 +00:00

create_temp_file_test.py

depot_tools: add create_temp_file.py

2025-07-28 11:27:45 -07:00

detect_host_arch_test.py

[detect_host_arch] Cache HostArch() function

2023-11-30 23:29:09 +00:00

download_from_google_storage_unittest.py

Upload script for first class gcs deps

2024-03-26 16:54:20 +00:00

fetch_test.py

fetch: stop setting submodules config as we are not using it at all

2023-11-01 20:07:13 +00:00

gclient_cipd_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_eval_unittest.py

run tests using python 3.8

2024-06-12 22:00:15 +00:00

gclient_gcs_smoketest.py

Make the downloaded tarfile a dotfile

2024-04-16 16:34:49 +00:00

gclient_git_mutates_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_git_smoketest.py

Update CMDgitmodules to set gclient-recursedeps in .gitmodules file.

2024-10-04 17:19:37 +00:00

gclient_no_sync_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_paths_test.py

Cache values in gclient_paths.py

2023-10-03 20:36:59 +00:00

gclient_scm_test.py

Make sure _UpdateMirrorIfNotContains fetches the specified revision

2025-04-10 10:28:20 -07:00

gclient_smoketest_base.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

gclient_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

gclient_transitions_smoketest.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

gclient_utils_test.py

Explicitly propagate terminal size to gclient hooks.

2025-01-09 15:47:51 -08:00

gerrit_client_test.py

gerrit: addmessage: support attention set control

2025-01-15 09:28:03 -08:00

gerrit_util_test.py

[gerrit_util] Add CheckShouldUseSSO function

2025-03-10 12:26:54 -07:00

git_auth_test.py

[git_auth] Add useHttpPath config for Gerrit auth

2025-08-07 14:07:49 -07:00

git_cache_test.py

[git_cache] support ssh url

2024-03-26 14:24:43 +00:00

git_cl_creds_check_report.txt

Fix gerrit new-password URL

2023-02-03 17:52:03 +00:00

git_cl_test.py

Remove support for RobotComments, which have been removed from Gerrit.

2025-07-01 14:23:35 -07:00

git_common_test.py

Modify git squash-branch to perform reparenting

2025-02-05 10:15:43 -08:00

git_dates_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

git_find_releases_test.py

Skip tests not supported in non-git env if in non-git env

2024-07-29 17:45:57 +00:00

git_footers_test.py

[git_footers] add support for multiline footers

2024-12-03 17:24:52 +00:00

git_hyper_blame_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

git_map_test.py

Fix git_map_test.py

2025-04-01 15:18:44 -07:00

git_number_test.py

Revert "[git-number] Remove unused git-number script."

2024-08-09 01:40:20 +00:00

git_rebase_update_test.py

Colorize branch names for rebase-update

2025-02-19 11:45:40 -08:00

git_squash_branch_test.py

Modify git squash-branch to perform reparenting

2025-02-05 10:15:43 -08:00

git_squash_branch_tree_test.py

Add git squash-branch-tree

2024-07-02 15:03:58 +00:00

gn_helper_test.py

gn_helper: find correct directory for //

2024-11-27 04:20:40 +00:00

gsutil_test.py

Improve ensure_gsutil reliability

2025-04-28 10:31:42 -07:00

hooks_test.py

Require prompt from users to confirm submodules commit.

2023-09-20 22:01:47 +00:00

lockfile_test.py

[gsutil] Fix race when downloading gsutil

2024-05-01 16:41:16 +00:00

luci_auth_fido2_plugin_test.py

Add luci-auth-fido2-plugin

2025-08-11 14:54:09 -07:00

metrics_test.py

[metrics] Add new auth metric

2024-08-19 19:53:47 +00:00

metrics_xml_format_test.py

Reland "Support formatting metrics xml(s) in the subfolders."

2024-12-19 14:14:40 -08:00

my_activity_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

ninjalog_uploader_test.py

ninjalog_uploader: Add is_cloudtop, gce_machine_type, is_cog to the Ninjalog metadata

2024-09-24 08:22:42 +00:00

OWNERS

Remove brucedawson@ from some depot_tools OWNERS files

2024-10-04 17:34:17 +00:00

owners_client_test.py

Select a minimal number of owners for a set of files

2025-03-04 12:19:30 -08:00

owners_finder_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

presubmit_canned_checks_test.py

CheckNewDEPSHooksHasRequiredReviewers checks approval from required

2025-03-07 09:46:45 -08:00

presubmit_diff_test.py

presubmit_diff: add support for -U

2025-01-17 14:51:19 -08:00

presubmit_support_test.py

presubmit: add location data to presubmit result

2025-04-22 12:26:12 -07:00

presubmit_unittest.py

presubmit: emit errors instead of warnings for bad copyright headers

2025-08-14 09:55:48 -07:00

rdb_wrapper_test.py

Remove __future__ imports

2023-09-25 17:13:00 +00:00

recipes_test.py

Support recipes_test.py in non-git workspace

2024-02-22 18:48:33 +00:00

reclient_helper_test.py

autoninja: Use AUTONINJA_BUILD_ID for RBE_invocation_id as is.

2024-07-25 14:21:27 +00:00

roll_dep_test.py

Change readme updating to be on by default for roll_dep.py

2025-05-09 15:35:10 -07:00

roll_downstream_gcs_deps_test.py

Update roll_downstream_gcs_deps to take a list of source and destination packages.

2024-09-17 22:36:08 +00:00

scm_mock.py

[scm_mock] Expose mocking of system config layer.

2024-08-09 20:23:54 +00:00

scm_unittest.py

[scm] Handle empty .gitmodules file

2024-10-10 19:02:39 +00:00

split_cl_test.py

split: update SelectReviewersForFiles to work with repository root

2025-04-24 08:36:02 -07:00

subcommand_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

subprocess2_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

upload_to_google_storage_first_class_unittest.py

Add generation version number to GCS first-class entries.

2024-04-04 23:23:00 +00:00

upload_to_google_storage_unittest.py

Remove last py2 workarounds

2023-09-07 18:13:01 +00:00

utils_test.py

Use $HOME/.config/depot_tools on linux for .cfg files

2024-06-12 04:02:48 +00:00

watchlists_unittest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00