Bruce Dawson db8622bc6b Ensure _PresubmitResult._message is text ...

It is easy to get type confusion and end up passing a list as the
message parameter to _PresubmitResult. This error will not be detected
until the end of the run - perhaps hours later - when all evidence of
where the list came from is lost.

This change ensures that the message parameter is a string. If it is not
then the exception that is thrown should allow quick identification of
the problematic code.

This also fixes a presubmit unit test that passed None as the message.
We could support that but I don't think that we should.

Bug: 1309977
Change-Id: Ifb1d5100d47922b0ebd8bb834caa6fbba690b43c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3566436
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

2022-04-03 15:38:12 +00:00

..

gstools

Scripts to download files from google storage based on sha1 sums

2013-03-13 21:43:51 +00:00

auth_test.py

Run spellchecker on depot_tools

2020-04-13 17:49:39 +00:00

bot_update_coverage_test.py

Use pylint 2.7 for depot_tools

2022-01-24 23:56:57 +00:00

cipd_bootstrap_test.py

[cipd] Take cipd.ps1 out of %PATH%.

2020-04-22 18:17:46 +00:00

detect_host_arch_test.py

gclient: Correctly set host_cpu to arm64 on arm macs

2021-03-22 18:32:24 +00:00

download_from_google_storage_unittest.py

Use pylint 2.7 for depot_tools

2022-01-24 23:56:57 +00:00

fetch_test.py

Update argument parsing to use argparse

2022-03-23 21:13:13 +00:00

fix_encoding_test.py

Make fix_encoding_test py3 compatible

2021-11-22 23:32:29 +00:00

gclient_cipd_smoketest.py

depot_tools: Split gclient_smoketests.

2020-03-25 21:21:30 +00:00

gclient_eval_unittest.py

metrics: Don't print notice if reporting build metrics.

2021-05-06 20:02:39 +00:00

gclient_git_mutates_smoketest.py

gclient: Split gclient smoke tests.

2021-02-02 20:38:15 +00:00

gclient_git_smoketest.py

Use main branch as the default branch

2021-07-13 17:44:53 +00:00

gclient_paths_test.py

depot_tools: Add tests for gclient_paths

2020-01-08 20:06:51 +00:00

gclient_scm_test.py

Fix host and repo parsing for download-topics

2022-03-10 18:19:59 +00:00

gclient_smoketest_base.py

Use pylint 2.7 for depot_tools

2022-01-24 23:56:57 +00:00

gclient_smoketest.py

depot_tools: Split gclient_smoketests.

2020-03-25 21:21:30 +00:00

gclient_test.py

Revert "Remove unused functionality in bot_update.py"

2022-02-08 21:26:21 +00:00

gclient_transitions_smoketest.py

depot_tools: Split gclient_smoketests.

2020-03-25 21:21:30 +00:00

gclient_utils_test.py

update stale codereview.chromium.org links

2021-01-13 01:38:34 +00:00

gerrit_client_test.py

Add a 'setlabel' command to gerrit_client.py

2021-10-06 01:23:24 +00:00

gerrit_util_test.py

Handle spaces in Gerrit search options

2021-05-12 18:23:24 +00:00

git_cache_test.py

add support for main in git_cache

2020-11-17 18:09:21 +00:00

git_cl_creds_check_report.txt

git cl: remove check for likely wrong identities.

2020-11-12 14:27:24 +00:00

git_cl_test.py

Add git cl presubmit --files

2022-03-31 23:47:53 +00:00

git_common_test.py

Fix git_common_test.py: git checkout -tb -> git checkout -t -b

2022-01-18 19:42:54 +00:00

git_dates_test.py

Use assertEqual() rather than assertEquals() in Python tests.

2019-10-14 17:49:39 +00:00

git_find_releases_test.py

Use pylint 2.7 for depot_tools

2022-01-24 23:56:57 +00:00

git_footers_test.py

Use main branch as the default branch

2021-07-13 17:44:53 +00:00

git_hyper_blame_test.py

Add support for git_hyper_blame for Windows

2020-03-24 21:04:57 +00:00

git_map_test.py

Use main branch as the default branch

2021-07-13 17:44:53 +00:00

git_migrate_default_branch_test.py

Use pylint 2.7 for depot_tools

2022-01-24 23:56:57 +00:00

git_number_test.py

depot_tools: Run auth, cipd_bootstrap, git_number tests on python3.

2019-11-21 00:52:46 +00:00

git_rebase_update_test.py

Fix depot_tools tests when running without py2

2022-01-24 18:32:38 +00:00

gsutil_test.py

Refactor gsutil and fix concurrecny issue on MacOS

2021-09-17 16:59:49 +00:00

lockfile_test.py

Reland "Use OS level locking in git_cache.py"

2020-05-21 01:36:34 +00:00

metrics_test.py

Use main branch as the default branch

2021-07-13 17:44:53 +00:00

my_activity_test.py

Require certifi package and python3 in my_activity

2021-10-05 23:55:34 +00:00

ninjalog_uploader_test.py

fix ninjalog_uploader.py

2022-01-21 00:04:23 +00:00

OWNERS

[ninjalog_uploader] add tests

2018-12-17 23:45:49 +00:00

owners_client_test.py

Reland "presubmit: Skip owners checks if code-owners plugin is enabled."

2021-03-19 20:04:43 +00:00

owners_finder_test.py

owners_finder: Use code-owners plugin if available.

2021-02-19 00:34:25 +00:00

owners_unittest.py

Run spellchecker on depot_tools

2020-04-13 17:49:39 +00:00

presubmit_unittest.py

Ensure _PresubmitResult._message is text

2022-04-03 15:38:12 +00:00

PRESUBMIT.py

Follow-up to 61bf638 to add the py3-specific PRESUBMIT.py test.

2021-04-28 16:20:31 +00:00

rdb_wrapper_test.py

[resultdb] use requests.Session in rdb_wrapper

2020-11-19 19:38:06 +00:00

recipes_test.py

add vpython3 to tests that run under vpython3

2021-11-18 21:43:40 +00:00

roll_dep_test.py

Fix Python3 integer division issue in roll-dep.

2020-04-01 16:21:40 +00:00

scm_unittest.py

Refresh remote HEAD if matches legacy default

2021-09-09 23:03:47 +00:00

split_cl_test.py

Update format of git cl split

2021-06-23 08:51:34 +00:00

subcommand_test.py

Move subcommand_test to py3

2020-03-17 16:01:24 +00:00

subprocess2_test.py

Use pylint 2.7 for depot_tools

2022-01-24 23:56:57 +00:00

upload_to_google_storage_unittest.py

Set cache-control when uploading to google storage

2021-09-20 22:31:37 +00:00

utils_test.py

Add a basic depot_tools version information

2022-03-21 23:11:51 +00:00

watchlists_unittest.py

depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock

2020-01-06 18:47:54 +00:00