Robert Iannucci b46b033bd7 [git-cl] Make quick Gerrit RPC at the top of CMDupload. ...

This prevents the following scenario:

$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # requires thinking
CRASH!! You need to authenticate!!
$ <authenticate>
$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # opens new, fresh, editor :(

Now it will do:

$ git cl upload ...
CRASH!! You need to authenticate!!
$ <authenticate>
$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # requires thinking

R=ayatane, sokcevic@google.com

Change-Id: Icada2b69b3f4ddaff810dc82d54d65f3918d1434
Bug: 351071334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5826970
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>

2024-08-30 01:20:40 +00:00

..

gerrit_util_test.inputs

[gerrit_util] Add some additional tests and fixes for SSOAuthenticator.

2024-06-21 21:54:38 +00:00

gstools

Upload script for first class gcs deps

2024-03-26 16:54:20 +00:00

.vpython3

run tests using python 3.8

2024-06-12 22:00:15 +00:00

auth_test.py

[auth] Be able to generate id_token

2023-09-28 22:02:04 +00:00

autoninja_test.py

autoninja: Replace ninjalog_uploader_wrapper.py and reclient_metrics.py with build_telemetry.py

2024-07-22 01:32:29 +00:00

bazel_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

bot_update_coverage_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

build_telemetry_test.py

ninjalog_uploader: Add user email to ninjalog metadata

2024-08-29 11:17:57 +00:00

cipd_bootstrap_test.py

Update cipd_bootstrap_test to use a newer cipd client binary.

2024-01-12 02:06:06 +00:00

detect_host_arch_test.py

[detect_host_arch] Cache HostArch() function

2023-11-30 23:29:09 +00:00

download_from_google_storage_unittest.py

Upload script for first class gcs deps

2024-03-26 16:54:20 +00:00

fetch_test.py

fetch: stop setting submodules config as we are not using it at all

2023-11-01 20:07:13 +00:00

gclient_cipd_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_eval_unittest.py

run tests using python 3.8

2024-06-12 22:00:15 +00:00

gclient_gcs_smoketest.py

Make the downloaded tarfile a dotfile

2024-04-16 16:34:49 +00:00

gclient_git_mutates_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_git_smoketest.py

Remove .git suffix from git submodules

2023-11-07 19:51:39 +00:00

gclient_no_sync_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_paths_test.py

Cache values in gclient_paths.py

2023-10-03 20:36:59 +00:00

gclient_scm_test.py

[scm] Refactor git config state to be fully mock-able.

2024-07-18 23:11:41 +00:00

gclient_smoketest_base.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

gclient_smoketest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

gclient_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

gclient_transitions_smoketest.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

gclient_utils_test.py

[gclient] Use lowercase and when merging conditions

2024-05-22 18:16:00 +00:00

gerrit_client_test.py

[gerrit_client] Fix test to not hit real gerrit service.

2024-03-25 23:23:39 +00:00

gerrit_util_test.py

Reduce RebaseChange max tries from 6 to 2

2024-08-09 16:11:44 +00:00

git_auth_test.py

[git_auth] Add apply_global tests

2024-08-12 19:39:00 +00:00

git_cache_test.py

[git_cache] support ssh url

2024-03-26 14:24:43 +00:00

git_cl_creds_check_report.txt

Fix gerrit new-password URL

2023-02-03 17:52:03 +00:00

git_cl_test.py

[git-cl] Make quick Gerrit RPC at the top of CMDupload.

2024-08-30 01:20:40 +00:00

git_common_test.py

[depot_tools] retry git config if it lock-fails

2024-07-19 01:45:13 +00:00

git_dates_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

git_find_releases_test.py

Skip tests not supported in non-git env if in non-git env

2024-07-29 17:45:57 +00:00

git_footers_test.py

Skip tests not supported in non-git env if in non-git env

2024-07-29 17:45:57 +00:00

git_hyper_blame_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

git_map_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

git_number_test.py

Revert "[git-number] Remove unused git-number script."

2024-08-09 01:40:20 +00:00

git_rebase_update_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

git_squash_branch_tree_test.py

Add git squash-branch-tree

2024-07-02 15:03:58 +00:00

gn_helper_test.py

gn_helper: ignore spaces on gn lines

2024-07-03 00:58:07 +00:00

gsutil_test.py

[gsutil.py] Skip luci-auth wrapper on unsupported platforms

2023-11-01 22:19:25 +00:00

hooks_test.py

Require prompt from users to confirm submodules commit.

2023-09-20 22:01:47 +00:00

lockfile_test.py

[gsutil] Fix race when downloading gsutil

2024-05-01 16:41:16 +00:00

metrics_test.py

[metrics] Add new auth metric

2024-08-19 19:53:47 +00:00

my_activity_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

ninjalog_uploader_test.py

autoninja: Replace ninjalog_uploader_wrapper.py and reclient_metrics.py with build_telemetry.py

2024-07-22 01:32:29 +00:00

OWNERS

autoninja: Implement build_telemetry utils

2024-07-09 00:55:18 +00:00

owners_client_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

owners_finder_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

presubmit_canned_checks_test.py

Reland "[presubmit checks] Check if files are written to a dep dir"

2024-06-20 18:11:10 +00:00

presubmit_diff_test.py

Handle binaries in presubmit_diff

2024-08-08 02:48:22 +00:00

presubmit_support_test.py

Handle empty diff in _diffs_to_change_files

2024-06-21 19:14:16 +00:00

presubmit_unittest.py

Update presubmit feedback message for Cog

2024-08-15 16:37:54 +00:00

rdb_wrapper_test.py

Remove __future__ imports

2023-09-25 17:13:00 +00:00

recipes_test.py

Support recipes_test.py in non-git workspace

2024-02-22 18:48:33 +00:00

reclient_helper_test.py

autoninja: Use AUTONINJA_BUILD_ID for RBE_invocation_id as is.

2024-07-25 14:21:27 +00:00

roll_dep_test.py

Hide git log by default if rolling from a non-public host

2024-04-10 19:52:15 +00:00

roll_downstream_gcs_deps_test.py

Add a script to copy GCS packages from one DEPS file to another

2024-08-08 22:52:22 +00:00

scm_mock.py

[scm_mock] Expose mocking of system config layer.

2024-08-09 20:23:54 +00:00

scm_unittest.py

[scm_mock] Remove unused config parameter.

2024-08-09 00:52:09 +00:00

split_cl_test.py

split_cl: do not prepend '/' in $directory

2024-05-15 16:53:48 +00:00

subcommand_test.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00

subprocess2_test.py

Fix multiline comment formatting

2024-01-02 20:19:55 +00:00

upload_to_google_storage_first_class_unittest.py

Add generation version number to GCS first-class entries.

2024-04-04 23:23:00 +00:00

upload_to_google_storage_unittest.py

Remove last py2 workarounds

2023-09-07 18:13:01 +00:00

utils_test.py

Use $HOME/.config/depot_tools on linux for .cfg files

2024-06-12 04:02:48 +00:00

watchlists_unittest.py

tests: switch to 4 space indent

2023-09-05 20:24:16 +00:00