mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
87fa610fe0
This is required because colons trigger an reproxy bug with named pipes currently and backslashes are technically invalid for named pipes https://learn.microsoft.com/en-us/windows/win32/ipc/pipe-names I considered replacing invalid characters with underscores but that may just push the problem down the road as it may create overlap between a directory with underscores and a directory with an invalid charachter that we replace. Since windows doesn't treat pipes as files, like linux treats sockets this naming is arbitrary, it only needs to be consistent and unique for a given output directory. So md5 is a good solution. Bug: b/271310759 Change-Id: I45409d7e9dc4cc1d0f056a3de8241ac877e682e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4300857 Commit-Queue: Ben Segall <bentekkie@google.com> Auto-Submit: Ben Segall <bentekkie@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
155 lines
5.7 KiB
Python
Executable File
155 lines
5.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2023 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import hashlib
|
|
import os
|
|
import os.path
|
|
import sys
|
|
import unittest
|
|
import unittest.mock
|
|
|
|
ROOT_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
|
sys.path.insert(0, ROOT_DIR)
|
|
|
|
import ninja_reclient
|
|
from testing_support import trial_dir
|
|
|
|
|
|
def write(filename, content):
|
|
"""Writes the content of a file and create the directories as needed."""
|
|
filename = os.path.abspath(filename)
|
|
dirname = os.path.dirname(filename)
|
|
if not os.path.isdir(dirname):
|
|
os.makedirs(dirname)
|
|
with open(filename, 'w') as f:
|
|
f.write(content)
|
|
|
|
|
|
class NinjaReclientTest(trial_dir.TestCase):
|
|
def setUp(self):
|
|
super(NinjaReclientTest, self).setUp()
|
|
self.previous_dir = os.getcwd()
|
|
os.chdir(self.root_dir)
|
|
|
|
def tearDown(self):
|
|
os.chdir(self.previous_dir)
|
|
super(NinjaReclientTest, self).tearDown()
|
|
|
|
@unittest.mock.patch.dict(os.environ, {})
|
|
@unittest.mock.patch('subprocess.call', return_value=0)
|
|
@unittest.mock.patch('ninja.main', return_value=0)
|
|
def test_ninja_reclient(self, mock_ninja, mock_call):
|
|
reclient_bin_dir = os.path.join('src', 'buildtools', 'reclient')
|
|
reclient_cfg = os.path.join('src', 'buildtools', 'reclient_cfgs',
|
|
'reproxy.cfg')
|
|
write('.gclient', '')
|
|
write('.gclient_entries', 'entries = {"buildtools": "..."}')
|
|
write(os.path.join(reclient_bin_dir, 'version.txt'), '0.0')
|
|
write(reclient_cfg, '0.0')
|
|
argv = ["ninja_reclient.py", "-C", "out/a", "chrome"]
|
|
|
|
self.assertEqual(0, ninja_reclient.main(argv))
|
|
|
|
self.assertTrue(
|
|
os.path.isdir(os.path.join(self.root_dir, "out", "a", ".reproxy_tmp")))
|
|
self.assertTrue(
|
|
os.path.isdir(
|
|
os.path.join(self.root_dir, "out", "a", ".reproxy_tmp", "cache")))
|
|
self.assertTrue(
|
|
os.path.isdir(
|
|
os.path.join(self.root_dir, "out", "a", ".reproxy_tmp", "logs")))
|
|
self.assertEqual(
|
|
os.environ.get('RBE_output_dir'),
|
|
os.path.join(self.root_dir, "out", "a", ".reproxy_tmp", "logs"))
|
|
self.assertEqual(
|
|
os.environ.get('RBE_proxy_log_dir'),
|
|
os.path.join(self.root_dir, "out", "a", ".reproxy_tmp", "logs"))
|
|
self.assertEqual(
|
|
os.environ.get('RBE_cache_dir'),
|
|
os.path.join(self.root_dir, "out", "a", ".reproxy_tmp", "cache"))
|
|
if sys.platform.startswith('win'):
|
|
self.assertEqual(
|
|
os.environ.get('RBE_server_address'),
|
|
"pipe://%s/reproxy.pipe" % hashlib.md5(
|
|
os.path.join(self.root_dir, "out", "a",
|
|
".reproxy_tmp").encode()).hexdigest())
|
|
else:
|
|
self.assertEqual(
|
|
os.environ.get('RBE_server_address'), "unix://%s/reproxy.sock" %
|
|
os.path.join(self.root_dir, "out", "a", ".reproxy_tmp"))
|
|
|
|
mock_ninja.assert_called_once_with(argv)
|
|
mock_call.assert_has_calls([
|
|
unittest.mock.call([
|
|
os.path.join(self.root_dir, reclient_bin_dir,
|
|
'bootstrap'), "--re_proxy=" +
|
|
os.path.join(self.root_dir, reclient_bin_dir, 'reproxy'),
|
|
"--cfg=" + os.path.join(self.root_dir, reclient_cfg)
|
|
]),
|
|
unittest.mock.call([
|
|
os.path.join(self.root_dir, reclient_bin_dir, 'bootstrap'),
|
|
"--shutdown", "--cfg=" + os.path.join(self.root_dir, reclient_cfg)
|
|
]),
|
|
])
|
|
|
|
@unittest.mock.patch('subprocess.call', return_value=0)
|
|
@unittest.mock.patch('ninja.main', side_effect=KeyboardInterrupt())
|
|
def test_ninja_reclient_ninja_interrupted(self, mock_ninja, mock_call):
|
|
reclient_bin_dir = os.path.join('src', 'buildtools', 'reclient')
|
|
reclient_cfg = os.path.join('src', 'buildtools', 'reclient_cfgs',
|
|
'reproxy.cfg')
|
|
write('.gclient', '')
|
|
write('.gclient_entries', 'entries = {"buildtools": "..."}')
|
|
write(os.path.join(reclient_bin_dir, 'version.txt'), '0.0')
|
|
write(reclient_cfg, '0.0')
|
|
argv = ["ninja_reclient.py", "-C", "out/a", "chrome"]
|
|
|
|
self.assertEqual(1, ninja_reclient.main(argv))
|
|
|
|
mock_ninja.assert_called_once_with(argv)
|
|
mock_call.assert_has_calls([
|
|
unittest.mock.call([
|
|
os.path.join(self.root_dir, reclient_bin_dir,
|
|
'bootstrap'), "--re_proxy=" +
|
|
os.path.join(self.root_dir, reclient_bin_dir, 'reproxy'),
|
|
"--cfg=" + os.path.join(self.root_dir, reclient_cfg)
|
|
]),
|
|
unittest.mock.call([
|
|
os.path.join(self.root_dir, reclient_bin_dir, 'bootstrap'),
|
|
"--shutdown", "--cfg=" + os.path.join(self.root_dir, reclient_cfg)
|
|
]),
|
|
])
|
|
|
|
@unittest.mock.patch('subprocess.call', return_value=0)
|
|
@unittest.mock.patch('ninja.main', return_value=0)
|
|
def test_ninja_reclient_cfg_not_found(self, mock_ninja, mock_call):
|
|
write('.gclient', '')
|
|
write('.gclient_entries', 'entries = {"buildtools": "..."}')
|
|
write(os.path.join('src', 'buildtools', 'reclient', 'version.txt'), '0.0')
|
|
argv = ["ninja_reclient.py", "-C", "out/a", "chrome"]
|
|
|
|
self.assertEqual(1, ninja_reclient.main(argv))
|
|
|
|
mock_ninja.assert_not_called()
|
|
mock_call.assert_not_called()
|
|
|
|
@unittest.mock.patch('subprocess.call', return_value=0)
|
|
@unittest.mock.patch('ninja.main', return_value=0)
|
|
def test_ninja_reclient_bins_not_found(self, mock_ninja, mock_call):
|
|
write('.gclient', '')
|
|
write('.gclient_entries', 'entries = {"buildtools": "..."}')
|
|
write(os.path.join('src', 'buildtools', 'reclient_cfgs', 'reproxy.cfg'),
|
|
'0.0')
|
|
argv = ["ninja_reclient.py", "-C", "out/a", "chrome"]
|
|
|
|
self.assertEqual(1, ninja_reclient.main(argv))
|
|
|
|
mock_ninja.assert_not_called()
|
|
mock_call.assert_not_called()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|