mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
8e57b4bc55
Ran: vi $(git grep --name-only iteritems | grep -v third_party) vi $(git grep --name-only itervalues | grep -v third_party) vi $(git grep --name-only 'print ' | grep -v third_party) and edited the files quickly with adhoc macros. Then ran in recipes/: ./recipes.py test train There was only a small subset of files that had been updated to use six.iteritems() and six.itervalues(). Since the dataset size that is being used in gclient is small (pretty much always below 200 items), it's better to just switch to .items() right away and take the temporary performance hit, so that we don't need to come back to rewrite the code. Recipe-Nontrivial-Roll: build Bug: 984182 Change-Id: I5faf11486b66b0d73c9098ab0f2ce1b15a45c53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1854900 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
37 lines
1.1 KiB
Bash
Executable File
37 lines
1.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Copyright (c) 2017 Google Inc. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
# Set unique build ID.
|
|
AUTONINJA_BUILD_ID="$(python -c "import uuid; print(uuid.uuid4())")"
|
|
export AUTONINJA_BUILD_ID
|
|
|
|
if [ "$NINJA_SUMMARIZE_BUILD" == "1" ]; then
|
|
export NINJA_STATUS="[%r processes, %f/%t @ %o/s : %es ] "
|
|
fi
|
|
|
|
# Execute whatever is printed by autoninja.py.
|
|
# Also print it to reassure that the right settings are being used.
|
|
command=$(vpython "$(dirname -- "$0")/autoninja.py" "$@")
|
|
if [ "$NINJA_SUMMARIZE_BUILD" == "1" ]; then
|
|
echo "$command"
|
|
fi
|
|
if eval "$command"; then
|
|
if [ "$NINJA_SUMMARIZE_BUILD" == "1" ]; then
|
|
python "$(dirname -- "$0")/post_build_ninja_summary.py" "$@"
|
|
fi
|
|
|
|
# Collect ninjalog from googler.
|
|
"$(dirname -- "$0")/ninjalog_uploader_wrapper.py" --cmd $command
|
|
exit
|
|
fi
|
|
|
|
# Collect ninjalog from googler.
|
|
"$(dirname -- "$0")/ninjalog_uploader_wrapper.py" --cmd $command
|
|
|
|
# Return an error code of 1 so that if a developer types:
|
|
# "autoninja chrome && chrome" then chrome won't run if the build fails.
|
|
exit 1
|