mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
0b943400a4
Instead of printing a command-line, we just directly call into the respective main functions from Python. This saves spawning another interpreter and prevents things that can go wrong from having to quote, unquote, split and tunnel arguments through shells.
Part of my bigger auto{ninja,siso} refactoring.
Tested:
- Handling of the ^^ suffix on Windows still works correctly.
- Handling of error codes - i.e.; making sure
"autoninja base_unittests && base_unittests.exe" behaves properly
in the success/failure case.
- Make sure the command prompt title is reliably reset on exit.
I tested autoninja with all combinations of these:
- Host platform: Linux, macOS, Windows
- Remote GN args: <none>, use_goma=true, use_remoteexec=true
- Siso GN args: <none>, use_siso=true
- Targets: base, ../../base/types/expected_macros_unittest.cc^ (on Linux) and ../../base/types/expected_macros_unittest.cc^^ (on Windows)
R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org
Bug: b/293657720
Change-Id: I275a775fdc5abb6555f79d4beab76cd0914d4bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924185
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
48 lines
1.9 KiB
Batchfile
Executable File
48 lines
1.9 KiB
Batchfile
Executable File
@echo off
|
|
:: Copyright 2017 The Chromium Authors. All rights reserved.
|
|
:: Use of this source code is governed by a BSD-style license that can be
|
|
:: found in the LICENSE file.
|
|
|
|
setlocal
|
|
|
|
set scriptdir=%~dp0
|
|
|
|
if "%*" == "/?" (
|
|
rem Handle "autoninja /?" which will otherwise give help on the "call" command
|
|
@call python3.bat %~dp0\ninja.py --help
|
|
exit /b
|
|
)
|
|
|
|
if not defined AUTONINJA_BUILD_ID (
|
|
:: Set unique build ID.
|
|
FOR /f "usebackq tokens=*" %%a in (`%scriptdir%python-bin\python3.bat -c "import uuid; print(uuid.uuid4())"`) do set AUTONINJA_BUILD_ID=%%a
|
|
)
|
|
|
|
:: If a build performance summary has been requested then also set NINJA_STATUS
|
|
:: to trigger more verbose status updates. In particular this makes it possible
|
|
:: to see how quickly process creation is happening - often a critical clue on
|
|
:: Windows. The trailing space is intentional.
|
|
if "%NINJA_SUMMARIZE_BUILD%" == "1" set "NINJA_STATUS=[%%r processes, %%f/%%t @ %%o/s : %%es ] "
|
|
|
|
:: Execute autoninja.py and pass all arguments to it.
|
|
:: Don't use vpython - it is too slow to start.
|
|
:: Don't use python3 because it doesn't work in git bash on Windows and we
|
|
:: should be consistent between autoninja.bat and the autoninja script used by
|
|
:: git bash.
|
|
|
|
@call %scriptdir%python-bin\python3.bat %scriptdir%autoninja.py "%%*"
|
|
@if errorlevel 1 goto buildfailure
|
|
|
|
:: Use call to invoke python script here, because we use python via python3.bat.
|
|
@if "%NINJA_SUMMARIZE_BUILD%" == "1" call %scriptdir%python-bin\python3.bat %scriptdir%post_build_ninja_summary.py %*
|
|
@call %scriptdir%python-bin\python3.bat %scriptdir%ninjalog_uploader_wrapper.py --cmdline %*
|
|
|
|
exit /b %ERRORLEVEL%
|
|
:buildfailure
|
|
|
|
@call %scriptdir%python-bin\python3.bat %scriptdir%ninjalog_uploader_wrapper.py --cmdline %*
|
|
|
|
:: Return an error code of 1 so that if a developer types:
|
|
:: "autoninja chrome && chrome" then chrome won't run if the build fails.
|
|
cmd /c exit 1
|