mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
1ca706a2fa
Change has been successfully rebased and submitted ascf876cddd6Patch-set: 9 Patch-set-description: Rebase Subject: siso: enable autoninja to use env variables instead of flags for collector. Status: merged Commit:cf876cddd6Tag: autogenerated:gerrit:merged Groups:26359373f4Label: Code-Review=+1, 11e6abf855fd55041b78494ebb65e8163dbff19c Gerrit User 1366072 <1366072@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Label: Commit-Queue=+2, 2f45a3762a7e2c98356b1521d6cf418e611578b0 Gerrit User 1552902 <1552902@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Label: SUBM=+1, 02ba68826fc6949d93d82e37b6e3c71c99466a40 Submission-id: 7373289 Submitted-with: OK Submitted-with: Rule-Name: gerrit~DefaultSubmitRule Submitted-with: MAY: Auto-Submit Submitted-with: MAY: Code-Coverage Submitted-with: MAY: Code-Review: Gerrit User 1366072 <1366072@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Submitted-with: MAY: Commit-Queue: Gerrit User 1552902 <1552902@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Submitted-with: MAY: Feels Submitted-with: MAY: Owners-Override Submitted-with: MAY: Lint Submitted-with: MAY: Bot-Commit Submitted-with: OK Submitted-with: Rule-Name: Code-Owners Base:72926f8e78Ours:26359373f4Theirs:72926f8e78Merge-Strategy: recursive Contains-Conflicts: false
220 lines
9.4 KiB
Plaintext
220 lines
9.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bbd831d6_02e1eb87",
|
|
"filename": "siso.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 124,
|
|
"author": {
|
|
"id": 1366072
|
|
},
|
|
"writtenOn": "2026-01-08T05:57:05Z",
|
|
"side": 1,
|
|
"message": "Chatted offline: this function can return collector address if collector started.\nThis way it doesn\u0027t need to take \"env\" and modify it and clean it up later.\n\nOr \n\nYou can drop env[\u0027SISO_COLLECTOR_ADDRESS\u0027] in this function before returning False.",
|
|
"range": {
|
|
"startLine": 124,
|
|
"startChar": 21,
|
|
"endLine": 124,
|
|
"endChar": 50
|
|
},
|
|
"revId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "879e8b24_39753fae",
|
|
"filename": "siso.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 124,
|
|
"author": {
|
|
"id": 1552902
|
|
},
|
|
"writtenOn": "2026-01-08T05:58:06Z",
|
|
"side": 1,
|
|
"message": "We actually still need env as we need creds to start the collector. So I guess we must go with path 2.",
|
|
"parentUuid": "bbd831d6_02e1eb87",
|
|
"range": {
|
|
"startLine": 124,
|
|
"startChar": 21,
|
|
"endLine": 124,
|
|
"endChar": 50
|
|
},
|
|
"revId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
],
|
|
"submitRequirementResults": [
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Admin-Approval",
|
|
"description": {
|
|
"value": "Changes to refs/meta/config must be approved by a git admin."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "branch:refs/meta/config"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"patchSetCommitId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Code-Review",
|
|
"description": {
|
|
"value": "Submit requirement for the \u0027Code-Review\u0027 label"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Code-Review\u003dMAX,user\u003dnon_uploader -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Code-Review=MAX,user=non_uploader -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MAX,user=non_uploader":"","label:Code-Review=MIN":""}}}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
|
|
},
|
|
"patchSetCommitId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "No-Unresolved-Comments",
|
|
"description": {
|
|
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "has:unresolved"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "-has:unresolved"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"patchSetCommitId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Review-Enforcement",
|
|
"description": {
|
|
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (http://go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "is:review-enforced_gerrit"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "is:review-enforcement-satisfied_gerrit"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Verified",
|
|
"description": {
|
|
"value": "Submit requirement for the \u0027Verified\u0027 label"
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "is:false"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "is:true"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "26359373f45c6034d78c1bab234012daa25c663c",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
}
|
|
]
|
|
} |