mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 10:41:31 +00:00
8552a27900
Currently, {autoninja, autoninja.bat} scripts generate AUTONINJA_BUILD_ID by calling `python3 -c "import uuid; print(uuid.uuid4())"`.
This CL moves the logic at the beginning `autoninja.py`.
This also reduces the overhead of starting Python interpreter, which
takes around 60ms on my Windows workstaion.
```
> hyperfine python3
Benchmark 1: python3
Time (mean ± σ): 63.4 ms ± 7.8 ms [User: 25.7 ms, System: 33.7 ms]
Range (min … max): 51.0 ms … 80.2 ms 41 runs
```
Change-Id: I93d5b65f3c5542c3a93a3de1f27a5aa5d06c09a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5737673
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
35 lines
1.2 KiB
Batchfile
Executable File
35 lines
1.2 KiB
Batchfile
Executable File
@echo off
|
|
:: Copyright 2017 The Chromium Authors. All rights reserved.
|
|
:: Use of this source code is governed by a BSD-style license that can be
|
|
:: found in the LICENSE file.
|
|
|
|
setlocal
|
|
|
|
set scriptdir=%~dp0
|
|
|
|
if "%*" == "/?" (
|
|
rem Handle "autoninja /?" which will otherwise give help on the "call" command
|
|
@call python3.bat %~dp0\ninja.py --help
|
|
exit /b
|
|
)
|
|
|
|
:: If a build performance summary has been requested then also set NINJA_STATUS
|
|
:: to trigger more verbose status updates. In particular this makes it possible
|
|
:: to see how quickly process creation is happening - often a critical clue on
|
|
:: Windows. The trailing space is intentional.
|
|
if "%NINJA_SUMMARIZE_BUILD%" == "1" set "NINJA_STATUS=[%%r processes, %%f/%%t @ %%o/s : %%es ] "
|
|
|
|
:: Execute autoninja.py and pass all arguments to it.
|
|
@call %scriptdir%\vpython3.bat %scriptdir%autoninja.py "%%*"
|
|
@if errorlevel 1 goto buildfailure
|
|
|
|
:: Use call to invoke python script here, because we use python via python3.bat.
|
|
@if "%NINJA_SUMMARIZE_BUILD%" == "1" call %scriptdir%python-bin\python3.bat %scriptdir%post_build_ninja_summary.py %*
|
|
|
|
exit /b %ERRORLEVEL%
|
|
:buildfailure
|
|
|
|
:: Return an error code of 1 so that if a developer types:
|
|
:: "autoninja chrome && chrome" then chrome won't run if the build fails.
|
|
cmd /c exit 1
|