mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 10:41:31 +00:00
8b8d8bef35
Depends on extension mechanism for cpplint.py: http://codereview.appspot.com/4950069/ Pulls r74 of cpplint.py from: http://google-styleguide.googlecode.com/svn-history/r74/trunk/cpplint/cpplint.py Taken from WebKit's fork of cpplint.py. WebKit patch was: http://trac.webkit.org/changeset/46856 Credit Torch Mobile, Inc. who have contributed the WebKit patch in question. BUG=none TEST=Run gcl lint on a CL that has a Foo *bar style declaration. Review URL: http://codereview.chromium.org/7834045 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100151 0039d316-1c4b-4281-b951-d872f2087c98
51 lines
2.3 KiB
Python
Executable File
51 lines
2.3 KiB
Python
Executable File
# Copyright (c) 2011 Google Inc. All rights reserved.
|
|
# Copyright (c) 2009 Torch Mobile Inc.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above
|
|
# copyright notice, this list of conditions and the following disclaimer
|
|
# in the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
# contributors may be used to endorse or promote products derived from
|
|
# this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import re
|
|
|
|
# Matches Foo *foo declarations.
|
|
_RE_PATTERN_POINTER_DECLARATION_WHITESPACE = re.compile(
|
|
r'\s*\w+(?<!\breturn|\bdelete)\s+(?P<pointer_operator>\*|\&)\w+')
|
|
|
|
def CheckPointerDeclarationWhitespace(filename, clean_lines, linenum, error):
|
|
"""Checks for Foo *foo declarations.
|
|
|
|
Args:
|
|
filename: The name of the current file.
|
|
clean_lines: A CleansedLines instance containing the file.
|
|
linenum: The number of the line to check.
|
|
error: The function to call with any errors found.
|
|
"""
|
|
line = clean_lines.elided[linenum]
|
|
matched = _RE_PATTERN_POINTER_DECLARATION_WHITESPACE.match(line)
|
|
if matched:
|
|
error(filename, linenum, 'whitespace/declaration', 3,
|
|
'Declaration has space between type name and %s in %s' %
|
|
(matched.group('pointer_operator'), matched.group(0).strip()))
|