mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 10:41:31 +00:00
This is a reland of d3affaa624
Original change's description:
> Use OS level locking in git_cache.py
>
> Without OS level locking it's possible to leave "lock" files on disk
> which will prevent next run to acquire those locks. This can easily
> happen if SIGKIL is issued.
>
> R=apolito@google.com, ehmaldonado@chromium.org
>
> Bug: 1049610
> Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Bug: 1049610
Change-Id: I58e65a10f7c779e0de1121ba7167c694996e390c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211189
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
117 lines
2.9 KiB
Python
117 lines
2.9 KiB
Python
# Copyright 2020 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""Exclusive filelocking for all supported platforms."""
|
|
|
|
from __future__ import print_function
|
|
|
|
import contextlib
|
|
import logging
|
|
import os
|
|
import sys
|
|
import time
|
|
|
|
|
|
class LockError(Exception):
|
|
pass
|
|
|
|
|
|
if sys.platform.startswith('win'):
|
|
# Windows implementation
|
|
import win32imports
|
|
|
|
BYTES_TO_LOCK = 1
|
|
|
|
def _open_file(lockfile):
|
|
return win32imports.Handle(
|
|
win32imports.CreateFileW(
|
|
lockfile, # lpFileName
|
|
win32imports.GENERIC_WRITE, # dwDesiredAccess
|
|
0, # dwShareMode=prevent others from opening file
|
|
None, # lpSecurityAttributes
|
|
win32imports.CREATE_ALWAYS, # dwCreationDisposition
|
|
win32imports.FILE_ATTRIBUTE_NORMAL, # dwFlagsAndAttributes
|
|
None # hTemplateFile
|
|
))
|
|
|
|
def _close_file(handle):
|
|
# CloseHandle releases lock too.
|
|
win32imports.CloseHandle(handle)
|
|
|
|
def _lock_file(handle):
|
|
ret = win32imports.LockFileEx(
|
|
handle, # hFile
|
|
win32imports.LOCKFILE_FAIL_IMMEDIATELY
|
|
| win32imports.LOCKFILE_EXCLUSIVE_LOCK, # dwFlags
|
|
0, #dwReserved
|
|
BYTES_TO_LOCK, # nNumberOfBytesToLockLow
|
|
0, # nNumberOfBytesToLockHigh
|
|
win32imports.Overlapped() # lpOverlapped
|
|
)
|
|
# LockFileEx returns result as bool, which is converted into an integer
|
|
# (1 == successful; 0 == not successful)
|
|
if ret == 0:
|
|
error_code = win32imports.GetLastError()
|
|
raise OSError('Failed to lock handle (error code: %d).' % error_code)
|
|
else:
|
|
# Unix implementation
|
|
import fcntl
|
|
|
|
def _open_file(lockfile):
|
|
open_flags = (os.O_CREAT | os.O_WRONLY)
|
|
return os.open(lockfile, open_flags, 0o644)
|
|
|
|
def _close_file(fd):
|
|
os.close(fd)
|
|
|
|
def _lock_file(fd):
|
|
fcntl.flock(fd, fcntl.LOCK_EX | fcntl.LOCK_NB)
|
|
|
|
|
|
def _try_lock(lockfile):
|
|
f = _open_file(lockfile)
|
|
try:
|
|
_lock_file(f)
|
|
except Exception:
|
|
_close_file(f)
|
|
raise
|
|
return lambda: _close_file(f)
|
|
|
|
|
|
def _lock(path, timeout=0):
|
|
"""_lock returns function to release the lock if locking was successful.
|
|
|
|
_lock also implements simple retry logic."""
|
|
elapsed = 0
|
|
while True:
|
|
try:
|
|
return _try_lock(path + '.locked')
|
|
except (OSError, IOError) as e:
|
|
if elapsed < timeout:
|
|
sleep_time = min(10, timeout - elapsed)
|
|
logging.info(
|
|
'Could not create git cache lockfile; '
|
|
'will retry after sleep(%d).', sleep_time)
|
|
elapsed += sleep_time
|
|
time.sleep(sleep_time)
|
|
continue
|
|
raise LockError("Error locking %s (err: %s)" % (path, str(e)))
|
|
|
|
|
|
@contextlib.contextmanager
|
|
def lock(path, timeout=0):
|
|
"""Get exclusive lock to path.
|
|
|
|
Usage:
|
|
import lockfile
|
|
with lockfile.lock(path, timeout):
|
|
# Do something
|
|
pass
|
|
|
|
"""
|
|
release_fn = _lock(path, timeout)
|
|
try:
|
|
yield
|
|
finally:
|
|
release_fn()
|