InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compare commits

base: InTheForest:a4b2ad51e013e64254098c21a23793ffd2a1e87a
Branches Tags
InTheForest:main InTheForest:chrome/4147 InTheForest:chrome/3987 InTheForest:chrome/3865 InTheForest:chrome/3904 InTheForest:infra/config
...
compare: InTheForest:b08a1e0430d1c1989812121d15fa4ee0165d5cc3
Branches Tags
InTheForest:main InTheForest:chrome/4147 InTheForest:chrome/3987 InTheForest:chrome/3865 InTheForest:chrome/3904 InTheForest:infra/config

4 Commits
a4b2ad51e0 ... b08a1e0430

Author SHA1 Message Date
Gerrit User 1450817
b08a1e0430 Update patch set 6 
Patch Set 6:

(4 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 1450817 \u003c1450817@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1450817\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000768 \u003c1000768@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1450817\u003e replied on the change"}
 2026-01-06 17:37:44 -08:00
Gerrit User 1000768
16f8114c83 Update patch set 6 
Patch Set 6:

(6 comments)

Patch-set: 6
CC: Gerrit User 1000768 <1000768@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Attention: {"person_ident":"Gerrit User 1450817 \u003c1450817@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000768\u003e replied on the change"}
 2026-01-06 17:24:25 -08:00
Gerrit User 1450817
0510959310 Update patch set 6 
Patch Set 6:

(2 comments)

Patch-set: 6
 2026-01-06 14:56:27 -08:00
Gerrit User 1450817
699614680e Create patch set 6 
Uploaded patch set 6.

Patch-set: 6
Subject: Implement a universal formatter for depot_tools.
Commit: 622ee23b86
Tag: autogenerated:gerrit:newPatchSet
Groups: bcd80a19ee
Attention: {"person_ident":"Gerrit User 1450817 \u003c1450817@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"removed on reply"}
Attention: {"person_ident":"Gerrit User 1367998 \u003c1367998@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
 2026-01-06 14:56:27 -08:00
2 changed files with 238 additions and 0 deletions
Expand all files Collapse all files

48
2d28a4ba1775bceb41e63cc5735263c0e26f3ea5
View File

@@ -23,6 +23,30 @@
"revId": "2d28a4ba1775bceb41e63cc5735263c0e26f3ea5",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "4f603fd2_ee460ec4",
"filename": "format.py",
"patchSetId": 5
},
"lineNbr": 19,
"author": {
"id": 1450817
},
"writtenOn": "2026-01-06T22:56:27Z",
"side": 1,
"message": "Done",
"parentUuid": "8a999b59_aa5c0b2d",
"range": {
"startLine": 19,
"startChar": 2,
"endLine": 19,
"endChar": 37
},
"revId": "2d28a4ba1775bceb41e63cc5735263c0e26f3ea5",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
@@ -45,6 +69,30 @@
},
"revId": "2d28a4ba1775bceb41e63cc5735263c0e26f3ea5",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "35998eb7_0d0b6933",
"filename": "format.py",
"patchSetId": 5
},
"lineNbr": 40,
"author": {
"id": 1450817
},
"writtenOn": "2026-01-06T22:56:27Z",
"side": 1,
"message": "Done",
"parentUuid": "03c97ec7_e9a4de02",
"range": {
"startLine": 40,
"startChar": 51,
"endLine": 40,
"endChar": 54
},
"revId": "2d28a4ba1775bceb41e63cc5735263c0e26f3ea5",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}

190
622ee23b86b073429f903968312c3f92757913ea Normal file
View File

@@ -0,0 +1,190 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "a37879e2_d30d992f",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 15,
"author": {
"id": 1000768
},
"writtenOn": "2026-01-07T01:24:25Z",
"side": 1,
"message": "this is a really weird \u0026 unintuitive interface. it\u0027s not how any standard formatting tool behaves.",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 15,
"endChar": 54
},
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "8c5ef256_40f4d4db",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 15,
"author": {
"id": 1450817
},
"writtenOn": "2026-01-07T01:37:44Z",
"side": 1,
"message": "Would you prefer it if I followed clang-format\u0027s convention and instead of `formatter foo.extension` I used `formatter --assume-filename\u003dfoo.extension`? This would be consistent with most formatters.\n\nI mostly didn\u0027t do it that way because I figured there was only one parameter so there was no point using argparse.",
"parentUuid": "a37879e2_d30d992f",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 15,
"endChar": 54
},
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "fc874cbf_52a817f6",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 41,
"author": {
"id": 1000768
},
"writtenOn": "2026-01-07T01:24:25Z",
"side": 1,
"message": "ironically, this file needs formatting",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "d8d0ffd4_9bea7e6d",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 46,
"author": {
"id": 1000768
},
"writtenOn": "2026-01-07T01:24:25Z",
"side": 1,
"message": "use execvp and you don\u0027t need the shutil.which logic anywhere",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "712042af_b8185bcd",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 46,
"author": {
"id": 1450817
},
"writtenOn": "2026-01-07T01:37:44Z",
"side": 1,
"message": "Does that still apply given what I mentioned about shebangs on windows?",
"parentUuid": "d8d0ffd4_9bea7e6d",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "6309e84d_4c0155b5",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 51,
"author": {
"id": 1000768
},
"writtenOn": "2026-01-07T01:24:25Z",
"side": 1,
"message": "all funcs really should have docstrings, even if they\u0027re just one-liners",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "306b55a5_9a343782",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 86,
"author": {
"id": 1000768
},
"writtenOn": "2026-01-07T01:24:25Z",
"side": 1,
"message": "yapf is already properly shebanged. don\u0027t inject your own vpython on it.",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "ec8b1dd3_76e1467a",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 86,
"author": {
"id": 1450817
},
"writtenOn": "2026-01-07T01:37:44Z",
"side": 1,
"message": "I was under the impression that the shebang wouldn\u0027t work on windows?",
"parentUuid": "306b55a5_9a343782",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "eee89f12_c837e832",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 127,
"author": {
"id": 1000768
},
"writtenOn": "2026-01-07T01:24:25Z",
"side": 1,
"message": "not all star files are lucicfg files",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "cebe7a37_3905f4ce",
"filename": "format.py",
"patchSetId": 6
},
"lineNbr": 127,
"author": {
"id": 1450817
},
"writtenOn": "2026-01-07T01:37:44Z",
"side": 1,
"message": "I can remove this if you want, but this was designed to work the same way as `git cl format`, which makes a similar assumption (when `--lucicfg` is set).\n\nMy assumption was that the equivalent of a `--lucicfg` flag for this would be controlling which files get sent to this formatter.\n\nEg. If you want only files under the lucicfg directory to be formatted as lucicfg files, you could write in your jj config:\n```\npatterns \u003d [\n \"glob:lucicfg/**/*.star\",\n]\n```",
"parentUuid": "eee89f12_c837e832",
"revId": "622ee23b86b073429f903968312c3f92757913ea",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}