Junji Watanabe
9414627328
Revert "siso: enable autoninja to use env variables instead of flags for collector."
...
This reverts commit cf876cddd6http://b/474306065 .
Original change's description:
> siso: enable autoninja to use env variables instead of flags for collector.
>
> For clients with old siso this will not cause any breakage as we kept the flags, and did not introduce any old ones. Eventually everyone should get their collector running.
>
> The collector startup will be triggered only for clients with enabled logs collection.
>
> Bug: b/455433899
> Change-Id: I962bd551c5a1cc6a5f8904e65d24939b6a6a6964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7373289
> Commit-Queue: Alex Ovsienko <ovsienko@google.com >
> Reviewed-by: Junji Watanabe <jwata@google.com >
Bug: b/455433899
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: If5d592499c1bbc5ea24c5b2c8ef72aa83d500972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7407116
Auto-Submit: Junji Watanabe <jwata@google.com >
Commit-Queue: Junji Watanabe <jwata@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2026-01-08 05:52:45 -08:00
Junji Watanabe
6f577a0fc5
Revert "siso: clean up _start_collector function to not modify the env dict."
...
This reverts commit 02da7602fbhttp://b/474306065 .
Original change's description:
> siso: clean up _start_collector function to not modify the env dict.
>
> Also do not have special status for missing socks file. Clean up socks file before starting the collector.
>
> Bug: b/455433899
> Change-Id: Ib393f00e7a6098fca1b7d1d70f5aa4616a6a6964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7408697
> Commit-Queue: Alex Ovsienko <ovsienko@google.com >
> Reviewed-by: Junji Watanabe <jwata@google.com >
Bug: b/455433899
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ie095f91c72bca65102a96fa33e77b87e79cab9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7407117
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Junji Watanabe <jwata@google.com >
2026-01-08 05:52:13 -08:00
Alex Ovsienko
02da7602fb
siso: clean up _start_collector function to not modify the env dict.
...
Also do not have special status for missing socks file. Clean up socks file before starting the collector.
Bug: b/455433899
Change-Id: Ib393f00e7a6098fca1b7d1d70f5aa4616a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7408697
Commit-Queue: Alex Ovsienko <ovsienko@google.com >
Reviewed-by: Junji Watanabe <jwata@google.com >
2026-01-08 00:27:33 -08:00
Alex Ovsienko
cf876cddd6
siso: enable autoninja to use env variables instead of flags for collector.
...
For clients with old siso this will not cause any breakage as we kept the flags, and did not introduce any old ones. Eventually everyone should get their collector running.
The collector startup will be triggered only for clients with enabled logs collection.
Bug: b/455433899
Change-Id: I962bd551c5a1cc6a5f8904e65d24939b6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7373289
Commit-Queue: Alex Ovsienko <ovsienko@google.com >
Reviewed-by: Junji Watanabe <jwata@google.com >
2026-01-07 22:36:25 -08:00
