InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,659 Commits 6 Branches 0 Tags
fad3730e80171ce2723a48f4cc08682c6f19d640
Commit Graph

97 Commits

Author SHA1 Message Date
Robert Liao
fe2c072f16 Remove dpranke@google.com from OWNERS 
dpranke@google.com is no longer active.

Change-Id: I5fda62720bd078951842a517f8cbff5caa96dc75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6803905
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
 2025-07-30 17:04:10 -07:00
Junji Watanabe
e68bbfc572 Prepend caffeinate to build commands on macOS 
When building on macOS, it's better to avoid sleeping with caffeinate by
default. This CL prepends `caffeinate` to the build commands, which can
be opted out with `--no-caffeinate`.

Change-Id: Iacb72acb6523576305b38fe45bfef12f87121a93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6596109
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2025-05-28 18:32:34 -07:00
wnwen@chromium.org
3b73c8d8eb android: Add wnwen to OWNERS 
To help maintain android_build_server_helper.py and revert any failing
changes to it.

R=sokcevic@google.com

Bug: 393136861
Change-Id: Ib4d111ffa03e21a3d733dec64141e7d00da573b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6499329
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2025-04-29 12:40:03 -07:00
Mike Frysinger
427bb0e388 OWNERS: grant copybara access to repo_launcher 
We're using copybara to sync upstream repo here automatically.
Grant it owners access so more devs can help merge its syncs.

Change-Id: I54acf18c73af6e8c8a670d2761ad60b2a778a20a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6419683
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-10 19:43:46 -07:00
Andy Perelson
a983b67726 Update root OWNERS 
Change-Id: Ic4c7a23a82f06c8e4917b66d0848fd2ffa89e83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6410152
Auto-Submit: Andy Perelson <ajp@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
 2025-03-31 07:18:05 -07:00
Brian Ryner
06b202468c Add myself as a depot_tools owner. 
Change-Id: Ie8907f3567ab55c6f08fd79a1ea111984ff1ffcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6173181
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 2025-01-14 12:37:26 -08:00
Mohamed Heikal
9b4d1e485d Integrate autoninja.py with fast_local_dev_server.py 
- Starts the build server when the build starts.
- Writes tty filename to env variable.
- Tells the build server about the current build so it does not exit
  until autoninja does, even if idle.
- Cancels pending tasks on Ctrl+c.

Change-Id: I86bb9852bd0975f381b049b9ff21c38eef7cef9d
Bug: 370589852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5917985
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
 2024-12-12 10:28:46 -08:00
Bruce Dawson
5dce57b05e Remove brucedawson@ from some depot_tools OWNERS files 
I'm leaving Google and I no longer wish to be an OWNER.

Change-Id: Id5b91b72596ce0ab06dcdc80998d76899797fcdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5907923
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 2024-10-04 17:34:17 +00:00
Junji Watanabe
01e29c8b5d autoninja: Implement build_telemetry utils 
This will replace the user consent logics in ninjalog_uploader_wrapper.py and reclient_metrics.py

See also https://crrev.com/c/5669094 for how this will be used.

Bug: 345113094
Change-Id: Iffc4975c152ba63f7577c09e5254c499fe8973c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5671052
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2024-07-09 00:55:18 +00:00
Junji Watanabe
1387a8c958 autoninja: Refactor the code calling Reclient 
- Remove reclient_helper.py to avoid calling it directly.
- Cleans up autoninja.py

I just want to do this cleanup before merging the user notice messages
for logs/metrics collection.

Bug: 345113094
Change-Id: I0c76426b3cb387eae6dede031727c107e57d5d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5668282
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ben Segall <bentekkie@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-07-09 00:52:12 +00:00
Takuto Ikuta
495b23b39a remove goma CIPD package 
goma is not used by developers now.

Bug: b/304421889
Change-Id: I68ffd73336f2303484dd44bce6c3984b06faa681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5395370
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2024-04-15 04:20:13 +00:00
Gavin Mak
371c850342 Remove aravindvasudev@google.com from OWNERS 
Change-Id: I6ac139506ec690f32c3ab97bde9dbf9043ded63f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425449
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2024-04-04 22:03:28 +00:00
Philipp Wollermann
96a5bc2c44 Refactor the depot_tools OWNERS file. 
Allow all teams (Build, CrOS, LUCI, reclient) to self-manage their
members.

Grant (co-)ownership for all build tools (Ninja, Siso, GN, reclient,
Bazel) to BUILD_OWNERS.

Simplify globs to grant teams ownership of their respective files.

Change-Id: Ibf9167db7c4c6d7fe6e3a25d9445a661f8852415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4875978
Auto-Submit: Philipp Wollermann <philwo@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2023-09-20 16:10:12 +00:00
Bruce Dawson
3edcbf07bf Update OWNERS for new reclient_metrics* files 
Change crrev.com/c/4764130 added reclient_metrics.bat and
reclient_metrics but didn't add an entry to OWNERS to match the existing
reclient_metrics.py entries. This adds reclient_metrics* entries, thus
capturing the two new files as well as reclient_metrics.README.md.

Bug: None
Change-Id: I0820f9f87d0c6fb5bb2bd5232e929da81257d669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4794713
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2023-08-21 02:01:27 +00:00
Yiwei Zhang
e015bcd978 add yiwzhang and ddoman to depot_tools OWNERS 
R=sokcevic

Rationale: both of us are member of source team now and we will
need to review CLs from contributors during our oncall rotation
Change-Id: If7a5f3ece668df0ed799653707f7e8378e753f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4766323
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2023-08-09 20:28:08 +00:00
Jack Rosenthal
6a505ad9ab [ChromiumOS] Add a launcher for Bazel 
CrOS intends to provide a Bazel executable for our users in
chromite/bin/bazel in our tree.  We'd like the "bazel" command in
depot_tools to call this executable.

This adds a new launcher to depot_tools which searches for that bazel
executable when located inside of a ChromiumOS checkout, and executes
it.  When located outside of a ChromiumOS checkout, this launcher
"disappears", searching elsewhere in the PATH for another Bazel
executable.

Since other teams using depot_tools may want to start using Bazel in
the future, this launcher is intended to have shared ownership: other
teams are welcome to come add their search functions to the launcher
if they require the same functionality as us.

Bug: b:253268519
Change-Id: I61f6383d8b69b9eea622f37277678f898cc7fd6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4718785
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2023-08-01 16:10:00 +00:00
Ben Segall
530d86d40b Implement reclient metrics uploading 
This cl will be submitted after the cl to add the metadata to the
reproxy.cfg file has been submitted to chromium/src: crrev/c/4513215

Bug: b/281504726
Change-Id: Ifa6d5f56d4a85ccb9ec8e4f70207d8b6b9382e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4516023
Commit-Queue: Ben Segall <bentekkie@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-05-29 16:11:00 +00:00
Junji Watanabe
607284d719 [siso] add autosiso wrappers 
Developers will be able to use `autosiso` command to invoke siso builds.
This CL extracts reclient management logic from `ninja_reclient` to be  reused in both Ninja and Siso builds.

Bug: b/278675516
Change-Id: I3e64a3188db184f4d3f851063a0feef7d3a73d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445366
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2023-04-20 03:14:52 +00:00
Ben Segall
9e36ef60d0 Add convenience wrapper for reclientreport for autoninja users 
This is designed to be called by a developer when they want to submit an reclient bug report.
Developers could just call the //buildtools/reclient/reclientreport binary directly but this wrapper provides an easier way to set the same log flags that are set by ninja_reclient.
I dont think we should bundle this logic into autoninja as this is not required in 99% of builds.

Bug: b/277763387
Change-Id: I0204b6acc22f199b461ef710d0dfd07e05534af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4414921
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Ben Segall <bentekkie@google.com>
 2023-04-18 22:09:28 +00:00
Fumitoshi Ukai
3ca8d0d0ca add siso wrapper 
Bug: b/277855544, b/277859568
Change-Id: I520834647881745db7a42fd357bc829a7c6779d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4413517
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
 2023-04-13 05:24:08 +00:00
Dirk Pranke
a73a249737 Remove dpranke@ as a general-purpose OWNER. 
This removes me (dpranke@google.com) as a general purpose OWNER
and leaves me with just the build-specific files (stuff related to
GN and Ninja, basically).

Now that we have a dedicated team supporting depot_tools my OWNERship
is less necessary. I'm happy to continue reviewing things wherever
that might be helpful.

Change-Id: I0585b1f7c958c871e6e1a68fd37d8cd5a645494d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4412691
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2023-04-11 00:52:18 +00:00
Jack Rosenthal
ae46c3cecd Symlink gerrit CLI into depot_tools 
The "gerrit" tool works just fine outside the SDK.  Let's start
teaching people to use it outside the SDK by putting it in their PATH.

Bug: b:275597798
Change-Id: I79c8090d4e5e205bcac2b763751537791caafe91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4377791
Auto-Submit: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-03-29 00:09:14 +00:00
Takuto Ikuta
b48200edc1 make tikuta as owner of ninjalog related files again 
Ownership was removed accidentally in https://crrev.com/c/4171506.

Change-Id: Ie52bf9c7d8180743d24f84e32fe8ede1e1fe0398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297357
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2023-02-28 22:16:19 +00:00
Ben Segall
eb2866e654 Create reclient specific ninja wrapper to properly handle reproxy lifecyle 
This is required as it is impossible to catch a keyboard interrupt in a
windows batch file and we dont want zombie reproxy instances running on
developer's machines for performance and metric collection reasons.

Bug: b/264405266
Change-Id: I00f036c8f14451cdb1b99a5cad1c2af03dd57d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4171506
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Ben Segall <bentekkie@google.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
 2023-01-20 20:14:44 +00:00
Brian Ryner
252b19866a Redirect cros calls to py2.7 scripts to the vpython2.7 package. 
Bug: 1245665
Change-Id: I1b75e2a515e6c8b1b7b0192946a2cfd5295a21f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4015440
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 2023-01-03 22:56:22 +00:00
Dirk Pranke
ec1882fbc2 Add dpranke@ back as an OWNER. 
Change-Id: I774348ae01769a0ea8e2032d66728e10dbb428fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4074124
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2022-12-02 02:46:52 +00:00
Joanna Wang
5355f06ef6 Add jojwang to OWNERS 
Change-Id: I47961f3208a22cc05b5a38db3ccfd38a0f32520f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3808331
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
 2022-08-03 20:14:12 +00:00
Josip Sokcevic
0e9a7d2643 Revert "Add iannucci to depot_tools owners" 
This reverts commit b6a0b58b9f.

Reason for revert: we should have a good coverage now within just
chops source. You are welcome to stay owner if you'd like tho.

Original change's description:
> Add iannucci to depot_tools owners
>
> Change-Id: Ic85057a6075ba398e4800edffd183f5e2eccd259
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3440929
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

Change-Id: I0a5138d8a119d2d2699e04857c95e6f2875aaac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3657058
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-05-20 22:35:11 +00:00
Jochen Eisinger
f8300fba9d Remove myself from depot_tools OWNERS 
Change-Id: I36707ebe5c436d920605bfb833536542dee911ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3647823
Auto-Submit: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2022-05-13 22:41:27 +00:00
Bruce Dawson
4d8d7ff049 Add brucedawson@ as presubmit*.py OWNER 
I feel like a PRESUBMIT owner now and this makes it official.

Bug: 1309977
Change-Id: I38356bc52c8d03d93c4ec42e4952b5872b31a79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3589901
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 2022-04-19 17:11:26 +00:00
David Dorwin
7d2693ad8d Remove scottmg from OWNERS 
depot_tools version of https://crrev.com/c/3526975.

Change-Id: I9c46525322ebfa36ebde67bb5fe00249cdf51fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3591072
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 2022-04-18 21:53:14 +00:00
Josip Sokcevic
b6a0b58b9f Add iannucci to depot_tools owners 
Change-Id: Ic85057a6075ba398e4800edffd183f5e2eccd259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3440929
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2022-02-08 22:10:01 +00:00
Josip Sokcevic
33d87bca7e Add ajp@ to owners 
R=ajp@google.com

Change-Id: Ib54985d8da767ea06f45f31fdb3a46ac8645a8f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3440925
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Andy Perelson <ajp@chromium.org>
 2022-02-04 23:31:02 +00:00
Dirk Pranke
f537138fb7 Remove dpranke@google.com from OWNERS. 
I'll be out for a while, so I'm removing myself from various
OWNERS files to avoid confusion.

Change-Id: Icfc161229f8376c856a25a4f4849270bd9f39924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3434226
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2022-02-03 01:18:47 +00:00
Josip Sokcevic
d05a2e0395 Add aravindvasudev to owners 
R=aravindvasudev@google.com, gavinmak@google.com

Change-Id: Ic00cc4a6b0ca9aa7d8109f0d8c611044a4a1da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3414741
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-01-25 23:54:05 +00:00
Edward Lesmes
f5ed28d814 Remove ehmaldonado from OWNERS 
Change-Id: Idcb5d9b66cb019d8892ff8cfe92a0a04b01ed9e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3022311
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 2021-08-17 20:56:44 +00:00
Mike Frysinger
7f0091e524 chrome_set_ver: punt old script 
We deleted this in chromite back in 2013.  Looks like we forgot to
clean up depot_tools.

Bug: 216050
Change-Id: I7e7591aaa319ab1aeb7cc3f34e33b313b5029257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812199
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2021-06-15 21:38:08 +00:00
Edward Lesmes
e0de6a88e5 Revert "Remove ehmaldonado@chromium.org from OWNERS" 
This reverts commit 4a9ce1b527.

Reason for revert:
Testing secondary account can still approve

Original change's description:
> Remove ehmaldonado@chromium.org from OWNERS
>
> Change-Id: I661f8d23dd7cd716e4746fd4ef20de9416fd6f1c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2787480
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Change-Id: Ib54084be936f0f66370600f3b520a13079ae763c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2787596
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2021-03-25 22:45:29 +00:00
Gavin Mak
4a9ce1b527 Remove ehmaldonado@chromium.org from OWNERS 
Change-Id: I661f8d23dd7cd716e4746fd4ef20de9416fd6f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2787480
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2021-03-25 22:25:57 +00:00
Edward Lesmes
c1afadf801 Add gavinmak@ to owners 
Change-Id: I309bfc112966a84c55d881fe874abfc7842c4a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2698787
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 2021-02-16 21:15:24 +00:00
Edward Lesmes
364205c70e [depot_tools] Migrate metadata to DIR_METADATA. 
Change-Id: I7e07de8746a269a31744f44296921cc9c6566a73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2597738
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
 2020-12-30 21:31:55 +00:00
Mike Frysinger
eb386eb3d2 Reland "repo: auto-update depot_tools when used" 
This is a reland of 19512276d2.
It includes an update to .gitattributes for recipes.

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

Bug: 1148984
Change-Id: Ia7844016cb04d3197e51ad05da64c885cf3277a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561229
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 2020-11-30 18:17:40 +00:00
Andrii Shyshkalov
dc7b108da6 Revert "repo: auto-update depot_tools when used" 
This reverts commit 19512276d2.

Reason for revert: broke ART bots.
Bug: 1153114

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

TBR=vapier@chromium.org,ehmaldonado@chromium.org,mmortensen@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,mmortensen@chromium.org

Change-Id: Ic0ac9155e3acde87966f518213a5a8440e167295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560955
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
 2020-11-26 17:56:53 +00:00
Mike Frysinger
19512276d2 repo: auto-update depot_tools when used 
Since gclient automatically syncs this checkout when used,
have repo do the same for CrOS users.

Bug: 1148984
Test: ran and saw it auto-update when used externally
Test: ran and saw it not auto-update when used inside of a repo checkout
Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 2020-11-25 22:22:23 +00:00
Edward Lesmes
ec0c770ad8 Make LUCI_OWNERS owners of .cipd_impl.ps1 
Change-Id: I5199bb2497ff66c89cd80d858b18826344a124d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2521844
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 2020-11-05 22:17:14 +00:00
Scott Lee
5664586374 [resultdb] add ddoman@ to depot_tools/LUCI_OWNERS 
ddoman@ frequently moves the cipd pin of infra/tools/rdb package.

R=iannucci@chromium.org
CC=chanli@chromium.org,nodir@chromium.org,robertocn@chromium.org,tandrii@google.com,vadimsh@chromium.org

Change-Id: I26b3eae79a9b917af6197c5c42db5303a99a2c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2358897
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 2020-08-17 21:33:32 +00:00
Dirk Pranke
b932a7fed9 Remove dpranke@chromium.org from OWNERS. 
I've consistently switched over to using dpranke@google.com for all
my work and should no longer have the @chromium.org address listed
in OWNERS.

Change-Id: Ibafa6d0fe0c0673a3216ade62b5997af62b06e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2335909
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2020-08-06 00:25:44 +00:00
Dirk Pranke
1ee86bdf3a Add dpranke@google.com to //OWNERS. 
I've switched to using my @google.com address for most work,
so adding it to //OWNERS here.

I'm not removing my @chromium.org address yet, just to make
switching over a bit easier.

Change-Id: If8d6ac06a5193eac79bbd32ea9a5524dcf24b1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2276571
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2020-06-30 23:29:37 +00:00
Mike Frysinger
d27e40cf55 CROS_OWNERS: add Michael 
And allow us to self-service this file in the future.

Change-Id: I699480919bcb41250552123e691ddf1432077003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2231900
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 2020-06-05 09:08:24 +00:00
Edward Lesmes
393b040fb4 Add sokcevic@google.com to owners 
Change-Id: Iac0797ddb6331d5b07f9919932560519d78c640a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2226049
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2020-06-02 16:40:04 +00:00