InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,129 Commits 6 Branches 0 Tags
bf32de3167aa5d172223b50b13758f2fb0bce5e5
Commit Graph

1303 Commits

Author SHA1 Message Date
Scott Lee
bf32de3167 add metrics_xml_formatter 
git cl format supports formatting certain xml files under tools/metrics.
This CL adds metrics_xml_formatter so that the formatter can be run
with git cl format.

Bug: b/369827156
Change-Id: I5922cd79304aa8e06917aacc9f2d9bd3ed548c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6072565
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2024-12-13 15:05:09 -08:00
Allen Li
522f5a4bd1 gerrit_util: Use git-credential-luci instead of luci-auth 
git-credential-luci is very similar to luci-auth, except that it is
expressly for git/Gerrit.  Therefore, it hard codes the scopes needed
for git/Gerrit.  It's also a separate binary, which makes it more
convenient for us to configure it for ReAuth later.

Bug: b/382341041
Change-Id: I7de56d3922adac7eb4671849eb6e30be310d4de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6073043
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-12-06 01:39:13 +00:00
Allen Li
d2fdba4e78 Improve printed info in git cl creds-check 
May help user to diagnose/debug some issues.

Bug: b/372552465
Change-Id: Ia9fc4fd49c8ee80bccd98442ed5589324d0b23b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6068966
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Allen Li <ayatane@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-12-04 01:49:36 +00:00
Matt Stark
46ade108f8 Update the error message for detached head. 
This allows for better support for both jj and git-branchless, both of which require no branches.

Change-Id: I63d9273ed5f38f6b6bb24a1ba2ecd559983120a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6002155
Commit-Queue: Matt Stark <msta@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-11-08 02:49:00 +00:00
Joanna Wang
9bf2a2011a Improve message about why someone might want to use --force during git cl patch 
Change-Id: I1c96164049513edb8e907928053b1eb09be2040f
Fixes:b/375594912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5979029
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-10-31 00:54:59 +00:00
Scott Lee
136e7e7594 [cpplint] add stdin support in stdin 
Cpplint can already process input from stdin (when the filename is '-'),
but `git cl lint` currently lacks this capability.

Adding stdin support to `git cl lint` would enable seamless integration
with IDEs like Visual Studio. Linters could then operate directly on
unsaved code within the editor.

Bug: 372288610
Change-Id: Ib2d5a3534ac0c5afcfcac64b708becde41612881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5917767
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2024-10-08 23:30:44 +00:00
Anne Redulla
1291794f5e Check git version 
On `git cl upload` and when running a command on all deps
using `gclient` in a non-Cog env, prints/logs a warning if git
should be updated. Non-blocking; command should still be
attempted as usual.

Bug: b/360206460
Change-Id: I8ebef4cb8b520124bc34ade7f0f2179874b470a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5874690
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Anne Redulla <aredulla@google.com>
 2024-09-26 00:13:53 +00:00
Allen Li
4b94130034 [gerrit_util] Add fallback if missing Gerrit account 
Bug: b/366261039
Change-Id: I7d22c4f03ad9bd837190dee7a511af3437a30434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5869050
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-09-18 21:57:33 +00:00
Joanna Wang
d43a3eb748 Add end_commit for calculating GitChange diffs. 
Bug: b/365162784

Change-Id: I97b69b1ae5183bbdaa7d4de0b1f23e62f4e1d8d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5853908
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2024-09-12 21:07:57 +00:00
Gavin Mak
43691064b4 Remove commits-to-cherry-pick only after a cherry-pick is created 
If `git cl cherry-pick` fails to cherry-pick a CL, it should print
out the commit it failed to cherry-pick. Right now, that commit
is missing from the "print_any_remaining_commits" output
since commits get popped from the dict regardless of whether or
not a CL is created.

Bug: 364375259
Change-Id: Iac61f50b8f8f226b9e70bc2d0fa235f39c27d91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5829953
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2024-09-05 23:56:06 +00:00
Arthur Eubanks
5eca5541e8 [git-cl] Only ignore deleted files for formatting purposes 
Multiple people have complained that we should format files when changing class names. That seems better than not formatting moved/copied files (you can always format a file separately before moving it to workaround the issue of moving unformatted files and presubmit complaining).

This CL essentially reverts https://crrev.com/c/4904205, meaning we will again run clang-format on files that were copied/moved.

https://crrev.com/c/5199134 is probably the proper fix by only looking at lines that were actually changed, but does not yet work with non-C++ formatters.

Checked locally that previously we wouldn't format a moved file, and with this change we now do.

Bug: 737568
Change-Id: Ie12c802316d5e293f2946c532e1600c342caaf59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5840596
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2024-09-05 22:55:26 +00:00
Gavin Mak
9e91079582 Use the cherry picked CL's Change-Id 
If a CL and its cherry pick share a change ID, Gerrit will link to each
other in the UI.

Bug: 364692466
Change-Id: I6740ddfd813124d5876b29b05c4b8f91822faa57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5838865
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Matt Jones <mdjones@google.com>
Commit-Queue: Matt Jones <mdjones@google.com>
 2024-09-05 14:06:26 +00:00
Gavin Mak
2836a02f55 Make "git cl cherry-pick" handle failed cherry picks better 
"Better" means:
1. Retrying a failed gerrit_util.CherryPick only once instead
   of 5 times for faster feedback since more retries don't help.
2. Gracefully handling GerritErrors raised by gerrit_util.CherryPick

This CL also fixes a minor bug where the "Remaining commit(s) to
cherry pick" message would always print even if there were no more
commits left.

Bug: 341792235
Change-Id: I1712a6b080b14396463f3bceeeac84772f1253b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5825626
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2024-08-30 15:35:36 +00:00
Robert Iannucci
b46b033bd7 [git-cl] Make quick Gerrit RPC at the top of CMDupload. 
This prevents the following scenario:

$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # requires thinking
CRASH!! You need to authenticate!!
$ <authenticate>
$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # opens new, fresh, editor :(

Now it will do:

$ git cl upload ...
CRASH!! You need to authenticate!!
$ <authenticate>
$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # requires thinking

R=ayatane, sokcevic@google.com

Change-Id: Icada2b69b3f4ddaff810dc82d54d65f3918d1434
Bug: 351071334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5826970
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
 2024-08-30 01:20:40 +00:00
Gavin Mak
aaaca2863c Make git cl cherry-pick use a unique change ID 
If a commit's Change-Id identifies more than one change, git cl
cherry-pick will get an error when trying to rebase the cherrypick:
"Multiple changes found for <change-id>"

Make sure the command only uses a CL's unique ID.

Bug: b/362514041
Change-Id: Ia84053fc8a49eadfc0f1e732929fb58e507a6bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5818412
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2024-08-28 16:18:18 +00:00
Gavin Mak
d4c6d40d50 Reduce RebaseChange max tries from 6 to 2 
On failure, gerrit_util always retries HTTP requests the maximum
number of times. This doesn't always make sense, e.g. for RebaseChange
which gets 409 on a merge conflict and can't be retried into
succeeding.

Bug: b/341792235
Change-Id: I6f9e212c5b0365236a99768f056bab2eb60cddc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5773566
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2024-08-09 16:11:44 +00:00
Gavin Mak
ec800aa077 Add "git cl cherry-pick" for cherry picking a chain of CLs via Gerrit 
Users who want to upload multiple cherry picks usually run "git
cherry-pick" locally, multiple times. Gerrit does not recognize
these changes as cherry picks and neither do other services that
query cherry pick info from Gerrit, e.g. rubber stamper.

For Gerrit to identify a change as a true cherry pick, you need to
use their Cherry Pick Revision REST API endpoint. This new command
uses it to create a chain of cherry pick CLs recognized by Gerrit.

Bug: b/341792235
Change-Id: I4ba75da3901f6ea68c1debd65820e802da681798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5756161
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2024-08-08 17:34:09 +00:00
Allen Li
40cece20d0 [git_cl] Fix some type checking errors 
Bug: b/351071334
Change-Id: I15b8c7658c5959dbf88168e278525c2b8e2e4b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754255
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-08-03 00:09:25 +00:00
Allen Li
72c2f2b6a5 [git_cl] Fix parse_args type checking 
Bug: b/351071334
Change-Id: I1387d88196d06ce6c10fdff3253cebcc21428bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754388
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-08-02 22:54:14 +00:00
Allen Li
be5ff1a6c4 [git_auth] Move auto configure logic 
Bug: b/351071334
Change-Id: Ic6574f86208b22e406e36f8cd45a564ea74ec7f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5742793
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-31 22:21:51 +00:00
Allen Li
db74f93ff9 [git_auth] Rename configure functions 
Bug: b/351071334
Change-Id: Ic0378590bd678226db2563e9180076f87dafdc66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739678
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-30 23:47:59 +00:00
Allen Li
1590dceac5 [git_auth] Move auth related functions 
Bug: b/351071334
Change-Id: I4f88b06011864d4412b7ff94a99dfb4f6852ba62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739677
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-30 23:07:20 +00:00
Allen Li
370d588239 [git_auth] Parametrize cwd and changelist 
To prevent import cycles when moving the auth functions to git_auth

Bug: b/351071334
Change-Id: Idfb474b9a738d5db51dcd82ffde5d047cc36af9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5742790
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-29 22:58:06 +00:00
Allen Li
fc6af5ccd7 [git_auth] Fix YieldConfigRegexp type 
It compiles it internally

Bug: b/351071334
Change-Id: I4a1b2b47b9813b3a1e11bbb07b328ffcc50bc609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5744335
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-29 21:13:58 +00:00
Allen Li
3e86c1254a [git_auth] Fix type checking 
Bug: b/351071334
Change-Id: Icc54c7b0b4783cea80dda9fda9ac2c7086bd14fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5742438
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-29 20:42:58 +00:00
Robert Iannucci
4903a45ccc [git_auth] Fix some bugs introduced during refactoring. 
R=ayatane, dlf

Change-Id: I11371375b7f02e9ed5b67cde79ee05da6b0ba5c1
Bug: 351071334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5740607
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Dan Le Febvre <dlf@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-26 17:35:03 +00:00
Allen Li
8dde9800ee [git_auth] Rename GitAuthConfigChanger 
Bug: b/351071334
Change-Id: Ia12bf72bfaef11768cb60ba0631aafd5ffc9f1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739676
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-25 23:23:04 +00:00
Allen Li
fed7aa526c [git_auth] Rename GitAuthMode 
Bug: b/351071334
Change-Id: I29bfdff79e04d2df3df62019fc0c7dfd87dd302f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739675
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-25 23:04:26 +00:00
Allen Li
a61e517b45 [git_auth] Move Git auth stuff to new file 
Needs to be imported by gclient

Bug: b/351071334
Change-Id: Ibcb7c5541ffab6f9302efad863d0c59b8041122d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739296
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-25 22:03:29 +00:00
Allen Li
dbaad43b23 [git_cl] Add global+local Git auth configuration to creds check 
Adds new Git auth configuration logic which sets up a global config
which applies to all repos for a Gerrit host, as well as a local
config if the current repo has a different user set up (e.g., someone
with multiple emails used across different repos for the same Gerrit
host).

Bug: b/351071334
Change-Id: I3a73a50b7ecc80ba22442de808b7f20a488ffc6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723271
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-25 21:31:10 +00:00
Allen Li
9ddd200cba [git_cl] Remove OLD_AUTH usage 
Bug: b/351071334
Change-Id: I0d854fe932e945a75f78bf4559fa46f833dec147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739433
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-25 21:21:58 +00:00
Allen Li
b5029f0194 [git_cl] Add NO_AUTH enum 
There's going to be a use case to clear auth configuration even after
we remove the old auth stack.

Renumbering is safe because this enum is not stored outside of runtime.

Bug: b/351071334
Change-Id: Ib6522ffa6f1c8d817a37cce48d1abf2fcd7be339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5727083
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-24 21:41:24 +00:00
Robert Iannucci
a6502426b5 [git_cl] Remove uses of RunGit which interact with git config. 
The previous interactions were incorrect w.r.t. scm.GIT's config
cache.

This moves depot_tools towards having one fewer git wrapper
(converging towards scm.GIT).

R=ayatane, yiwzhang@google.com

Change-Id: I507628b53f6a87a1eecbbe3e1e27c1eb6af3b878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5648617
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 2024-07-23 16:32:51 +00:00
Allen Li
c1aaf922b6 [git_cl] Rename GitConfigMode to GitAuthMode 
Make the name more accurate, this mode is specific to auth config

GitAuthConfigMode would be more accurate, but too verbose IMO

Bug: b/351071334
Change-Id: If5c7c07ee5fa62d3ac1026b04654650c1b7043f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723270
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-20 03:04:11 +00:00
Allen Li
7b3067fa3d [git_cl] Improve new_from_env documentation 
Bug: b/351071334
Change-Id: Idde2605c7e11bd21ff18a9a5a5ed5ef58ae12158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723269
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-20 03:04:07 +00:00
Allen Li
91937bf196 [git_cl] Parametrize email in ShouldUseSSO 
Moves the dependency on Git+cwd up the call stack

Bug: b/351071334
Change-Id: Ia313f9d4720ee10398b757217c333118e9fc7341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723091
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-20 00:48:36 +00:00
Allen Li
e7cc4c93c0 [git_cl] Improve docstring 
Bug: b/351071334
Change-Id: Id28e9d87c517ea0ad6c4a939ce85b52fc6f55810
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723090
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-20 00:46:59 +00:00
Allen Li
ead6e4d2fc [git_cl] Parametrize cwd in new_from_env 
We need to be able to do this from different dirs later.

Bug: b/351071334
Change-Id: I18dd2c71ea52d79a56ccaee88a12be97465b9d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723089
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-20 00:46:53 +00:00
Allen Li
4986d4a74b [git_cl] Parametrize cwd in ShouldUseSSO 
Remove implicit/global assumptions which could affect tests.

Bug: b/351071334
Change-Id: Ie266228f404b768cb539fdc17dddbbb13693e939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5723208
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-20 00:29:35 +00:00
Allen Li
dbebea0aa2 [git_cl] Add apply_global 
Bug: b/351071334
Change-Id: I235eb26cd46a82251b3a757edd37961bce067522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5719714
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-20 00:22:21 +00:00
Allen Li
2fe4794943 [git_cl] Fix cookie setting 
Bug: b/351071334
Change-Id: I0245e38b71b8c65e77dcc2aeee040121c725b440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5718644
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2024-07-19 23:12:14 +00:00
Allen Li
fa224cdb07 [git_cl] Add _shortname property 
Removes redundant param

Bug: b/351071334
Change-Id: I1040f72df49851fe87e5ea9bf5e9e2fb50ca46b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5718640
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-19 23:12:07 +00:00
Allen Li
5a723500c0 [git_cl] Add _base_url property 
Makes __init__ a bit cleaner, and planning to make _shortname a
property also next, since it can be derived from _remote_url

Bug: b/351071334
Change-Id: I12f4363723172a9cdaba37f6beb8fa37bbf09d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5718639
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-19 01:34:54 +00:00
Allen Li
8715e8e64d [git_cl] Let creds-check revert new auth config changes 
Gated this behind new auth flag explicitly being set (so people who
haven't set anything = default off don't run this, just in case)

Bug: b/351024645
Change-Id: I8498b98404ad89d3ca390d3baa798daee0b4b53b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5698379
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-16 22:06:41 +00:00
Allen Li
fa55ddf571 [git_cl] Move git new auth config version to constant 
Bug: b/351024645
Change-Id: I9454c6678d5754d21d6db9ac1574266e9127034f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5698378
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-16 22:06:36 +00:00
Allen Li
e4d053ae47 [git_cl] Make mode attribute public 
So it can be overridden if needed.

Bug: b/351024645
Change-Id: I6ff5388cefeae00b1ec21e822e127b0eec349428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5698628
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-16 22:06:31 +00:00
Allen Li
1feb63c434 [git_cl] Rename infer_and_create 
Didn't like the old name, finally came up with a better one

Bug: b/351071334
Change-Id: I79ca52f3fa821a2348b64e9215d0fd89cf425328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5698627
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-16 22:06:24 +00:00
Allen Li
55fc2f8208 [git_cl] Move cwd param to apply method 
This feels like bikeshedding, but semantically, we are applying the
changes to a specific repo, and you could take one
GitAuthConfigChanger and apply it to multiple different repos.

(The config host, etc. are usually tied to a specific repo, so there
needs to be some further refactoring to make this actually decoupled
from the working directory, but keeping this small for sane code
review)

Bug: b/351071334
Change-Id: I756f1134be516e19e26e35ffca7f7ceb389aaa30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5699189
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2024-07-16 21:18:07 +00:00
Allen Li
c0f7c05c50 [git_cl] Fix missing variable 
Bug: b/351071334
Change-Id: I337dc37c69be6eb2197bda23098506eb1ab90709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5709132
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-16 20:55:23 +00:00
Allen Li
9b51399218 [git_cl] Apply OLD_AUTH if new auth flag is off 
Note that this logic still isn't run yet, because we only call
ConfigureGitRepoAuth behind new auth flag checks.

Bug: b/351024645
Change-Id: Idca4d1ce3ebd3f2c673f244f85b3cae6da39f8e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5699188
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-07-15 22:42:10 +00:00