InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,810 Commits 6 Branches 0 Tags
ac1e4a9bb7f92355829dc5725fa5d5a12a909c89
Commit Graph

32 Commits

Author SHA1 Message Date
Ho Cheung
ac1e4a9bb7 [gsutil] Upgrade to gsutil 5.35 and clarify Python requirements 
Update gsutil to a newer version to resolve some compatibility issues
with newer Python versions.

And update the README to reflect the new changes.

Bug: 40283283
Change-Id: I1e02c6868e932da0af45a631fc34539c3543868e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7058090
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Ho Cheung <hocheung@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2025-10-27 16:51:16 -07:00
Gavin Mak
0772b51a97 Make cipd available in recipe bundle for dirmd 
dirmd is present in the CIPD package, but running it gets:
./cipd_bin_setup.sh: line 25: ./cipd: No such file or directory

Bug: 416037494
Change-Id: I69b6640056ba9454737d02973119ee5cde771d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6580852
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Gavin Mak <gavinmak@google.com>
 2025-05-27 11:43:28 -07:00
Gavin Mak
c273e3eb62 Make dirmd available in recipe bundle 
`dirmd` was not previously included in the recipes bundle, and couldn't
be used in recipes. Update `.gitattributes` to include it in the bundle.

Its dependencies should already be covered by `/*.bat`, `/*.sh`,
and `/cipd_manifest*` patterns.

Bug: 416037494
Change-Id: I320cb6ef9b5f1679c95c4f36ece534ddc75bcdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6546185
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-05-14 16:52:15 -07:00
Struan Shrimpton
e416566a1e Establish a directory for chrome infra telemetry 
See go/chrome-infra-telemetry-dd for more details. This CL is to
establish a folder where we can create infra libraries shared by
depot_tools and chromium/src. Note that the folder cannot be named
lib due to https://crbug.com/40259280. "libs" should avoid that
problem

Bug: 326277821
Change-Id: I71641ee74d15474353ef0210579a3a24d2726270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5797754
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 2024-08-21 21:38:42 +00:00
Allen Li
02b791b756 [cipd] Add git-credential-luci (reland) 
This can be used for OAuth to Gerrit (in lieu of gitcookies).

Originally landed
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5620638

Reverted due to interfering with git fetch

https://ci.chromium.org/ui/p/infra-internal/builders/cron/build%20recipe%20roller/b8745385521046617057/infra

Fixed by excluding git-credential-luci from recipe bundles

Bug: b/335483238
Change-Id: I9a0887b32596be122509de0ec1c238088e73bb49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5627937
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-06-13 22:59:00 +00:00
Anne Redulla
c7aca34c8e Define main metadata validation functions 
This is a reland of commit a1cfc693af

The original commit was reverted do to `ModuleNotFoundError`s. I believe this was due to not specifying `metadata` to be part of the `depot_tools` recipe bundle. I have updated `.gitattributes` for this, and also added `__init__.py` files.

I will put the changes to `presubmit_canned_checks.py` in a later CL, once I can confirm `metadata` is being bundled.

Original change's description:
> [ssci] Added CheckChromiumMetadataFiles in presubmit_canned_checks
>
> Bug: b:277147404
> Change-Id: I14a2f11b256bc85fdfe225443ef533c38463ca3e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4796694
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Reviewed-by: Rachael Newitt <renewitt@google.com>
> Commit-Queue: Anne Redulla <aredulla@google.com>

Bug: b:277147404
Change-Id: Ibd9efd5970a5393c157ca8763f97064d7c167803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4803385
Reviewed-by: Rachael Newitt <renewitt@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Anne Redulla <aredulla@google.com>
 2023-08-25 01:09:08 +00:00
Josip Sokcevic
f792c24879 Add lib to recipe cipd package 
This also removes entries that no longer exist in depot_tools.

R=jojwang@google.com

Change-Id: Ic2ddbf4f926d62baf8a0981ab21dad3a517b5a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4301253
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
 2023-03-02 01:49:58 +00:00
Junji Watanabe
b6030901cf Setup cipd bin before calling ninja/autoninja 
Tested in led builds on chromium/tools/build repo.

# Linux
```
> led get-build 8811504372914233697 | led edit-recipe-bundle -O depot_tools="$HOME/depot_tools" | led launch
...
https://ci.chromium.org/swarming/task/5b749884a3f3fa11
```

# Windows
```
> led get-build 8811491780369249585 | led edit-recipe-bundle -O https://ci.chromium.org/swarming/task/5b74bc67963d7610
```

Bug: 931218
Change-Id: I4a967f7544f71a9fef8a44baad45196365659596

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: infra
Change-Id: I4a967f7544f71a9fef8a44baad45196365659596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3697958
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 2022-06-14 01:31:08 +00:00
Junji Watanabe
eb8db11557 Add .cipd_impl.ps1 to recipe bundle 
https://crrev.com/c/3686855 missed this file to run cipd.bat.

Bug: 931218
Change-Id: Ib4f8d9d31c259477d5531f32bf1e6f44d71d2ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3697956
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2022-06-09 16:51:12 +00:00
Junji Watanabe
47d510eff1 Include files required for cipd_bin_setup to recipe bundle 
https://crrev.com/c/3674982 caused compile step failures finding depot_tools/.cipd_bin/ninja because depot_tools recipe bundle doesn't setup .cipd_bin.

It needs to ensure .cipd_bin by calling cipd_bin_setup.{sh, bat} before calling ninja in the depot_tool recipe module.
This CL bundles more files required to call cipd_bin_setup.

Bug: 931218
Change-Id: I3d5067c0326415b086aca7e6e56a8f6428969b0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3686855
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 2022-06-08 16:35:42 +00:00
Josip Sokcevic
1909696991 Reland "Update gsutil to use gsutil version 4.68" 
This is a reland of commit 8edc960e9a

Original change's description:
> Update gsutil to use gsutil version 4.68
>
> We can't yet upgrade to version 5.x since it's only py3 compatbile and
> some builders still rely on running gsutil with py2.
>
> R=gavinmak@google.com
>
> Bug: 1184108
> Change-Id: I002cc3625a2184ab42383b88a014c0631d1a33ee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3508516
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 1184108
Change-Id: I8f4b726c203ed12d415deeec249972fe855b59c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3514940
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-03-10 17:56:09 +00:00
Mike Frysinger
7f0091e524 chrome_set_ver: punt old script 
We deleted this in chromite back in 2013.  Looks like we forgot to
clean up depot_tools.

Bug: 216050
Change-Id: I7e7591aaa319ab1aeb7cc3f34e33b313b5029257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812199
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2021-06-15 21:38:08 +00:00
Mike Frysinger
eb386eb3d2 Reland "repo: auto-update depot_tools when used" 
This is a reland of 19512276d2.
It includes an update to .gitattributes for recipes.

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

Bug: 1148984
Change-Id: Ia7844016cb04d3197e51ad05da64c885cf3277a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561229
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 2020-11-30 18:17:40 +00:00
Edward Lemur
1f3bafbab4 git-cl: Run using vpython 
Bug: 1002153
Change-Id: I02ffa574f072575c4b6662a7f32678428ed3f85d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845498
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-10-08 17:56:33 +00:00
Edward Lemur
9f4b37db0e depot_tools: Make watchlist tests use mock and remove pymox. 
Bug: 984182
Change-Id: Iaacb10dfc5ce7c624ac52edb76a9a74c6e2fd1cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757122
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2019-08-15 23:58:25 +00:00
Edward Lesmes
98eda3f3e4 Revert "depot_tools: Run Python scripts using vpython (Part 1)" 
This reverts commit d6186f9936.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> depot_tools: Run Python scripts using vpython (Part 1)
> 
> Tbr: iannucci@chromium.org
> Bug: 984182
> Change-Id: If36722e190d305f89d63dce91d0a600ddc34ebe3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748589
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org

Change-Id: I7686985852608d0703bcbbab137df1ce82b29723
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749853
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-08-12 21:09:53 +00:00
Edward Lesmes
b22aabe437 Revert "depot_tools: Include vpython in cipd bundle." 
This reverts commit 1222ecd532.

Reason for revert:
recipes should never run any of the shims which fetch cipd packages in depot_tools

Original change's description:
> depot_tools: Include vpython in cipd bundle.
> 
> Tbr: iannucci@chromium.org
> Bug: 984182
> Change-Id: I01b0e12179d2314c48c00d74550ceea1e32b355d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749844
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org

Change-Id: Iadf11b480c03e0bd57ba2c4210d39bdc6cb27b3d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749851
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-08-12 21:03:30 +00:00
Edward Lemur
1222ecd532 depot_tools: Include vpython in cipd bundle. 
Tbr: iannucci@chromium.org
Bug: 984182
Change-Id: I01b0e12179d2314c48c00d74550ceea1e32b355d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749844
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-08-12 20:22:10 +00:00
Edward Lemur
d6186f9936 depot_tools: Run Python scripts using vpython (Part 1) 
Tbr: iannucci@chromium.org
Bug: 984182
Change-Id: If36722e190d305f89d63dce91d0a600ddc34ebe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748589
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-08-12 17:56:58 +00:00
James Darpinian
f994d87e56 Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 
This reverts commit d52b306f84.

Reason for revert: Broke ANGLE CQ with "ImportError: No module named six"
Example: https://ci.chromium.org/p/angle/builders/try/mac-dbg/6758

Original change's description:
> Reland "depot_tools: Move six to depot_tools' .vpython"
> 
> This is a reland of 3a98df0bdd
> 
> Original change's description:
> > depot_tools: Move six to depot_tools' .vpython
> > 
> > Bug: 984182
> > Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> 
> Bug: 984182
> Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: Id4488249b607441df9f00aa51f4a1f2bc4ad5cfd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739582
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
 2019-08-06 18:57:40 +00:00
Edward Lemur
d52b306f84 Reland "depot_tools: Move six to depot_tools' .vpython" 
This is a reland of 3a98df0bdd

Original change's description:
> depot_tools: Move six to depot_tools' .vpython
> 
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>

Bug: 984182
Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-08-06 17:55:59 +00:00
Edward Lesmes
365720e237 Revert "depot_tools: Move six to depot_tools' .vpython" 
This reverts commit 3a98df0bdd.

Reason for revert:
Can't roll into skia and build_internal

Original change's description:
> depot_tools: Move six to depot_tools' .vpython
> 
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>

TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: I51e502e6f7633a6f26898f1ecbcd86ccf9c7c123
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1718996
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-07-25 20:51:36 +00:00
Edward Lemur
3a98df0bdd depot_tools: Move six to depot_tools' .vpython 
Bug: 984182
Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
 2019-07-25 19:04:34 +00:00
Yoshisato Yanagisawa
98c0fdb927 Add autoninja* to .gitattributes. 
Bug: b/77176746
Change-Id: I8f027daa6f867d61f0a9124a6d22c512bf91f219
Reviewed-on: https://chromium-review.googlesource.com/c/1325267
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
 2018-11-09 01:06:34 +00:00
Nodir Turakulov
081487b9fb Add yapf 
Add yapf and yapf.bat with a vpython spec, so it can be used anywhere, e.g.
bots.

Change-Id: I363c0251ed766b2bb15a8c0f03615bc9a3ecb37a
Reviewed-on: https://chromium-review.googlesource.com/1107170
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2018-06-20 21:55:59 +00:00
Aaron Gable
af2ffd933d Remove cq_client from depot_tools 
This library is no longer used by anything in depot_tools.

Bug: 770408
Change-Id: I8f0a99f73cf9c52731994c830085678ca652d2c4
Reviewed-on: https://chromium-review.googlesource.com/1072491
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
 2018-05-24 20:47:19 +00:00
Aaron Gable
b09e03ecb1 Remove Rietveld-only apply_issue 
This script only works (worked) for Rietveld issues, which
effectively no longer exist. It serves no purpose anymore.

Bug: 770408
Change-Id: Ic93ab3ce90d9c35b3bf5189e2beb4aa0c3983d44
Reviewed-on: https://chromium-review.googlesource.com/1070859
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
 2018-05-24 18:05:20 +00:00
Alexander Thomas
915b812209 Add gsutil.vpython spec to recipe bundles 
Bug: 764673
Change-Id: I8cb5c95cccfa0afbea441a85b062de48c185af19
Reviewed-on: https://chromium-review.googlesource.com/665121
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
 2017-09-13 16:57:55 +00:00
Dan Jacques
5aeeb72c33 [bootstraps] Sync at gclient, suppress output (#2) 
Have the "update_depot_tools" script also do a CIPD tool sync. This will
ensure that users and systems have access to tooling at sync-time rather
than just-in-time loading them at execution time.

Update the tool boostraps to suppress any sort of syncing logs, if it
does happen. This will ensure that users who execute the tools don't see
unexpected output.

BUG=chromium:748651
TEST=local
  - Tested on Mac and Windows.

Change-Id: I1aad897d885a07beeac40a372a658681720efd2a
Reviewed-on: https://chromium-review.googlesource.com/591229
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2017-07-28 13:33:40 +00:00
Dirk Pranke
44855b9498 Revert "[bootstraps] Sync at gclient, suppress output." 
This reverts commit 4d92fe4300.

Reason for revert: This moved the logging from invoking `led` or `vpython` to whenever someone would run something that would end up invoking `update_depot_tools`. It's good that we are calling this when we run update_depot_tools, but we probably should've suppressed the logging there in at least the success case, because now things are even more confusing. See crbug.com/748651.

Original change's description:
> [bootstraps] Sync at gclient, suppress output.
> 
> Have the "update_depot_tools" script also do a CIPD tool sync. This will
> ensure that users and systems have access to tooling at sync-time rather
> than just-in-time loading them at execution time.
> 
> Update the tool boostraps to suppress any sort of syncing logic, if it
> does happen. This will ensure that users who execute the tools don't se
> unexpected output.
> 
> BUG=None
> TEST=local
>   - Tested on Mac and Windows.
> 
> R=​dpranke@chromium.org, iannucci@chromium.org
> 
> Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843
> Reviewed-on: https://chromium-review.googlesource.com/581494
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,dnj@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I2485c9dd2e48a8dbdeebfff5da9d4c708e0edcb7
Reviewed-on: https://chromium-review.googlesource.com/585867
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
 2017-07-26 02:33:01 +00:00
Dan Jacques
4d92fe4300 [bootstraps] Sync at gclient, suppress output. 
Have the "update_depot_tools" script also do a CIPD tool sync. This will
ensure that users and systems have access to tooling at sync-time rather
than just-in-time loading them at execution time.

Update the tool boostraps to suppress any sort of syncing logic, if it
does happen. This will ensure that users who execute the tools don't se
unexpected output.

BUG=None
TEST=local
  - Tested on Mac and Windows.

R=dpranke@chromium.org, iannucci@chromium.org

Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843
Reviewed-on: https://chromium-review.googlesource.com/581494
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2017-07-24 18:32:30 +00:00
Robert Iannucci
3a4a725026 [recipes] add .gitattributes for proper recipe bundling 
R=dnj@chromium.org

Bug: 662654
Change-Id: Ic5a59eeb67c435d54878ef5f060399f6b2963cd4
Reviewed-on: https://chromium-review.googlesource.com/523015
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
 2017-06-10 01:03:45 +00:00