InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,841 Commits 6 Branches 0 Tags
9997ceb9a1c8680b029e85dc9fe7515dec23cf69
Commit Graph

8841 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
recipe-roller
6b0bdb33f9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823392654840159329

recipe_engine:
27f44e96a6
  27f44e9 (olivernewman@google.com)
      [json] Move json_fixup into json module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I96ac884ef3dabcb0f694c48a6eddd82b45e69067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3430303
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-02-01 22:34:55 +00:00
recipe-roller
e038545c2b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823402091761702673

recipe_engine:
1b1ecd03e0
  1b1ecd0 (olivernewman@google.com)
      [recipes.py] Set --quiet on git fetch

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=dpranke@google.com, iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I559774d210c32d2557fade1c406c92e4fdd72469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428936
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-02-01 19:59:45 +00:00
Vadim Shtayura
5c308b71dd [lucicfg] Update to v1.30.9. 
The only change is:
https://chromium-review.googlesource.com/c/3428299

R=iannucci@chromium.org
BUG=1182002

Change-Id: I8e7b3a2315eceaa9285a9b4b94fc6e09493f02ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428355
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2022-02-01 18:52:41 +00:00
recipe-roller
8a6d00f116 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823466894054118465

recipe_engine:
5675f70128
  5675f70 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 17dd9c65691b to 55b6fea03452

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e619fe2668390bc3597159428f4da642188d0cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428920
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-02-01 02:50:20 +00:00
Takuto Ikuta
98cf932814 ninjalog_uploader: do not redirect stderr 
Fixed: 1292542
Change-Id: Ia312eb7e4e3fd8d4c2b0fdaa10b7cc0290d38b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428659
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2022-02-01 00:47:31 +00:00
recipe-roller
9c2e78d2eb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823475697464031329

recipe_engine:
e04c8561df
  e04c856 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from d980af3b2cd9 to ce8e2e60bf68

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6826510c075a28f63cf0470f5b40d8c02b244fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428344
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-02-01 00:36:40 +00:00
recipe-roller
8dd74d4f85 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823757559656099905

recipe_engine:
b1529aa30a
  b1529aa (gbeaty@chromium.org)
      Output the number of potential candidate commits.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iff7cbace9a697064093c0b9594e2389b86fab236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3425440
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-28 21:50:32 +00:00
dan sinclair
92469157e0 Add rs files to git gs. 
Rust support is being tested out in Chromium (crbug.com/1292073). This
CL adds support for searching rust (.rs) files when using git gs.

Bug: 1292064
Change-Id: I5e2c5aa16e4dfa5f51a632afda7bdb5ab263b6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3425617
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2022-01-28 21:31:25 +00:00
recipe-roller
f698cfce9e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823765738068482353

recipe_engine:
b406be2b7c
  b406be2 (gbeaty@chromium.org)
      Remove python2 compatibility from buildbucket:run/multi recipe.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie39a54d72f35295a0e57b79a6124a036d1846e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3423669
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-28 19:46:12 +00:00
Garrett Beaty
dd93ebcac8 Add method for setting test data for get_files_affected_by_patch. 
The get_files_affected_by_patch method on the test API will return a
TestData object that determines the output of the "git diff" call. a
Test was added specifically for the get_files_affected_by_patch API
method to ensure that the test API operates as expected.

Change-Id: Ia1846700461757a72ed518894a5a38a8ca54fcc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3422006
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
 2022-01-28 18:28:22 +00:00
Darshan Sen
0dc69c4e79 Replace all rem comments with :: comments in batch files 
Though the Microsoft docs recommend using rem to write comments, it has
a shortcoming - redirection characters (< or >) or pipes (|) aren't
allowed. However, :: though undocumented, is a better alternative as it
allows such characters.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
Change-Id: I95a0445168527ab5087246238f0216d5f6177046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400399
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
 2022-01-28 14:55:02 +00:00
Josip Sokcevic
289dedd36b Remove unused arguments from bot_update recipe 
gclient removed syntax validation flag in 2020:
https://crrev.com/c/2083589, so this can safely be removed.

R=aravindvasudev@google.com, gavinmak@google.com

Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Change-Id: I2aced6cdb01d571ca361cc57e7c8715c9ca40552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3419278
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-27 23:40:33 +00:00
Vadim Shtayura
925f2fa416 [lucicfg] Update to v1.30.8. 
To pick up conditional bindings support in LUCI Scheduler.

R=iannucci@chromium.org

Change-Id: I16fd0329db9b4a62cdb067b9e9b1e94ceb48f086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3419176
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2022-01-27 20:32:26 +00:00
recipe-roller
3bf9766110 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823855706329430113

recipe_engine:
503f1c16a4
  503f1c1 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 371a3309b190 to 9c88febc5ab6

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ea4a8f2a7b978d67ef0476716d6febe138c5c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3421572
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-27 19:53:16 +00:00
recipe-roller
82a2398931 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823860733982438289

recipe_engine:
f40ed1ad36
  f40ed1a (bpastene@chromium.org)
      Make the 'critical' field be configurable for trybuilds in reci...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3fbe5b14db84892396eb672839e6e8b4acb62e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3421566
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-27 18:31:56 +00:00
recipe-roller
d5862557d6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823943154243442865

recipe_engine:
ca3ecae8e8
  ca3ecae (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from b232340b0fe0 to 7528d700b89d

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id617dd9cdb95807c459f670ba7217b86fe566c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3416568
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-26 20:45:45 +00:00
Josip Sokcevic
e1b48631b2 Remove deprecated arguments in bot_update recipe 
R=gavinmak@google.com

Change-Id: I37bbdf02bfd32577224224a3114171810a7318fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3416677
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-01-26 20:12:55 +00:00
Josip Sokcevic
ed6aa2b0e8 Reland "Use py3 in bot_update and gclient recipe_modules" 
This is a reland of bb88492ff3

Original change's description:
> Use py3 in bot_update and gclient recipe_modules
>
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited
> Recipe-Nontrivial-Roll: chrome_release
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Bug: 1289280
> Change-Id: Id61bacf4acef319f7ea22161081b632677ca363c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402082
> Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: 1289280, 1289504
Change-Id: I2f2f7244568b1fdfb960d5cdfa3937175ac1ed2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3414742
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-26 18:14:05 +00:00
Josip Sokcevic
d05a2e0395 Add aravindvasudev to owners 
R=aravindvasudev@google.com, gavinmak@google.com

Change-Id: Ic00cc4a6b0ca9aa7d8109f0d8c611044a4a1da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3414741
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-01-25 23:54:05 +00:00
recipe-roller
403558f6ee Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8824037529371800769

recipe_engine:
619324050c
  6193240 (bpastene@chromium.org)
      Add 'resultdb_info' fields to default swarming JSON in recipe t...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I550ee7f49c6ab711ba065a3d6a9f2ca8ca78ded2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3415790
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-25 20:21:49 +00:00
Aravind Vasudevan
c5f0cbb865 Use pylint 2.7 for depot_tools 
This includes a few fixes for specific errors, and disables several new
warnings introduced in this version, in order to allow for an incremental migration.

Bug:1262286
Change-Id: I4b8f8fc521386419a3121bbb07edc8ac83170a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413679
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2022-01-24 23:56:57 +00:00
Garrett Beaty
d94f9a6d20 Add a method for enforcing a tryjob. 
The tryserver.require_is_tryserver method will create an infra-failing
step that raises an exception if there is no CL associated with the
build. In the case of an LED task, it will only fail so as not to cause
the removal of the builder cache in the case of a minor user error.

Change-Id: I05d3a86cc727577f067fb3eae49e46398345f672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413971
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-01-24 23:46:17 +00:00
Josip Sokcevic
42c5bbbc96 Revert "Use pylint 2.7 for depot_tools" 
This reverts commit 22bf605bb6.

Reason for revert: breaks gclient sync

Original change's description:
> Use pylint 2.7 for depot_tools
>
> This includes a few fixes for specific errors, and disables several new
> warnings introduced in this version, in order to allow for an incremental migration.
>
> Bug:1262286
> Change-Id: Ie97d686748c9c952e87718a65f401c5f6f80a5c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400616
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 1262286
Change-Id: Ieb946073c7886c7bf056ce843a5a48e82becf7a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413672
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-24 21:42:28 +00:00
Aravind Vasudevan
22bf605bb6 Use pylint 2.7 for depot_tools 
This includes a few fixes for specific errors, and disables several new
warnings introduced in this version, in order to allow for an incremental migration.

Bug:1262286
Change-Id: Ie97d686748c9c952e87718a65f401c5f6f80a5c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400616
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2022-01-24 21:11:19 +00:00
Josip Sokcevic
9a4db25b50 Remove deprecated parameters 
Those paremeters are deprected for over 4 years now. I found no usages
while searching for output_manifest in source.chromium.org.

R=machenbach@google.com

Bug: 1289274
Change-Id: I7d8f8ee29fdb046b255c96ad26f8dc7129b1f83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402741
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
 2022-01-24 19:27:28 +00:00
Gavin Mak
e9ea0d5c0d Fix depot_tools tests when running without py2 
Currently, running git cl presubmit fails without python 2 installed.
This CL replaces instances of 'python' in fetch_test.py with the generic
sys.executable and fixes a small error testRebaseUpdate due to an extra
period.

Bug: 1289839
Change-Id: Ib5802545af70fe0886448397fa76058bd2036527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3407864
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-01-24 18:32:38 +00:00
Andrew Lamb
19c4cef848 Update dirmd to newest depot_tools commit. 
- Needed to get newer proto schemas from messages that are
included in the Metadata message. Currently, `dirmd validate`
is failing with errors like
"unknown field: test_plan_starlark_files" which passes with
newer versions of `dirmd`.

Bug:b/182898188
Change-Id: Ib59e160ea22518f7fdf2c0f2e830c65481c116a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3368325
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Andrew Lamb <andrewlamb@chromium.org>
 2022-01-24 08:56:27 +00:00
Takuto Ikuta
18a2844b53 ninjalog_uploader: do not use capture_output and text 
capture_output and text args are not available in Python3.6.

Bug: 1290210
Change-Id: Id3c70ad456c5ca56df9935d64229f599d7aae4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3406721
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Commit-Queue: David Munro <davidmunro@google.com>
 2022-01-24 05:03:38 +00:00
Takuto Ikuta
653d7e6c4e ninjalog_uploader: fix command for Windows 
Windows doesn't work with shebang.

Fixed: 1289707
Change-Id: I9db5f550d7ab5d2f92ccac392c3a5ee9595a9bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3406711
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2022-01-24 04:35:37 +00:00
recipe-roller
4068ef45c6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8824394040072813425

recipe_engine:
a476355d81
  a476355 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from a169f70aa54e to 09f8b3edbbf1

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I633e94d81e46e852cd6ecdb3ec53d9b466303dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3407861
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-21 21:19:13 +00:00
Brian Ryner
6bfbe35cce Revert "Use py3 in bot_update and gclient recipe_modules" 
This reverts commit bb88492ff3.

Reason for revert: Broke bot_update: https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket/8824463357494497185/+/u/bot_update/stdout

Original change's description:
> Use py3 in bot_update and gclient recipe_modules
>
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited
> Recipe-Nontrivial-Roll: chrome_release
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Bug: 1289280
> Change-Id: Id61bacf4acef319f7ea22161081b632677ca363c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402082
> Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: 1289280
Change-Id: I371d599b17b42edd7b1aae581695e75a80ebae83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3403476
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-21 03:54:03 +00:00
recipe-roller
b8f1ca3058 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8824471710524633281

recipe_engine:
312823d273
  312823d (bryner@google.com)
      Convert git stdin/stdout to and from bytes.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1aa21fb634156878fb361c0a637e4c38c73e5890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3405077
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-21 00:38:53 +00:00
Josip Sokcevic
bb88492ff3 Use py3 in bot_update and gclient recipe_modules 
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: 1289280
Change-Id: Id61bacf4acef319f7ea22161081b632677ca363c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402082
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-21 00:26:22 +00:00
Takuto Ikuta
3dc0172a6b fix ninjalog_uploader.py 
This is to fix https://crbug.com/1288639#c5

Bug: 1288639
Change-Id: Ife224fb5d5fe4faa4a78785828d4fa488fda3c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3403475
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2022-01-21 00:04:23 +00:00
Alex Light
ac54b8de82 Add support for c++17 tuple destructuring (#487) 
C++17 adds support for tuple destructuring. This allow one to write
code such as:

```
std::pair<int, int> span = getSpan();
auto [start, end] = span;

// Use start as span.first and end as span.second
```

This makes cpplint recognize and allow a space before the '[' in this
situation.

This is a purposeful divergence from the internal version where the
entire whitespace/braces category was removed. It was decided to leave
the checks in since this is sometimes used without other formatting
tools.

Test: manual

(cherry picked from commit 26470f9ccb354ff2f6d098f831271a1833701b28
 from https://github.com/google/styleguide)

Bug: 1287491
Change-Id: Ib61a75853e19316b1bacf8dc56528f94c17e30a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389431
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Victor Boivie <boivie@google.com>
 2022-01-20 13:02:48 +00:00
Takuto Ikuta
a657331e90 ninjalog_uploader: use goma_auth to detect googler 
Bug: 1288639
Change-Id: I447e2f66603ffb8d68599dcf22023fd7857dc4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400398
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-20 00:24:57 +00:00
Josip Sokcevic
b674278ce7 Always fetch main in update_depot_tools 
If main is not fetchable, report the error to end user.

R=gavinmak@google.com

Bug: 1277136
Change-Id: I8c061719f9aadc42786045b3c5331bab3d0caae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389824
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-19 21:10:16 +00:00
Takuto Ikuta
237cc469e4 switch autoninja shebang to python3 
We don't want to use python2 and this doesn't use third party library
too so no need to be vpython which has a small overhead.

Change-Id: Iff924a87f0562069e29195a5693e2260e4a6684e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400397
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 2022-01-19 18:04:15 +00:00
Andrew Grieve
cb340f5b7b Fix git_common_test.py: git checkout -tb -> git checkout -t -b 
git now takes an optional parameter for -t

Bug: 1288010
Change-Id: I0b7b212229f8df846a2d80a1632387982fd7358e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3395441
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2022-01-18 19:42:54 +00:00
recipe-roller
fd7427ccf6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8825030197048673041

recipe_engine:
96ed3069ae
  96ed306 (rubensf@google.com)
      Allow extract.py to extract to non-empty dir

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2904892628241d8b27ee50034d58bcd19e8028ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389819
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-14 20:40:38 +00:00
Fumitoshi Ukai
56dedaeb14 Roll out goma client VERSION=240 
Bug: b/207719456
Change-Id: I7fdc401b92bbea866ad7dc4079342fd910b64dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3388375
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2022-01-14 04:17:59 +00:00
Bozydar Szadkowski
af9d5b78fd [reclient] Add use_remotexec gn arg support 
The change is a part of initiative to replace
use_rbe that infers using Remote Build Execution
with RE (Remote Execution) server agnostic use_remoteexec flag

Bug: 1247781
Change-Id: Ic58d70b2e604a822c03c43049417eb0a21eca728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3387614
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bozydar Szadkowski <bozydar@google.com>
 2022-01-14 02:00:50 +00:00
recipe-roller
1c658b53de Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8825107852234511233

recipe_engine:
e64eebcb48
  e64eebc (mohrr@google.com)
      [doc] Fix link

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I98c45d6adf907c10070225779efd3915941b4925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3387595
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-14 00:15:10 +00:00
Brian Ryner
5fe7c91547 Use fixed cryptography wheel for gsutil. 
The old version was compiled incorrectly for mac-arm64.

Bug: 1233745
Change-Id: I9d20c049df9f2e3f6a718282e518e0495eacf7e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3385087
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2022-01-13 17:20:39 +00:00
Xinan Lin
42afe9a2d3 Ensure the new patchset exists in Gerrit before we set bot-commit+1 
"Publish Change Edit" is not a synchronized API call on Gerrit.
After the call, we need to explicitly check if the new patch exists
in Gerrit. Or, we may label +1 on an old patch.

BUG=1286212
TEST=train
Recipe-Nontrivial-Roll: chrome_release
Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Xinan Lin <linxinan@chromium.org>
 2022-01-12 23:56:59 +00:00
recipe-roller
9fa0cb7230 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8825281985283601761

recipe_engine:
ffb8f400af
  ffb8f40 (bryner@google.com)
      Add zstandard extraction to archive recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5771ba387451f7fd6f99520228d30121b56b263e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3382012
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2022-01-12 02:03:54 +00:00
Josip Sokcevic
7592e0a623 Fix PRESUBMIT errors ignored if there are warnings 
R=gavinmak@google.com

Fixed: 1264947
Change-Id: If5163b167921f12cf91ca2efe3bbd1765109ba00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3360902
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-01-12 00:57:54 +00:00
Josip Sokcevic
c1a06c1ae0 Drop support for master branch in roll_dep 
R=gavinmak@google.com

Fixed: 1118447
Change-Id: I733c7f345a3a8e1dd4bf3a9935306ba43b1584c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3360904
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-12 00:44:14 +00:00
Josip Sokcevic
35061445ba Improve error message when a commit is not found 
Improve error message when gclient sync errors due to a bad commit.

R=aravindvasudev@google.com

Fixed: 1078864
Change-Id: I574c7f7d2b5419cf96a4b3a3e3c57e16baeeecf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3362175
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-12 00:32:54 +00:00
Josip Sokcevic
c3e25c828d Fix hangs when running pylint with py3 
R=gavinmak@google.com

Bug: 1280381
Change-Id: I9bec0f371aa300e2418ac1c200683c02b7e66cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3350910
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-11 23:33:14 +00:00