InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,904 Commits 6 Branches 0 Tags
7c4f7ec40818ddd883aa0a3b132cea06af92a713
Commit Graph

79 Commits

Author SHA1 Message Date
Aleksey Khoroshilov
7c4f7ec408 Make depot_tools scripts return exit codes properly on all platforms. 
Changes:
1. Windows: exit /b %errorlevel% should be used instead of goto :EOF to get valid exit codes during cmd /c <script>.bat invocation.
2. Windows: delayed var expansion is required in update_depot_tools.bat exit code generation.
3. Posix: update_depot_tools returns exit code from update_git_repo function in case of a failure.

A rule of thumb on Windows: goto :EOF should not be used if %errorlevel% must be returned for all possible invocations.

Test case for update_depot_tools changes:
1. Make a change to depot_tools sources that will conflict with next depot_tools update
2. Run update_depot_tools either directly or via gclient
3. Expect a git error is triggered
4. Inspect %errorlevel% or $? depending on platform
5. Expected 1, but the actual result is 0.

Test case for changes in other .bat files:
1. Make a change to depot_tools sources that will conflict with next depot_tools update
2. Run cmd /c gclient
3. Expect a git error is triggered
4. Inspect %errorlevel%
5. Expected 1, but the actual result is 0.

Change-Id: I64459982bcd9cc3db1319a9b39224b7a7af8c5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688632
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2022-06-07 18:44:59 +00:00
Josip Sokcevic
0213e4b2d8 Print updating depot_tools in stderr 
stdout print statement may interfere with automated tooling. Instead,
this prints the warning to stderr. See: https://crrev.com/c/3556588

R=gavinmak@google.com
Change-Id: I3fb72b7ab4afe42cb83ea5e506292f3e6e5ea8d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3561445
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-03-30 17:45:56 +00:00
Josip Sokcevic
f560d36bba Let user know when depot_tools is being updated. 
R=gavinmak@google.com

Change-Id: Ieacc0cbe21a5b7216bb8057b3a81139f2d2c608e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3556588
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2022-03-28 23:17:46 +00:00
Josip Sokcevic
b674278ce7 Always fetch main in update_depot_tools 
If main is not fetchable, report the error to end user.

R=gavinmak@google.com

Bug: 1277136
Change-Id: I8c061719f9aadc42786045b3c5331bab3d0caae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389824
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2022-01-19 21:10:16 +00:00
Josip Sokcevic
593a6b575b Fetch all refs/heads/* on depot_tools update 
If user downloaded depot_tools.zip before 2021-03-11, it contained only
fetch for refs/heads/master. As main branch is a new default branch,
users need to update fetch ref in order to fetch chanes from main
branch.

R=ehmaldonado@google.com

Bug: 1187238
Change-Id: I78041fc74f1bb505db375b9c1dced38cdfc9b144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753834
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2021-03-15 21:35:13 +00:00
Josip Sokcevic
89d2cc1ec4 Revert "Update depot_tools using main branch" 
This reverts commit c2c576e940.

Reason for revert: windows zip archived linked in documentation
only fetches master branch, so that needs to resolved first.

Original change's description:
> Update depot_tools using main branch
>
> R=​ehmaldonado@chromium.org
>
> Change-Id: Ie8d00331d649fa33158bb78d0bb64eacd121f044
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748935
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I873f84f8fbe3a6cde60955ca63eb81e6976dd1f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748946
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-03-10 22:50:14 +00:00
Josip Sokcevic
c2c576e940 Update depot_tools using main branch 
R=ehmaldonado@chromium.org

Change-Id: Ie8d00331d649fa33158bb78d0bb64eacd121f044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748935
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 2021-03-10 19:48:32 +00:00
Edward Lesmes
648b4cd2ca Add quotes around paths in bash scripts 
Follow up to crrev.com/c/2125626.

This allows depot_tools commands to run successfully when depot_tools is
installed in a path containing spaces.

Change-Id: I8f99dbdcb3b1acf27d51ce26b6153f643b8d4dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2127675
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 2020-03-30 19:06:13 +00:00
Peter Kasting
115b717935 Escape forward slash to avoid undesired path conversion in Git 2.24.1(2). 
Bug: none
Change-Id: I8fe6e68ab93025b461722fc6ce43274c091902e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1963407
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 2019-12-17 17:36:22 +00:00
Edward Lemur
9577daf667 depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 
pythond and python3 are still downloaded from cipd, but python3 is no longer shim'd into
depot_tools on Linux, so is not available on PATH.
Modify PATH in vpython and vpython3 on Linux to point to the python3 download directory,
so that the version downloaded from cipd is used.

Bug: 1017812
Change-Id: I70bc8e7d460f60dcbfa5e141127edecfc2b44744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1893982
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
 2019-11-12 18:05:55 +00:00
Edward Lemur
24995256ee Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 
Don't call ensure_bootstrap from update_depot_tools.
ensure_bootstrap also updates gsutil and all versions of pylint
which is slow, particularly on MinGW.

Original change's description:
> depot_tools: Bootstrap Python 3 on Linux/Mac
>
> This will make it possible for developers to execute depot_tools
> scripts using Python 3 in a known environment.
>
> Bug: 1002153
> Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

Bug: 1002153
Change-Id: Ia7579e440438897ba4a7c65a8b228dcfe7f28c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1810040
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-09-18 18:31:07 +00:00
Edward Lemur
f73f0f401a Revert "Reland "depot_tools: Bootstrap Python 3 on Linux/Mac"" 
This reverts commits 0e85f633c7 and 9d25ad4192.

Reason for revert:

Causes problems for MinGW users.

Original change's description:
> Reland "depot_tools: Bootstrap Python 3 on Linux/Mac"
>
> This is a reland of dbca865e55
>
> Original change's description:
> > depot_tools: Bootstrap Python 3 on Linux/Mac
> >
> > This will make it possible for developers to execute depot_tools
> > scripts using Python 3 in a known environment.
> >
> > Bug: 1002153
> > Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
>
> Bug: 1002153
> Change-Id: I6938a76ffa05366c21f7c56aed3d07ecb2b84443
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1798845
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1002153
Change-Id: I3ee87b95b2532ec694d7f4f87cce8cde8ccf86eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1808137
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-09-16 22:23:45 +00:00
Edward Lemur
9d25ad4192 depot_tools: Fix update_depot_tools for Windows on MinGW 
Bug: 1002153
Change-Id: I518073646a6c1d4e6077adf2f717008ed9972b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1803481
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-09-13 20:15:12 +00:00
Edward Lemur
0e85f633c7 Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 
This is a reland of dbca865e55

Original change's description:
> depot_tools: Bootstrap Python 3 on Linux/Mac
> 
> This will make it possible for developers to execute depot_tools
> scripts using Python 3 in a known environment.
> 
> Bug: 1002153
> Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

Bug: 1002153
Change-Id: I6938a76ffa05366c21f7c56aed3d07ecb2b84443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1798845
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-09-11 22:20:27 +00:00
Edward Lesmes
cc6f585f05 Revert "depot_tools: Bootstrap Python 3 on Linux/Mac" 
This reverts commit dbca865e55.

Reason for revert:

Fails on Mac

$ gclient sync --with_branch_heads
awk: syntax error at source line 1
 context is
	match($0, >>>  /cpython3\/.*version:([.0-9a-zA-Z]+)/, <<<
awk: bailing out at source line 1
Could not extract Python 3 version from manifest.


Original change's description:
> depot_tools: Bootstrap Python 3 on Linux/Mac
> 
> This will make it possible for developers to execute depot_tools
> scripts using Python 3 in a known environment.
> 
> Bug: 1002153
> Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

TBR=iannucci@chromium.org,dpranke@chromium.org,tandrii@google.com,ehmaldonado@chromium.org

Change-Id: I8e03a9e22655491d0f8e8d214d04ba749c2ab8ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1797197
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2019-09-11 01:44:09 +00:00
Edward Lemur
dbca865e55 depot_tools: Bootstrap Python 3 on Linux/Mac 
This will make it possible for developers to execute depot_tools
scripts using Python 3 in a known environment.

Bug: 1002153
Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 2019-09-10 21:34:48 +00:00
Edward Lemur
fedbb7dc89 update_depot_tools: Use git checkout -q origin/master 
Bug: 996359
Change-Id: I7c87fd824103c91c1dd5b9b8975354732e5eb0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765839
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2019-08-22 21:00:13 +00:00
Edward Lemur
7f90416c08 depot_tools: Use git-checkout instead of git-rebase. 
Changes like crrev.com/c/1752507, where a file that was previously in
.gitignore becomes part of the repo, makes update_depot_tools fail
to rebase.

Use git checkout origin/master instead.

Bug: 996359
Change-Id: Ib1a43b8842cebce96ab1fabaedc8e5653b9a708e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764708
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2019-08-22 17:57:25 +00:00
John Barboza
9fa97b59b1 fix fetch on aix 
The `find` utility does not support iname option. Use grep to work
around this limitation.

Change-Id: Iee16def0e4eea8b868c4f3aad164caa0bd7e9d5d
Reviewed-on: https://chromium-review.googlesource.com/1106651
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
 2018-07-23 16:17:22 +00:00
Paweł Hajdan Jr.
2892e17932 Revert "update_depot_tools: make cipd_bin_setup failures fatal" 
This reverts commit bfa05c838c.

Reason for revert: breaks bot bootstrap

Original change's description:
> update_depot_tools: make cipd_bin_setup failures fatal
> 
> This should make them more noticeable.
> 
> Bug: 762568
> Change-Id: Ibd4ca4dc34d36aec5773d28454d134c909cc78dc
> Reviewed-on: https://chromium-review.googlesource.com/653157
> Reviewed-by: Daniel Jacques <dnj@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

TBR=phajdan.jr@chromium.org,dnj@chromium.org

Change-Id: I14e8aae77beca52ebbd21567e2ea20954e2b34d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762894, 762568
Reviewed-on: https://chromium-review.googlesource.com/654977
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
 2017-09-07 11:26:05 +00:00
Pawel Hajdan, Jr
bfa05c838c update_depot_tools: make cipd_bin_setup failures fatal 
This should make them more noticeable.

Bug: 762568
Change-Id: Ibd4ca4dc34d36aec5773d28454d134c909cc78dc
Reviewed-on: https://chromium-review.googlesource.com/653157
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
 2017-09-07 08:52:12 +00:00
Dirk Pranke
ecdfa41dc8 Fix quoting in update_depot_tools. 
The update_depot_tools script had a line where a call out
to the test operator ([]) wasn't quoting all of the arguments,
leading to errors if a directory had spaces in the name.

R=dnj@chromium.org, phajdan.jr@chromium.org

Bug:
Change-Id: Ie1f5f51891a2582614ed3d9b16375d2ad522360b
Reviewed-on: https://chromium-review.googlesource.com/598427
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>
 2017-08-02 16:33:52 +00:00
Dan Jacques
5aeeb72c33 [bootstraps] Sync at gclient, suppress output (#2) 
Have the "update_depot_tools" script also do a CIPD tool sync. This will
ensure that users and systems have access to tooling at sync-time rather
than just-in-time loading them at execution time.

Update the tool boostraps to suppress any sort of syncing logs, if it
does happen. This will ensure that users who execute the tools don't see
unexpected output.

BUG=chromium:748651
TEST=local
  - Tested on Mac and Windows.

Change-Id: I1aad897d885a07beeac40a372a658681720efd2a
Reviewed-on: https://chromium-review.googlesource.com/591229
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2017-07-28 13:33:40 +00:00
Dirk Pranke
44855b9498 Revert "[bootstraps] Sync at gclient, suppress output." 
This reverts commit 4d92fe4300.

Reason for revert: This moved the logging from invoking `led` or `vpython` to whenever someone would run something that would end up invoking `update_depot_tools`. It's good that we are calling this when we run update_depot_tools, but we probably should've suppressed the logging there in at least the success case, because now things are even more confusing. See crbug.com/748651.

Original change's description:
> [bootstraps] Sync at gclient, suppress output.
> 
> Have the "update_depot_tools" script also do a CIPD tool sync. This will
> ensure that users and systems have access to tooling at sync-time rather
> than just-in-time loading them at execution time.
> 
> Update the tool boostraps to suppress any sort of syncing logic, if it
> does happen. This will ensure that users who execute the tools don't se
> unexpected output.
> 
> BUG=None
> TEST=local
>   - Tested on Mac and Windows.
> 
> R=​dpranke@chromium.org, iannucci@chromium.org
> 
> Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843
> Reviewed-on: https://chromium-review.googlesource.com/581494
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,dnj@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I2485c9dd2e48a8dbdeebfff5da9d4c708e0edcb7
Reviewed-on: https://chromium-review.googlesource.com/585867
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
 2017-07-26 02:33:01 +00:00
Dan Jacques
4d92fe4300 [bootstraps] Sync at gclient, suppress output. 
Have the "update_depot_tools" script also do a CIPD tool sync. This will
ensure that users and systems have access to tooling at sync-time rather
than just-in-time loading them at execution time.

Update the tool boostraps to suppress any sort of syncing logic, if it
does happen. This will ensure that users who execute the tools don't se
unexpected output.

BUG=None
TEST=local
  - Tested on Mac and Windows.

R=dpranke@chromium.org, iannucci@chromium.org

Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843
Reviewed-on: https://chromium-review.googlesource.com/581494
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 2017-07-24 18:32:30 +00:00
Dan Jacques
13f258bf05 Remove SVN bootstrapping and some tooling. 
Remove Windows SVN bootstrapping and some SVN tooling. Since
"depot_tools" is no longer sync'd to SVN, and we have been committed to
Git for years now, this is obsolete. Any transition code will never
reach SVN users, and any remaining code should not be used by Chromium
developers.

BUG=chromium:630904
TEST=unit

Change-Id: Ie984e8400a748702b125eaeed8157719ef4b88cc
Reviewed-on: https://chromium-review.googlesource.com/562748
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
 2017-07-07 21:21:32 +00:00
Dan Jacques
74d7e13315 [auto_update] Add control script, allow disable. 
Enable a sentinel file to enable/disable "depot_tools" auto-updating.
This file, if present, indicates that automatic updating should not
occur.

Add a simple control script to enable/disable automatic updating.

BUG=chromium:727917
TEST=local
  - Ran locally, --enable, --disable.

R=iannucci@chromium.org, maruel@chromium.org, nodir@chromium.org

Change-Id: Id30a17586248228849d046f79d7e0bc445d97f97
Reviewed-on: https://chromium-review.googlesource.com/521884
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
 2017-06-01 22:21:25 +00:00
Aaron Gable
a0e5cc40f0 Remove SVN code from update_depot_tools 
R=maruel@chromium.org
BUG=600446

Review URL: https://codereview.chromium.org/2088653003 .
 2016-06-21 07:22:18 -07:00
agable@chromium.org
17c4771ea6 Add warnings to SVN update_depot_tools 
R=iannucci@chromium.org
BUG=600446

Review URL: https://codereview.chromium.org/2000913002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300660 0039d316-1c4b-4281-b951-d872f2087c98
 2016-05-23 23:53:44 +00:00
iannucci@chromium.org
3466b0d6a6 Make msys depot_tools upgrade process smoother. 
R=agable@chromium.org, dnj@chromium.org, mmoss@chromium.org
BUG=600028

Review URL: https://codereview.chromium.org/1848353003 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299677 0039d316-1c4b-4281-b951-d872f2087c98
 2016-04-04 19:50:20 +00:00
iannucci@chromium.org
cf231ddddb Add warning when running gclient under MSYS shell. 
R=dnj@chromium.org, pkasting@chromium.org
BUG=598941

Review URL: https://codereview.chromium.org/1847433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299559 0039d316-1c4b-4281-b951-d872f2087c98
 2016-03-30 02:45:15 +00:00
iannucci@chromium.org
02ef57e288 Make git binary tools auto update on mingw 
R=dnj@chromium.org, pkasting@chromium.org
BUG=598941

Review URL: https://codereview.chromium.org/1845493003 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299556 0039d316-1c4b-4281-b951-d872f2087c98
 2016-03-30 01:46:41 +00:00
sergiyb@chromium.org
150aa7b955 Re-land: Removed virtualenv from depot_tools 
Original CL: https://codereview.chromium.org/1437483002/.

R=dnj@google.com, tandrii@chromium.org, dnj@chromium.org, pgervais@chromium.org
BUG=542922, 503067

Review URL: https://codereview.chromium.org/1407953011 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297494 0039d316-1c4b-4281-b951-d872f2087c98
 2015-11-09 19:20:55 +00:00
dnj@google.com
16ab651b2d Revert of Removed virtualenv from depot_tools (patchset #1 id:1 of https://codereview.chromium.org/1437483002/ ) 
Reason for revert:
This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this.

update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems.

I'm reverting to restore the toolchain so we can create new Windows bots.

Original issue's description:
> Removed virtualenv from depot_tools
>
> This effectively reverts http://crrev.com/1195423002 and
> http://crrev.com/1205873002.
>
> R=pgervais@chromium.org, tandrii@chromium.org
> TBR=pgervais@chromium.org  # i wanna get my Fixit credit today :-)
> BUG=542922,503067
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491

TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542922,503067

Review URL: https://codereview.chromium.org/1431173002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297493 0039d316-1c4b-4281-b951-d872f2087c98
 2015-11-09 18:49:41 +00:00
sergiyb@chromium.org
9ca2fc13f9 Removed virtualenv from depot_tools 
This effectively reverts http://crrev.com/1195423002 and
http://crrev.com/1205873002.

R=pgervais@chromium.org, tandrii@chromium.org
TBR=pgervais@chromium.org  # i wanna get my Fixit credit today :-)
BUG=542922,503067

Review URL: https://codereview.chromium.org/1437483002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297491 0039d316-1c4b-4281-b951-d872f2087c98
 2015-11-09 15:44:47 +00:00
sky@chromium.org
02ad753f56 Adds -f when rm'ing pyc files 
Without this I get prompted if I really want to remote the file.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1332303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296651 0039d316-1c4b-4281-b951-d872f2087c98
 2015-09-11 17:04:32 +00:00
pkasting@chromium.org
4845f0ed69 Fix slash direction: paths in msysgit use /, not \. 
BUG=none
TEST=update_depot_tools actually works in msysgit

Review URL: https://codereview.chromium.org/1208053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295866 0039d316-1c4b-4281-b951-d872f2087c98
 2015-06-29 22:54:58 +00:00
sergiyb@chromium.org
568dbd8440 Re-land: Added virtualenv for depot_tools 
Original CL: https://chromiumcodereview.appspot.com/1200843003/

R=pgervais@chromium.org
BUG=503067
TEST=tested on Mac, Windows and Linux bots

Review URL: https://codereview.chromium.org/1205873002.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295842 0039d316-1c4b-4281-b951-d872f2087c98
 2015-06-25 18:08:45 +00:00
akuegel@chromium.org
39a23508dc Revert of Added virtualenv for depot_tools (patchset #10 id:180001 of https://chromiumcodereview.appspot.com/1200843003/) 
Reason for revert:
Doesn't work, virtualenv is missing in depot_tools checkout.

Original issue's description:
> Added virtualenv for depot_tools
>
> R=pgervais@chromium.org
> BUG=503067
> TEST=tested on Mac, Windows and Linux bots
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295811

TBR=pgervais@chromium.org,sergiyb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=503067

Review URL: https://codereview.chromium.org/1202843005.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295813 0039d316-1c4b-4281-b951-d872f2087c98
 2015-06-24 08:50:41 +00:00
sergiyb@chromium.org
b3bae3748a Added virtualenv for depot_tools 
R=pgervais@chromium.org
BUG=503067
TEST=tested on Mac, Windows and Linux bots

Review URL: https://codereview.chromium.org/1200843003.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295811 0039d316-1c4b-4281-b951-d872f2087c98
 2015-06-24 05:23:07 +00:00
sergiyb@chromium.org
48d661e723 Added an env variable to hide "Depot tools has been updated..." message 
This is needed to prevent auto_deploy.py in CQ send alert each time depot_tools
get's updated as cron job will send alert on any output.

R=stip@chromium.org
CC=akuegel@chromium.org
BUG=475049

Review URL: https://codereview.chromium.org/1073113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294778 0039d316-1c4b-4281-b951-d872f2087c98
 2015-04-13 14:03:53 +00:00
pkasting@chromium.org
884b52c122 Use grep -e --force instead of grep "--force" since apparently the latter doesn't work properly in all cases. 
BUG=441072
TEST=No errors from gclient :/

Review URL: https://codereview.chromium.org/802513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293380 0039d316-1c4b-4281-b951-d872f2087c98
 2014-12-12 19:26:49 +00:00
pkasting@chromium.org
7f2720b72a Avoid =~ since msysgit bash doesn't support it. 
This uses grep instead.  Note that just grepping for "--force" matches other
things, e.g. "foo--force--foo", but that's a problem with the original code as
well, I think.

BUG=435729
TEST=Run gclient under msysgit bash.  No error should occur.

Review URL: https://codereview.chromium.org/789353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293340 0039d316-1c4b-4281-b951-d872f2087c98
 2014-12-10 23:29:25 +00:00
agable@chromium.org
69b67588c4 Run "svn revert" in update_depot_tools --force 
R=iannucci@chromium.org, szager@chromium.org, pdr@chromium.org
BUG=435729

Review URL: https://codereview.chromium.org/756233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293112 0039d316-1c4b-4281-b951-d872f2087c98
 2014-11-25 23:34:41 +00:00
szager@chromium.org
83f4767a60 Update to git-1.9.0. 
Also, allow multiple git installations to exist side-by-side.
This makes it easier to revert back to an old version quickly.

BUG=
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/203463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258058 0039d316-1c4b-4281-b951-d872f2087c98
 2014-03-19 19:22:08 +00:00
mmoss@chromium.org
3b16a28565 More fixes for hardcoded git directory paths. 
The git path is based on the git version, so it might change whenever git is
updated. Run git.bat instead, since that's updated with new git installs and
should always point to the right path.

The mingw logic is based on similar handling of python.bat in git-cl.

Review URL: https://codereview.chromium.org/166273024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252584 0039d316-1c4b-4281-b951-d872f2087c98
 2014-02-21 17:20:58 +00:00
pkasting@chromium.org
682d0d7378 Update update_depot_tools to always check out Windows tools on Cygwin. 
This is necessary so that Cygwin users have a python directory in depot_tools/,
which will soon be used by gyp_chromium.

BUG=335180

Review URL: https://codereview.chromium.org/141523009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245704 0039d316-1c4b-4281-b951-d872f2087c98
 2014-01-18 01:28:49 +00:00
rnk@chromium.org
6911307d2d Revert of Fetch Windows tools on Cygwin and use that Python for some scripts (https://codereview.chromium.org/140843004/) 
Reason for revert:
This broke auto-updating depot_tools on Cygwin due to use of exec

Original issue's description:
> Fetch Windows tools on Cygwin and use that Python for some scripts
> 
> Tested by running gclient sync a couple of times from a Cygwin shell.
> 
> R=dpranke@chromium.org
> CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org
> BUG=335180
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245315

TBR=dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=335180

Review URL: https://codereview.chromium.org/132883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245330 0039d316-1c4b-4281-b951-d872f2087c98
 2014-01-16 21:35:01 +00:00
rnk@chromium.org
a957e27dc1 Fetch Windows tools on Cygwin and use that Python for some scripts 
Tested by running gclient sync a couple of times from a Cygwin shell.

R=dpranke@chromium.org
CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org
BUG=335180

Review URL: https://codereview.chromium.org/140843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245315 0039d316-1c4b-4281-b951-d872f2087c98
 2014-01-16 20:59:47 +00:00
stuart@fivemicro.com
4fa02461be Don't update git url if 'read' times out 
Previous code checked the exit status of 'echo' instead of 'read' to
determine if the 'read' command had timed out.

TEST=Create a mirror of depot_tools.git, git clone it, then run
./update_depot_tools, see prompt for changing the URL, wait at
least 60 seconds and verify that you get the timeout message.

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/25110004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227427 0039d316-1c4b-4281-b951-d872f2087c98
 2013-10-08 01:50:18 +00:00