Junji Watanabe
8479869311
Revert "[siso] Limit remote jobs on Windows to 1000"
...
This reverts commit 7ababdfe02https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5482550
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
> Commit-Queue: Junji Watanabe <jwata@google.com >
> Auto-Submit: Junji Watanabe <jwata@google.com >
> Reviewed-by: Fumitoshi Ukai <ukai@google.com >
Bug: b/335525655, b/336481263
Change-Id: I911376d3ef3c7482fad4231db06c0dd1a0f1ab28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5534440
Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
Commit-Queue: Junji Watanabe <jwata@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
2024-05-14 01:57:52 +00:00
Junji Watanabe
7ababdfe02
[siso] Limit remote jobs on Windows to 1000
...
Until we fix slow Window builds on developer machine,
It would probably be better to limit remote jobs to 1000.
Bug: b/335525655, b/336481263
Change-Id: I065e19480a27203da2b32ceb19050d0846fbc554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5482550
Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
Commit-Queue: Junji Watanabe <jwata@google.com >
Auto-Submit: Junji Watanabe <jwata@google.com >
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
2024-05-02 06:00:45 +00:00
Junji Watanabe
9ed72f91a9
[siso] Propagte SIGINT to siso process
...
siso's signal handler doesn't run as expected with siso/autosiso
wrappers.
This CL sets signal handlers for the Python wrappers to propagate
signals to siso.
Note that Siso immediately exists at the 2nd Ctrl-C.
So developers can stop Siso forcibly when they want.
Bug: b/308734805
Change-Id: Idd8cc1d99931d609cfc3bedfb4c0bb4319cd20b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4996768
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
Commit-Queue: Junji Watanabe <jwata@google.com >
2023-11-01 09:13:25 +00:00
Ben Segall
1077fbe08a
[reclient] Only show shutdown msg if ctrl-C end the build
...
Bug: b/300284667
Change-Id: I28151a974cd20cb5ec7a789cf7f7cd0c926b4486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4864734
Reviewed-by: Junji Watanabe <jwata@google.com >
Commit-Queue: Ben Segall <bentekkie@google.com >
Auto-Submit: Ben Segall <bentekkie@google.com >
2023-09-26 13:42:16 +00:00
Ben Segall
b64ee7f525
[reclient] Add hostname to invocation ids
...
This is already covered in the PDD for googlers. We are already gathering hostnames in cloud monitoring mertrics
Bug: b/294945709
Change-Id: Idfb5b8d3b7cf64edd60092f6bd49a3f9f1950d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4848094
Reviewed-by: Takuto Ikuta <tikuta@chromium.org >
Commit-Queue: Ben Segall <bentekkie@google.com >
2023-09-07 15:11:31 +00:00
Mike Frysinger
124bb8e53c
switch to 4 space indent
...
Leave the recipes/ code at 2 space to match the rest of the recipes
project in other repos.
Reformatted using:
files=( $(
git ls-tree -r --name-only HEAD | \
grep -Ev -e '^(third_party|recipes)/' | \
grep '\.py$';
git grep -l '#!/usr/bin/env.*python' | grep -v '\.py$'
) )
parallel ./yapf -i -- "${files[@]}"
~/chromiumos/chromite/contrib/reflow_overlong_comments "${files[@]}"
The files that still had strings that were too long were manually
reformatted because they were easy and only a few issues.
autoninja.py
clang_format.py
download_from_google_storage.py
fix_encoding.py
gclient_utils.py
git_cache.py
git_common.py
git_map_branches.py
git_reparent_branch.py
gn.py
my_activity.py
owners_finder.py
presubmit_canned_checks.py
reclient_helper.py
reclientreport.py
roll_dep.py
rustfmt.py
siso.py
split_cl.py
subcommand.py
subprocess2.py
swift_format.py
upload_to_google_storage.py
These files still had lines (strings) that were too long, so the pylint
warnings were suppressed with a TODO.
auth.py
gclient.py
gclient_eval.py
gclient_paths.py
gclient_scm.py
gerrit_util.py
git_cl.py
presubmit_canned_checks.py
presubmit_support.py
scm.py
Change-Id: Ia6535c4f2c48d46b589ec1e791dde6c6b2ea858f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4836379
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org >
Auto-Submit: Mike Frysinger <vapier@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org >
2023-09-06 05:48:55 +00:00
Junji Watanabe
ce3e819465
[autosiso] Add single file compile support on Windows
...
'^' needs to be preserved for single file compile on Windows.
```
PS C:\src\chromium\src> autosiso -C out/rbe ../../base/version.cc^^
Proxy started successfully.
loading fs state...done 499.1µs
update filegroups... 0s
loading build.ninja...done 3.3774184s
run:111+0 pure:857 cache:498 fallback:0 skip:0
deps log:0 logErr:0 scanErr:0
resource/capa used(err) wait-avg | s m | serv-avg | s m |
file-digest/64 3390(9) 0s |█ | 2ms |█▂▂ |
fork/64 111(0) 0s |█ | 32ms |▄█▂ |
fs-flush/128 300(0) 0s |█ | 10ms |█▃▂ |
localexec/64 111(0) 0s |█ | 565ms | █▂ |
preproc/65536 609(0) 0s |█ | 0s |█ |
reproxyexec/5120 498(0) 0s |█ | 2.734s | ▂▆█ |
scandeps/256 9(0) 0s |█ | 0s |█ |
Build Succeeded: 857 steps in 16.563s
Shutting down reproxy...
RBE Stats: ↓ 43.06 MB, ↑ 0 B, 498 cache hits
```
Bug: b/289309062
Change-Id: I1044ed372006928f043b4b8404ba9364a7a1047c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4751319
Auto-Submit: Junji Watanabe <jwata@google.com >
Commit-Queue: Junji Watanabe <jwata@google.com >
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
2023-08-04 07:00:12 +00:00
Ben Segall
e49349becf
Mark reclient build metrics with the tool that started reclient
...
This will allow us to segment siso and ninja metrics for analysis
Bug: b/281504726
Change-Id: If45b272004b236d634c717ea9e28e38e49c6231a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4568610
Commit-Queue: Ben Segall <bentekkie@google.com >
Auto-Submit: Ben Segall <bentekkie@google.com >
Reviewed-by: Junji Watanabe <jwata@google.com >
2023-06-01 02:54:56 +00:00
Junji Watanabe
3a5cc40813
[autosiso] Do not double quote arguments on Windows.
...
The double quotations are necessary to preserve "^" for Ninja's single file compilation.
But Siso doesn't support this syntax for now.
Bug: b/270653823
Change-Id: I9c775ad295119dad3b1ba5aebdccce59127232c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4551121
Auto-Submit: Junji Watanabe <jwata@google.com >
Commit-Queue: Junji Watanabe <jwata@google.com >
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
2023-05-22 04:59:44 +00:00
Junji Watanabe
48fcabef4c
[autosiso] suggest using siso command direclty for non build commands
...
`autosiso` doesn't handle non build commands. e.g. help, version, login
We should encourage users to use `siso` command directly,
and get rid of `autosiso` eventually at some point.
Bug: b/278675516
Change-Id: I651e537d8d03674f5d1996983083e25ab5d149c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4452374
Reviewed-by: Takuto Ikuta <tikuta@chromium.org >
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
Commit-Queue: Junji Watanabe <jwata@google.com >
2023-04-21 01:28:51 +00:00
Junji Watanabe
607284d719
[siso] add autosiso wrappers
...
Developers will be able to use `autosiso` command to invoke siso builds.
This CL extracts reclient management logic from `ninja_reclient` to be reused in both Ninja and Siso builds.
Bug: b/278675516
Change-Id: I3e64a3188db184f4d3f851063a0feef7d3a73d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445366
Auto-Submit: Junji Watanabe <jwata@google.com >
Reviewed-by: Philipp Wollermann <philwo@google.com >
Commit-Queue: Joanna Wang <jojwang@chromium.org >
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
Reviewed-by: Takuto Ikuta <tikuta@chromium.org >
Reviewed-by: Joanna Wang <jojwang@chromium.org >
2023-04-20 03:14:52 +00:00
