Alex Ovsienko
4e2be179a1
Enable telemetry flags for Google corp machines only.
...
Bug: b/348530235
Change-Id: I4ac32c60b806f44920bd06e31ec6c3b86a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7104218
Commit-Queue: Alex Ovsienko <ovsienko@google.com >
Reviewed-by: Junji Watanabe <jwata@google.com >
2025-11-09 17:13:31 -08:00
Vadim Shtayura
a8d3023ff0
Update led, bb and luci-auth.
...
To pick up
https://chromium.googlesource.com/infra/luci/luci-go/+/5b5ce41fe
https://chromium.googlesource.com/infra/luci/luci-go/+/b57ee531e
R=iannucci@chromium.org
BUG=b/458128780
Change-Id: I90b3bdbb7c9d6f8606f4bb699fd871724523ea0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7132481
Reviewed-by: Robbie Iannucci <iannucci@google.com >
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org >
2025-11-07 15:18:13 -08:00
Josiah Kiehl
c443d30d39
Suppress stack trace for GitPushError
...
Change-Id: Idcd1cfb41cf1cf9a3bfb252f6a8c109cbce5a5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7132480
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Josiah Kiehl <kiehl@google.com >
2025-11-07 14:49:28 -08:00
recipe-roller
0ffd5ecccf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8698826859196893329
recipe_engine:
2a848d75abchromium-autoroll@skia-public.iam.gserviceaccount.com )
Roll CAS Client from dcfa817da658 to 06992290a173
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia02e2e8a3bbc0fbb6e87d5dd145cf12a040fa217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7132633
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-07 13:12:26 -08:00
Robert Iannucci
471ff28b1b
Roll lucicfg to v1.46.0.
...
This includes a new gitiles-based source for starlark package
dependencies which should be faster in most practical cases than the
git sparse/shallow fetcher implementation.
Relevant changes:
e2e7bba467..cc51376cf8https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7128758
Reviewed-by: Haiyang Pan <hypan@google.com >
Commit-Queue: Robbie Iannucci <iannucci@google.com >
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org >
2025-11-07 10:50:28 -08:00
Aleksei Khoroshilov
c81622f6bf
Fix google-java-format exec when cipd package is not available.
...
Bug: 458101569
Change-Id: Ifcda7d8bf044c4867e2b49a1d9d7b895b43128d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7130803
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Andrew Grieve <agrieve@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
2025-11-07 10:21:25 -08:00
Allen Li
ba27c7d48d
Roll git-credential-luci
...
Pick up some output message updates
Change-Id: Ieee36f09541a5dfa2ccb944f93f67ee94762b80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7123095
Reviewed-by: Gavin Mak <gavinmak@google.com >
Auto-Submit: Allen Li <ayatane@chromium.org >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2025-11-05 18:09:53 -08:00
Allen Li
84cfb15478
git_cl: Add some debug logging for get_cl_statuses
...
Bug: 420961720
Change-Id: I54280c7f3cfd200e02f63c9cedbf95fc393b8b4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7124755
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Allen Li <ayatane@chromium.org >
2025-11-05 16:49:40 -08:00
recipe-roller
87ffdde61b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8698995470171645121
recipe_engine:
434dc62b92mohrr@google.com )
Revert "[engine] Don't catch cancellations in except"
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia9e6f9aa61b13b4887774de2bd6a24bc2538171c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7124754
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-05 16:30:06 -08:00
Allen Li
8132b22e9f
git_auth: Handle netrc files
...
Bug: 454827122
Change-Id: I3d6d28bf9332b47a2c802b08bbeb35c118753c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7122358
Commit-Queue: Allen Li <ayatane@chromium.org >
Reviewed-by: Gavin Mak <gavinmak@google.com >
2025-11-05 15:52:36 -08:00
recipe-roller
48276745be
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699006165392385617
recipe_engine:
b2ab5f39famohrr@google.com )
[engine] Don't catch cancellations in except
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id75f1f741f4a42c70344eea116d49fa522495c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7124753
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-05 13:39:18 -08:00
Congbin Guo
c00550de29
Add infradata/k8s config
...
This CL adds the 'infradata_k8s' configuration to the gclient recipe
module. This allows recipes to easily check out the
infradata/k8s repository.
BUG=b:457877150
TEST=Ran 'recipes.py test train' to update expectations.
Change-Id: I2c2ac0a245b6ee8bfe1dc72b923a42242c720a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7122241
Auto-Submit: Congbin Guo <guocb@chromium.org >
Commit-Queue: Yiwei Zhang <yiwzhang@google.com >
Reviewed-by: Yiwei Zhang <yiwzhang@google.com >
2025-11-05 08:54:26 -08:00
recipe-roller
e38a4c4abf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699095503924713553
recipe_engine:
de3092e8a9mohrr@google.com )
[random] Change to new props
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01d161cce72aa308548f3a2189e5705e6c092371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7121043
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-04 14:01:23 -08:00
recipe-roller
279ef7afc6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699101796242136449
recipe_engine:
e1055ff7b1mohrr@google.com )
[properties] Deprecate old-style properties
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I08ed8ece37e99876be9f5f9d7ca86c71d4faa540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7121040
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-04 12:23:33 -08:00
Jiewei Qian
240cd02c29
reauth: implement GitCreds credential pre-flight checks
...
This CL implements ensure_authenticated() for GitCredsAuthenticator, and
adds ReAuth support.
This check performs best-effort credential checks before performing
expensive operations such as presubmit hooks. This allows us to fail fast when an ReAuth token is missing for a contributor subject to
ReAuth requirements.
If you suspect this CL has caused a breakage on CL upload, please
revert.
Bug: 451651615
Change-Id: I42f3ffe3c830ed7bd2322f6cf2ad8adbba7e7251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7036772
Reviewed-by: Allen Li <ayatane@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Jiewei Qian <qjw@chromium.org >
2025-11-04 11:38:19 -08:00
Jiewei Qian
5567ad1ea0
gerrit_util: add ReAuth support to ensure_authenticated
...
This CL makes it possible for ensure_authenticated to check whether
the current credential would satisfy ReAuth requirement.
Right now, only GitCredsAuthenticator performs additional ReAuth
check. For other Authenticator, either ReAuth is not relevant
(e.g. SSO), or not supported or implied (e.g. .gitcookies).
This CL does nothing on its own, because ensure_autheticated with
ReAuth is opt-in. Subsequent CL will update callsites to pass in
ReAuthContext to make the check effective.
Bug: 451651615
Change-Id: Idb1e70c52aaa844e672331fad8d462a2a7577d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7104363
Commit-Queue: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Reviewed-by: Allen Li <ayatane@chromium.org >
2025-11-04 11:21:10 -08:00
Jiewei Qian
1faea18c64
git-cl-test: rename auth parameter to creds
...
This avoids a import name clash in future CLs.
Bug: 451651615
Change-Id: Ie35cbe58f36ec98b33c48a70e61a2678a9ce52db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7104382
Auto-Submit: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Allen Li <ayatane@chromium.org >
Commit-Queue: Scott Lee <ddoman@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
2025-11-04 11:05:03 -08:00
recipe-roller
40baf948a5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699174148039576881
recipe_engine:
0484faa783mohrr@google.com )
[third_party] Run update.py
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I94cd4a2747f7390a14ba491d7ddad8916d6edc5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7115703
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-03 17:09:15 -08:00
recipe-roller
f8d59a615c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699181067711308241
recipe_engine:
18b950f51cmohrr@google.com )
[engine] Switch from future.utils.raise_() to raise
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5eba79ba6a536c9f9554443bfe15067fc6146f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7114822
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-03 15:24:01 -08:00
recipe-roller
6977666501
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699187988077706017
recipe_engine:
056ca0c61emohrr@google.com )
[recipe_deps] Remove unused transitive_DEPS
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3355bec44cbc1b1788b0c002c5b674b271d07b85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7114358
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-11-03 13:30:15 -08:00
Joey Scarr
2116e04d5b
Allow webrtc.org accounts to use SSO.
...
Bug: 456675466
Change-Id: I1c10c1cf8d0980c4b18432c3b08f1e4a88c0d960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7110959
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Allen Li <ayatane@chromium.org >
Reviewed-by: Jiewei Qian <qjw@chromium.org >
2025-11-03 12:52:26 -08:00
Milad Fa
a4fa14bf0d
remove ppc and s390 from the host_arch list
...
We only support ppc64 and s390x.
Change-Id: I1ec46bbfc0bdd266b84336e5af46b0503efd4751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7100932
Auto-Submit: Milad Farazmand <mfarazma@ibm.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Reviewed-by: Brian Ryner <bryner@google.com >
2025-11-03 09:28:07 -08:00
recipe-roller
ef1d5129a3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699461038137863041
recipe_engine:
8cfa1f1ddbtbain@google.com )
Tweaked description of query expansion
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I20d41cc50b5920ed448eb975b72a4e33d30f8408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7107282
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-31 14:09:09 -07:00
recipe-roller
2d3d65c04b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699542198291193681
recipe_engine:
541163e264iannucci@chromium.org )
[TurboCI] First whack at the docs.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I310358b44cd51f8703d812a0e1a7a3994cb28daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7104118
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-30 16:40:15 -07:00
recipe-roller
e09450e281
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699543455362850225
recipe_engine:
04211ee3ffiannucci@chromium.org )
Fixes missed in previous CL
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8c844455b6eecc1c09a77b478ae2182cd78811d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7103943
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-30 16:21:12 -07:00
Terrence Reilly
b5b450d56c
Add mimetype for .gn files in the context of presubmits.
...
".gn" was not a recognized extension for the `mimetypes.guess_type` function. As a result, files like "BUILD.gn" weren't added to affected files, and so some presubmits fail. (Specifically, the presubmit which requires new header files to be added to a BUILD.gn file.)
Bug: b:456124666
Change-Id: I38c4d8007e242acd218cf130d3b81d71b0c189ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7102959
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Terrence Reilly <treilly@google.com >
2025-10-30 14:32:55 -07:00
recipe-roller
bc986156d2
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699551004483821857
recipe_engine:
b262ffa447iannucci@chromium.org )
[TurboCI] Import latest protos.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6ac07e3d7d1f9e2baccbb5370a62ff6bdd2995ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7103379
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-30 14:21:13 -07:00
Andrew Grieve
33744dc6bc
Make google-java-format easier to use for non-chromium checkouts like R8
...
1. Use "codereview.settings" in addition to "buildtools" as the marker
that identifies a project root.
2. Allow the presence of any .jar file to indicate the availability of
google-java-format.
3. Do not pass --aosp when running google-java-format
Bug: 456461246
Change-Id: Id27b3c03f592a0ed73fb7a6b4dd662707a649166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7102758
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Andrew Grieve <agrieve@chromium.org >
2025-10-30 12:05:33 -07:00
Garrett Beaty
251779412a
Add pyproject.toml
...
This will enable pyright and IDEs that use pyright configuration (e.g.
vscode) to correctly dereference and type-check imports provided by
the recipe engine. The user may need to fetch the most recent version
of the recipe dependencies by running "recipes.py fetch".
Change-Id: I11b882152e0778a32d6e72e54cacde88ab0a0ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7100709
Commit-Queue: Scott Lee <ddoman@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Garrett Beaty <gbeaty@google.com >
Auto-Submit: Garrett Beaty <gbeaty@google.com >
2025-10-30 11:29:41 -07:00
recipe-roller
813839a743
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699562958603852401
recipe_engine:
a7ad338e9cgbeaty@chromium.org )
Annotate ModuleInjectionSite.__getattr__ to remove spurious err...
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I65e470800c451f5ac290c33cb2632cb4ec32922d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7102410
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-30 11:14:42 -07:00
Jiewei Qian
1a4ea22863
Roll git-credential-luci
...
This roll includes cache lifetime and cache invalidation fixes for
multiple issues.
Bug: 451651615, 455765072
Change-Id: Id8899007e5ac6739b437fb1d363588a5b37dd69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7099201
Reviewed-by: Chenlin Fan <fancl@chromium.org >
Commit-Queue: Chenlin Fan <fancl@chromium.org >
Auto-Submit: Jiewei Qian <qjw@chromium.org >
2025-10-30 03:16:28 -07:00
Garrett Beaty
117ee16204
Remove obsolete forbidden warning.
...
The recipe_engine repo no longer generates the STEP_NEST_NAME_REQUIRED
warning, this will remove output to that effect when running the recipe
tests in this repo.
Change-Id: I0da120b522c9388180771f7c28b3fe17492e0035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7099000
Reviewed-by: Yiwei Zhang <yiwzhang@google.com >
Auto-Submit: Garrett Beaty <gbeaty@google.com >
Commit-Queue: Yiwei Zhang <yiwzhang@google.com >
2025-10-29 22:25:50 -07:00
Garrett Beaty
6fe43bc8d7
Remove obsolete warning declaration.
...
crrev.com/c/5534148 removed the presentation and json
backwards-compatibility attributes from the bot_update Result object,
but neglected to remove the warning declaration and a couple ignore
instances. The warning serves no purpose now, so this removes the
declaration.
Bug: 339472834
Change-Id: I0ff7e5d7699f00d9a78157060224b36f62cde408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7098999
Reviewed-by: Yiwei Zhang <yiwzhang@google.com >
Auto-Submit: Garrett Beaty <gbeaty@google.com >
Commit-Queue: Yiwei Zhang <yiwzhang@google.com >
2025-10-29 22:25:32 -07:00
Junji Watanabe
45aaf4f713
autoninja: Stop reading use_reclient_on_{siso, ninja} default values
...
Reclient is being removed from Chromium.
Siso/Reclient mode shouldn't be used anymore.
Bug: 379584977
Change-Id: I4cbf5f281e0a272b3ade72085f64c91969588bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7099239
Reviewed-by: Fumitoshi Ukai <ukai@google.com >
Commit-Queue: Junji Watanabe <jwata@google.com >
2025-10-29 18:11:02 -07:00
Jiewei Qian
2f32d6a0d5
gerrit_util: extract applicable_authenticators()
...
This CL refactors for loop + inner a.is_applicable() into
a applicable_authenticators() function to reduce code duplication
among ChainAuthenticator methods.
No functional change.
Change-Id: Icfd42ff2c1991847aa0469ee409bc1dc2e770f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7091315
Commit-Queue: Scott Lee <ddoman@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Auto-Submit: Jiewei Qian <qjw@chromium.org >
2025-10-29 11:19:25 -07:00
Jiewei Qian
52dbf26660
git_common: bump minimum git version
...
For ReAuth to work, git must be >=2.46.0. Updating depot_tools check according to:
https://chromium.googlesource.com/chromium/src/+/main/docs/gerrit_reauth.md#latest-git
Change-Id: I95a5bcc336e287d150140d35878ae8521e8817a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7094398
Auto-Submit: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Scott Lee <ddoman@chromium.org >
2025-10-29 11:17:20 -07:00
Gavin Mak
f5117c0007
Make CheckLicense warn locally
...
Only emit errors on standard CQ runs. Keep as warning for local runs to
reduce friction, and for full-tree CI checks to avoid breakage from
legacy files.
Bug: 454681814
Change-Id: I621ecc75cf5df40e4fd33ff439bfdc4f4c62e4fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7092462
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2025-10-29 09:58:56 -07:00
Jiewei Qian
2939175fa6
auth.py: tweak ReAuth required error message
...
Grammar fix.
Change-Id: I3fc2dd3819e0b3d6c30ea11e80d14e2d3dadaf54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7094080
Auto-Submit: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Scott Lee <ddoman@chromium.org >
2025-10-29 09:51:15 -07:00
Jiewei Qian
13828a4918
gerrit_util: add ensure_authenticated to ChainedAuthenticator
...
Implements ensure_authenticated in ChainedAuthenticator to call the
first applicable authenticator.
In addition, makes `GitCredsAuthenticator.is_applicable` work when `gerrit_host` isn't provided, and caches the result to avoid sending
redundant RPCs for the same host.
This change is slightly risky because we'll start exercising
ensure_authenticated code path on different Authenticators. Though
currently, only .gitcookies (CookiesAuthenticator) implements this
check. With newauthstack shipped, CookiesAuthenticator shouldn't be used for normal workflows.
If you suspect this change has caused a breakage, please file a bug and
revert this CL.
Bug: 348024314
Change-Id: I420929bd552d7804d53a5f118f8d8c2d10940480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7065052
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Allen Li <ayatane@chromium.org >
2025-10-28 18:35:43 -07:00
Allen Li
da1bb1b99d
git_auth: Delete unused ConfigChanger
...
All usages have been removed a while ago.
Bug: 446999231
Change-Id: I40de9de7dc027c22652dd45ad75bbba3377bd923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7082062
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Allen Li <ayatane@chromium.org >
2025-10-28 14:00:42 -07:00
Ho Cheung
ac1e4a9bb7
[gsutil] Upgrade to gsutil 5.35 and clarify Python requirements
...
Update gsutil to a newer version to resolve some compatibility issues
with newer Python versions.
And update the README to reflect the new changes.
Bug: 40283283
Change-Id: I1e02c6868e932da0af45a631fc34539c3543868e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7058090
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Ho Cheung <hocheung@chromium.org >
Reviewed-by: Brian Ryner <bryner@google.com >
2025-10-27 16:51:16 -07:00
Gavin Mak
d501813e85
Add --clean-ignored option to bot_update
...
Currently, bot_update.py uses git clean -dff, which leaves ignored
files. This can cause build failures on bisect bots when switching
between different revisions, as stale ignored files from newer revisions
can break older ones.
Add an optional --clean-ignored flag to bot_update. When enabled, it
runs git clean -dffx.
Bug: 454315184
Change-Id: Ia7f0f6a94c78eb335bb1ed291c6d248db899b74d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7087912
Commit-Queue: Gavin Mak <gavinmak@google.com >
Reviewed-by: Scott Lee <ddoman@chromium.org >
2025-10-27 16:06:32 -07:00
Jiewei Qian
e2bb3cd558
tests: refactor CookiesAuthenticator mock
...
This CL refactors _test_gerrit_ensure_authenticated_common by splitting
it into:
- The actual mock and common code path
- Test case specific setup (e.g. scm.GIT.SetConfig)
In addition, fixes a few issues with the existing code:
- _Authenticator.get() is now mocked correctly, so a CookiesAuthenticator
is returned in relevant tests. Previously it returned the "production"
ChainedAuthenticator, which could call other authenticators (such as
GitCredsAuthenticator based on the runtime environment)
- Adds mock patch cleanup functions. Previously, cleanup functions
aren't registered, so the mock leaks and got overwritten by other test
cases.
- Rewrite 'Bearer' in Authorization header check to be more robust.
Previously, the test case raise a KeyError exception when the
Authorization header isn't set at all in request headers.
This is a preparation CL for implementing ensure_authenticated() method
in ChainedAuthenticator and GitCredsAuthenticator in future CLs.
Bug: 348024314
Change-Id: I28a7fabbc6cf2dc33dccc1339b89d20a22dc12ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7082265
Commit-Queue: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
2025-10-27 15:45:01 -07:00
recipe-roller
68c003435f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8699834750517595649
recipe_engine:
51555fa216mohrr@google.com )
[internal] Clarify DEPS errors
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib28959fb3110e8fff87099cd32713937a80bff82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7086010
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-27 11:09:18 -07:00
Jiewei Qian
cd260a79de
git-cl: fix gerrit_host and git_host ordering in ensure_authenticated
...
ensure_authenticated was defined to take gerrit_host then git_host,
but the callsite got it flipped in https://crrev.com/c/5665455
This CL fixes the mistake, and also changed the method signature to
require kwargs argument (and hopefully make it easier to spot and avoid
such mistakes).
Note, this change shouldn't impact normal operation. Only the deprecated
CookiesAuthenticator relies on git_host and gerrit_host, which is not
used when New Auth Stack is enabled.
Bug: 451651615
Change-Id: I8157f3bd4cd51cc78dc4e1c2a917682ced91da86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7077739
Auto-Submit: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
Commit-Queue: Scott Lee <ddoman@chromium.org >
2025-10-23 10:07:32 -07:00
recipe-roller
2b9b70b8b9
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8700203429412136417
recipe_engine:
adc3095a11iannucci@chromium.org )
[TurboCI] Import latest protos.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0f2f6237831cb296e9f48e8dc7ed267bc01e7c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7080575
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-23 09:30:43 -07:00
Jiewei Qian
8a1ec6a021
gerrit_util: replace Optional[conn] with gerrit_host in is_applicable
...
This CL replaces Optional[HttpConn] with gerrit_host, which is the
actual information we need for the check.
This allows us to check without instantiating an actual request (e.g.
for best effort credential checks).
This CL has no functional change.
Bug: 348024314
Change-Id: I14d951fa9c4ebe55718fc8419190547887c0b1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7065051
Commit-Queue: Jiewei Qian <qjw@chromium.org >
Auto-Submit: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Allen Li <ayatane@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
2025-10-22 16:32:35 -07:00
recipe-roller
d4e262a9c5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8700280184226082593
recipe_engine:
0e9e4d0b47iannucci@chromium.org )
[TurboCI] Remove short enum names for enhanced greppability.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I39c0c10f9b0ccf188967652649dfbe83bf809c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7075992
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-22 13:11:53 -07:00
recipe-roller
bafeb2db7a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8700295282398383345
recipe_engine:
c5a9c63baeiannucci@chromium.org )
[TurboCI] Add a mechanism to allow seeding an initial graph sta...
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7763f66048081439559183fc7be811001746bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7074520
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-22 09:10:07 -07:00
recipe-roller
0183dab69e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8700298429910100641
recipe_engine:
c3f3ae5133iannucci@chromium.org )
[TurboCI] Add a post check graph assertion method.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4df5753c59b11d55d51ebfedce324e303cbcba11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7071522
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2025-10-22 08:22:37 -07:00
