Josip Sokcevic
06001cda91
[py2] Drop envvar to run scripts with py2
...
R=aravindvasudev@google.com
Change-Id: I4c2c8265296f8fa1c2ce9a1e4a0b31d1f1dd39f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4522398
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org >
2023-05-11 17:55:43 +00:00
Josip Sokcevic
c621315d17
Make Python 3 default on Windows
...
Users can still set GCLIENT_PY3=0 to use Python 2.
R=ehmaldonado@chromium.org
Change-Id: Ic7657a091bfe3b9c426ab36063b106aadf2d1c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161266
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
2020-04-22 21:08:10 +00:00
Edward Lesmes
df70c81527
depot_tools: Simplify MinGW check.
...
Check `if [[ $(uname -s) = MINGW* ]]` instead of using
grepping and an additional variable.
Change-Id: I6f2cfbb6743357125e6672b77667ee5e36d3d81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2127674
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
2020-03-30 19:27:03 +00:00
Edward Lesmes
17aaea21d4
Reland "depot_tools: Run using Python 3 by default."
...
This reverts commit e2ac022f0b .
git-cache issues were solved by https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2120966
Original change's description:
> Reland "depot_tools: Run using Python 3 by default."
>
> This is a reland of 01ed358917
>
> * python_runner.sh, gclient, roll-dep and fetch will call vpython
> (instead of vpython3) when running on Windows under git-bash.
> * vpython3 now detects when running on Windows under git-bash and
> executes vpython3.bat instead.
> * vpython3.bat calls python3.exe directly instead of calling python3.bat.
>
> Original change's description:
> > depot_tools: Run using Python 3 by default.
> >
> > Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.)
> > using vpython3 by default.
> >
> > Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550
> > Reviewed-by: Anthony Polito <apolito@google.com >
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
>
> Change-Id: I9829141d7ea26a67e655264430151f493e73a930
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2118418
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
> Reviewed-by: Anthony Polito <apolito@google.com >
Change-Id: Iff02533f0a11062f335a010c074043c720d5b2ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2121304
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2020-03-26 16:51:25 +00:00
Josip Sokcevic
e2ac022f0b
Revert "Reland "depot_tools: Run using Python 3 by default.""
...
This reverts commit e9013eeb3d .
Reason for revert: https://crbug.com/1064547
Original change's description:
> Reland "depot_tools: Run using Python 3 by default."
>
> This is a reland of 01ed358917
>
> * python_runner.sh, gclient, roll-dep and fetch will call vpython
> (instead of vpython3) when running on Windows under git-bash.
> * vpython3 now detects when running on Windows under git-bash and
> executes vpython3.bat instead.
> * vpython3.bat calls python3.exe directly instead of calling python3.bat.
>
> Original change's description:
> > depot_tools: Run using Python 3 by default.
> >
> > Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.)
> > using vpython3 by default.
> >
> > Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550
> > Reviewed-by: Anthony Polito <apolito@google.com >
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
>
> Change-Id: I9829141d7ea26a67e655264430151f493e73a930
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2118418
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
> Reviewed-by: Anthony Polito <apolito@google.com >
TBR=ehmaldonado@chromium.org ,ajp@chromium.org ,apolito@google.com ,infra-scoped@luci-project-accounts.iam.gserviceaccount.com ,sokcevic@google.com
Change-Id: Ia382d6e4e330f5a7a7a62e4d369c3fa16fc17333
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2120956
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2020-03-25 16:57:31 +00:00
Edward Lesmes
e9013eeb3d
Reland "depot_tools: Run using Python 3 by default."
...
This is a reland of 01ed358917
* python_runner.sh, gclient, roll-dep and fetch will call vpython
(instead of vpython3) when running on Windows under git-bash.
* vpython3 now detects when running on Windows under git-bash and
executes vpython3.bat instead.
* vpython3.bat calls python3.exe directly instead of calling python3.bat.
Original change's description:
> depot_tools: Run using Python 3 by default.
>
> Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.)
> using vpython3 by default.
>
> Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550
> Reviewed-by: Anthony Polito <apolito@google.com >
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
Change-Id: I9829141d7ea26a67e655264430151f493e73a930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2118418
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
Reviewed-by: Anthony Polito <apolito@google.com >
2020-03-24 22:32:08 +00:00
Peter Kasting
2b2aec6506
Revert "depot_tools: Run using Python 3 by default."
...
This reverts commit 01ed358917 .
Reason for revert: Broke tools on Windows with bash
Original change's description:
> depot_tools: Run using Python 3 by default.
>
> Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.)
> using vpython3 by default.
>
> Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550
> Reviewed-by: Anthony Polito <apolito@google.com >
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
TBR=ehmaldonado@chromium.org ,ajp@chromium.org ,apolito@google.com ,infra-scoped@luci-project-accounts.iam.gserviceaccount.com ,sokcevic@google.com
Change-Id: If29ad72feaa215b8b282f2f6c9911700dd2f228c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116728
Reviewed-by: John Budorick <jbudorick@chromium.org >
Commit-Queue: Peter Kasting <pkasting@chromium.org >
2020-03-24 01:12:08 +00:00
Edward Lemur
01ed358917
depot_tools: Run using Python 3 by default.
...
Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.)
using vpython3 by default.
Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550
Reviewed-by: Anthony Polito <apolito@google.com >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2020-03-23 17:41:56 +00:00
Edward Lemur
4f48924074
roll-dep: Make it possible to run using Python 3.
...
Run roll-dep using Python 3 when GCLIENT_PY3 is set to 1.
Bug: 984182
Change-Id: I511b4cf34b4f5522218a24dff6d0ce9ef5c36c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080614
Reviewed-by: Anthony Polito <apolito@google.com >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2020-02-28 19:37:47 +00:00
Edward Lesmes
7149d23621
Revert "depot_tools: Run Python scripts using vpython (Part 2)"
...
This reverts commit 3c814957ee .
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> depot_tools: Run Python scripts using vpython (Part 2)
>
> Tbr: iannucci@chromium.org
> Bug: 984182
> Change-Id: I2e8469f8ee0acd6a54109697d5a6b76faf24fa42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748590
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
TBR=iannucci@chromium.org ,ehmaldonado@chromium.org
Change-Id: Ic683543a04b45f733b48d6c43453fc8dff511d09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749852
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2019-08-12 21:04:04 +00:00
Edward Lemur
3c814957ee
depot_tools: Run Python scripts using vpython (Part 2)
...
Tbr: iannucci@chromium.org
Bug: 984182
Change-Id: I2e8469f8ee0acd6a54109697d5a6b76faf24fa42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748590
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2019-08-12 19:43:00 +00:00
James Darpinian
f994d87e56
Revert "Reland "depot_tools: Move six to depot_tools' .vpython""
...
This reverts commit d52b306f84 .
Reason for revert: Broke ANGLE CQ with "ImportError: No module named six"
Example: https://ci.chromium.org/p/angle/builders/try/mac-dbg/6758
Original change's description:
> Reland "depot_tools: Move six to depot_tools' .vpython"
>
> This is a reland of 3a98df0bdd
>
> Original change's description:
> > depot_tools: Move six to depot_tools' .vpython
> >
> > Bug: 984182
> > Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org >
> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
> > Reviewed-by: Michael Moss <mmoss@chromium.org >
>
> Bug: 984182
> Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
TBR=iannucci@chromium.org ,mmoss@chromium.org ,tandrii@chromium.org ,ehmaldonado@chromium.org
Change-Id: Id4488249b607441df9f00aa51f4a1f2bc4ad5cfd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739582
Reviewed-by: Kenneth Russell <kbr@chromium.org >
Commit-Queue: Kenneth Russell <kbr@chromium.org >
2019-08-06 18:57:40 +00:00
Edward Lemur
d52b306f84
Reland "depot_tools: Move six to depot_tools' .vpython"
...
This is a reland of 3a98df0bdd
Original change's description:
> depot_tools: Move six to depot_tools' .vpython
>
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org >
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
> Reviewed-by: Michael Moss <mmoss@chromium.org >
Bug: 984182
Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2019-08-06 17:55:59 +00:00
Edward Lesmes
365720e237
Revert "depot_tools: Move six to depot_tools' .vpython"
...
This reverts commit 3a98df0bdd .
Reason for revert:
Can't roll into skia and build_internal
Original change's description:
> depot_tools: Move six to depot_tools' .vpython
>
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org >
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
> Reviewed-by: Michael Moss <mmoss@chromium.org >
TBR=iannucci@chromium.org ,mmoss@chromium.org ,tandrii@chromium.org ,ehmaldonado@chromium.org
Change-Id: I51e502e6f7633a6f26898f1ecbcd86ccf9c7c123
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1718996
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
2019-07-25 20:51:36 +00:00
Edward Lemur
3a98df0bdd
depot_tools: Move six to depot_tools' .vpython
...
Bug: 984182
Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org >
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org >
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Michael Moss <mmoss@chromium.org >
2019-07-25 19:04:34 +00:00
szager@chromium.org
03fd85bd0c
Convenience tool for rolling git-style deps with an svn revision.
...
Usage: roll-dep third_party/WebKit 12345
That will update DEPS with the new revision, and leave the DEPS file
dirty. It's the up to the user to 'git add; git commit;
git cl upload'.
This script won't handle arbitrary python syntax, but it will handle
variable references like Var("webkit_revision") correctly.
R=mmoss@chromium.org , iannucci@chromium.org
BUG=341098
Review URL: https://codereview.chromium.org/318153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@275875 0039d316-1c4b-4281-b951-d872f2087c98
2014-06-09 23:43:33 +00:00