Will Yeager
413ad24ec4
[mac_toolchain] roll mac_toolchain version on osx_sdk recipe module
...
This includes:
- https://crrev.com/c/7224890 Retry adding runtimes after duplicate
- https://crrev.com/c/7225999 Get rid of log spam from running gktool
Bug:462643928
Change-Id: Id9e1d8f41843b9a67fe8004070c31eff263efefb
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_internal
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7226355
Reviewed-by: Yue She <yueshe@google.com >
Commit-Queue: Will Yeager <wyeager@google.com >
2025-12-04 09:15:11 -08:00
Will Yeager
778af1e3b8
Update default mac_toolchain and Xcode versions in osx_sdk recipe module
...
Bug: 461757070
Change-Id: I1fdec68d3e80e3fad065a3c67f2f6776568e05c6
Recipe-Nontrivial-Roll: build_internal
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7171485
Reviewed-by: Lei Zhang <thestig@chromium.org >
Commit-Queue: Will Yeager <wyeager@google.com >
2025-11-19 12:16:13 -08:00
Will Yeager
14f053740d
Add current bling-engprod team members to OWNERS for osx_sdk
...
Change-Id: I7e75667fd1c7c5ce6c08744f201201200d960e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7170014
Commit-Queue: Will Yeager <wyeager@google.com >
Reviewed-by: Garrett Beaty <gbeaty@google.com >
2025-11-19 11:55:07 -08:00
Robert Iannucci
b723b89856
Switch to single-line API/TEST_API definitions.
...
R=mohrr@google.com
Bug: b/446916327
Change-Id: I4fc651325566ffe67956750e35363a6718d9a15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6981222
Reviewed-by: Rob Mohr <mohrr@google.com >
Commit-Queue: Robbie Iannucci <iannucci@google.com >
2025-09-24 16:36:06 -07:00
Rob Mohr
a3fa818db8
recipes: Add API and TEST_API variables
...
These will eventually be required.
Change-Id: If7be1c111c6f9760c38aa512dfa88260379a751f
Bug: b/446916327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6976649
Reviewed-by: Robbie Iannucci <iannucci@google.com >
Commit-Queue: Rob Mohr <mohrr@google.com >
2025-09-24 09:09:35 -07:00
Takuto Ikuta
05cb270161
recipes: Remove unnecessary annotations
...
Python3 is used by default in recipes now and this annotation is not
necessary anymore.
Bug: 440235171
Change-Id: Ifdf357129c9e42fee3752ac1c07aa6e94171d81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6875483
Commit-Queue: Scott Lee <ddoman@chromium.org >
Auto-Submit: Takuto Ikuta <tikuta@chromium.org >
Reviewed-by: Scott Lee <ddoman@chromium.org >
2025-08-25 13:24:00 -07:00
Leonard Grey
b60b40cc31
osx_sdk: Add a default version for macOS 15
...
Bug: 40250422
Change-Id: I90a96592e74380d79382e93797a347814bb0b96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6165750
Reviewed-by: Gavin Mak <gavinmak@google.com >
Reviewed-by: Yue She <yueshe@google.com >
Commit-Queue: Leonard Grey <lgrey@chromium.org >
2025-01-14 11:46:10 -08:00
Rob Mohr
7438a7cd4c
[recipes/*_sdk] Replace '[*]' paths in comments
...
Replace uses of '[START_DIR]' and '[CACHE]' in comments with
api.path.start_dir and api.path.cache_dir. This doesn't actually keep
anything from breaking, but it ensures the comments stay correct.
Change-Id: I4087925a29e3e9a4cb47e044733ab6109cb659bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5492788
Reviewed-by: Yiwei Zhang <yiwzhang@google.com >
Commit-Queue: Yiwei Zhang <yiwzhang@google.com >
Auto-Submit: Rob Mohr <mohrr@google.com >
2024-04-29 16:51:54 +00:00
Rob Mohr
6ba67afd6f
Replace Path.join() with / and Path.joinpath()
...
config_types.Path will soon be replaced with pathlib.Path and
pathlib.Path doesn't have a join() method.
Bug: 329113288
Change-Id: I81bf607ffb41d84928af0eea06be78540b9912d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5467697
Reviewed-by: Yiwei Zhang <yiwzhang@google.com >
Auto-Submit: Rob Mohr <mohrr@google.com >
Commit-Queue: Yiwei Zhang <yiwzhang@google.com >
2024-04-19 23:40:10 +00:00
Rob Mohr
2f8f787dec
Use new path module attributes
...
Bug: 329113288
Change-Id: Ib762c83c7558cd522e6bd3f78e2d38684ce82a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5444201
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
2024-04-11 16:45:46 +00:00
Robert Iannucci
1a776cf430
[osx_sdk] Add TestApi to allow mocking macOS version.
...
Some downstream repos rely on the 'current platform' detection and
would like to mock it in their tests. Give a real API for doing this
instead of having downstream recipes key on the internal step name
here.
R=athom, jeffyoon@google.com , whesse
Change-Id: If9d049c568c70cac9ddee1c06f2bd04ac4f572a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5428682
Reviewed-by: Alexander Thomas <athom@google.com >
Auto-Submit: Robbie Iannucci <iannucci@chromium.org >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2024-04-08 12:38:59 +00:00
danakj
e6aba2bcf1
Update the mac toolchain to 26bb3effce1bc1
...
The list of toolchain hashes is here:
https://chromium.googlesource.com/infra/infra/+log/refs/heads/main/go/src/infra/cmd/mac_toolchain
Bug: chromium: 40284755
Change-Id: I225101faa8236c8c23417239e5682bb9312b8e15
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5428515
Commit-Queue: Gavin Mak <gavinmak@google.com >
Auto-Submit: danakj <danakj@chromium.org >
Reviewed-by: Gavin Mak <gavinmak@google.com >
2024-04-05 16:14:41 +00:00
danakj
7fa774456f
Add the latest Xcode versions for macOS 13.0, 13.5 and 14.0
...
According to https://en.wikipedia.org/wiki/Xcode :
- macOS 13.0 is the minimum macOS version supported by
14E222b and 14E300c
- So we point 13.0 to the latest one, which is 14E300c
- macOS 13.5 is the minimum macOS version supported by
15A240d, 15A507, 15C65, and 15C500b
- So we point it to the latest one, which is 15C500b
- macOS 14.0 is the minimum macOS version supported by
15E5204a (which looks like a typo of 15e204a according
to xcodereleases.com and //infra/config/targets/mixins.star)
- There will surely be more versions that support back
to 14.0 but this is the only one for now. So we point
it 15e204a.
This should hopefully give us C++20 support on macOS 13 and up,
like we see in the Chromium waterfall.
Bug: chromium: 40284755
Change-Id: I2049aa3c4b32990dbedbd95e9ec35cceaa1ca3a3
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425635
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: danakj <danakj@chromium.org >
2024-04-04 22:51:03 +00:00
danakj
8d8494a141
Add Xcode 15.2 (15C500b) for macOS version 14.2
...
This is the Xcode version used in the chromium waterfall:
https://source.chromium.org/chromium/chromium/src/+/main:infra/config/targets/mixins.star;l=1832-1846;drc=d3b83cc14328bf58d20721b78ab3fd4187f52a76
Change-Id: Ia79d8ce713ea2d7a0701d8094001f9173e3466b9
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425390
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: danakj <danakj@chromium.org >
2024-04-04 18:21:32 +00:00
Robert Iannucci
2dbb3f399a
[recipe_modules/osx_sdk] Rewrite osx_sdk module to not rely on platform.mac_release.
...
Since macOS 11, the underlying python `platform.mac_vers()` call
that mac_release is populated from returns "10.16" on all versions
of macOS.
Switch this to just shell out to `sw_vers` to pick up the current
platform version instead.
Non-trivial downstream rolls are because `api.platform.mac_release`
no longer mocks the version of the SDK installed... however it would
be better to set this by just using the explicit sdk_version property.
R=yueshe@google.com
Bug: 331252586
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Change-Id: I41a27383f67db4835ba84b7a47813884879818cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5394351
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
Auto-Submit: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Yue She <yueshe@google.com >
2024-03-25 23:34:27 +00:00
Gavin Mak
642a989069
Reland "Drop py2 support in recipe modules"
...
This is a reland of commit 5819c303f0
Original change's description:
> Drop py2 support in recipe modules
>
> python3 is the only supported version of python in depot_tools.
>
> Bug: 1475402
> Change-Id: I479de09a0c34b438aced35e4ced58a5972108132
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4808518
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org >
> Commit-Queue: Gavin Mak <gavinmak@google.com >
Bug: 1475402
Change-Id: Ie4e6612a95511026b7602837f8dd3030bcf3ef8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4811285
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2023-08-29 18:54:52 +00:00
Gavin Mak
a5f17dd7b3
Revert "Drop py2 support in recipe modules"
...
This reverts commit 5819c303f0 .
Reason for revert: breaking dart builds
Original change's description:
> Drop py2 support in recipe modules
>
> python3 is the only supported version of python in depot_tools.
>
> Bug: 1475402
> Change-Id: I479de09a0c34b438aced35e4ced58a5972108132
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4808518
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org >
> Commit-Queue: Gavin Mak <gavinmak@google.com >
Bug: 1475402
Change-Id: I0fef7581835bb25ea7e4f22303eef11e72df9536
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4811596
Commit-Queue: Gavin Mak <gavinmak@google.com >
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org >
2023-08-24 20:15:15 +00:00
Gavin Mak
5819c303f0
Drop py2 support in recipe modules
...
python3 is the only supported version of python in depot_tools.
Bug: 1475402
Change-Id: I479de09a0c34b438aced35e4ced58a5972108132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4808518
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2023-08-24 17:11:04 +00:00
recipe-roller
72d05d0d22
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8775574442380992545
Please review the expectation changes, and LGTM+CQ.
recipe_engine:
a25e256b7c
a25e256 (gbeaty@chromium.org )
Remove json python2 backwards-compatibility separators value.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icb78a982055ee8aa9b0551ac8d6dea80a7fa7dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4687678
Reviewed-by: Garrett Beaty <gbeaty@google.com >
Commit-Queue: Garrett Beaty <gbeaty@google.com >
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2023-07-14 19:49:47 +00:00
Yue She
7b0a195903
[mac_toolchain] Roll mac_toolchain version for builders using osx_sdk
...
This rolls adds support for xcode15 adoption, in case builders using osx recipes want to roll to xcode15 in the future
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 1457029
Change-Id: I958d1ac03281d5663ff3a0df4f0812bde863df2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4675569
Reviewed-by: Jeff Yoon <jeffyoon@google.com >
Commit-Queue: Yue She <yueshe@google.com >
2023-07-11 15:14:16 +00:00
Lei Zhang
14123b76a8
Update Xcode for macOS 11 and 12
...
Switch from Xcode 13.0 to 13.2.1 to update the macOS SDK from 11.3 to
12.1. This is needed for bots that use this receipe, like PDFium Mac
bots, after crrev.com/1154867 made macOS 12 mandatory. This also has the
effect of updating the iOS SDK from 15.0 to 15.2.
Change-Id: I4c91b2c23bd8eaacac6cef6afe71fed3533fd838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4605813
Commit-Queue: Lei Zhang <thestig@chromium.org >
Reviewed-by: Lindsay Pasricha <lindsayw@chromium.org >
2023-06-12 19:25:02 +00:00
Arthur Eubanks
5fb55cf84e
Use xcode 14c18 for macos 13.3+
...
Bug: chromium:1453280
Change-Id: I912bff9864af30761287500083d93becd07a79d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4602108
Reviewed-by: Yue She <yueshe@google.com >
Commit-Queue: Jeff Yoon <jeffyoon@google.com >
Auto-Submit: Arthur Eubanks <aeubanks@google.com >
Reviewed-by: Jeff Yoon <jeffyoon@google.com >
2023-06-08 18:13:46 +00:00
Yue She
c83abb3247
Roll mac_toolchain version for builders using osx_sdk
...
This would add support for uploading/installing Xcode with MacOS13 adoption
Recipe-Nontrivial-Roll: build_limited
Bug: 1441931
Change-Id: I7496a80a6876fc4b0df712ce1634611f59240e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4566408
Reviewed-by: Garrett Beaty <gbeaty@google.com >
Reviewed-by: Jeff Yoon <jeffyoon@google.com >
Commit-Queue: Yue She <yueshe@google.com >
2023-05-25 18:40:39 +00:00
Stephen Martinis
cf31045b34
Remove martiniss from OWNERS
...
I'm leaving Chrome
Change-Id: I6dad3a55a83de4a2609d316f23e82c8f2dc729a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4117567
Auto-Submit: Stephen Martinis <martiniss@chromium.org >
Commit-Queue: Dirk Pranke <dpranke@google.com >
Reviewed-by: Dirk Pranke <dpranke@google.com >
2022-12-20 23:44:32 +00:00
Zhaoyang Li
4858aea098
Roll mac_toolchain version in builders using osx_sdk
...
To take in change:
[mac_toolchain] Remove `sudo /usr/sbin/DevToolsSecurity -enable` | https://chromium-review.googlesource.com/c/infra/infra/+/3878350
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Bug: 1360487, b/244578145
Change-Id: Iff028748487e6ac8afa9739bfc6287b4c359bb5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3879565
Reviewed-by: Garrett Beaty <gbeaty@google.com >
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org >
2022-09-08 17:09:53 +00:00
Olivier Robin
e88997a261
Add default XCode for iOS11.3+
...
These whould use XCode13
Change-Id: Idb1f0a30ed1c37e421f2d7fb05f5e6f1e017c431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3340948
Reviewed-by: Jeff Yoon <jeffyoon@google.com >
Auto-Submit: Olivier Robin <olivierrobin@chromium.org >
Commit-Queue: Olivier Robin <olivierrobin@chromium.org >
2021-12-15 18:53:06 +00:00
Gavin Mak
d254d5c20d
Add PYTHON_VERSION_COMPATIBILITY to osx_sdk recipe module
...
Bug: 1227140
Change-Id: Ibf73f89e1b92f8aa435e2e5c82336ed46fc6de76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3123948
Commit-Queue: Gavin Mak <gavinmak@google.com >
Reviewed-by: Anthony Polito <apolito@google.com >
2021-08-27 00:29:41 +00:00
Zhaoyang Li
1af6d426a3
[mac_toolchain] Roll mac_toolchain version for builders using osx_sdk
...
The roll takes new feature to download Xcode & iOS runtimes separately.
The interface used by builder machines is untouched, but implementation
changed for new Xcode packages.
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 1191260
Change-Id: If0554e116bcb92c0b125693e1f555e52e22c10f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890331
Reviewed-by: Jeff Yoon <jeffyoon@google.com >
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org >
2021-05-12 19:17:54 +00:00
Brian Ryner
84ce160786
Bump Xcode version to 12.4.
...
This will allow us to target Big Sur for Mac ARM64 builds.
Bug: 1124119
Change-Id: I0aa17c744e13d45699e79eb17336ebcafb9ea719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2777472
Reviewed-by: Mark Mentovai <mark@chromium.org >
Reviewed-by: Jeff Yoon <jeffyoon@google.com >
Commit-Queue: Brian Ryner <bryner@google.com >
2021-03-23 02:05:57 +00:00
Jeff Yoon
6fadc23db4
Adding OWNERS file for osx_sdk recipe module
...
Updating the OWNERS for osx sdk packages. List suggested from
crrev/c/2422449.
Change-Id: Id582737a539d8c10ec3437994068c33dd8c6d46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2424556
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org >
Reviewed-by: Dirk Pranke <dpranke@google.com >
Reviewed-by: Gary Tong <gatong@chromium.org >
2020-10-06 19:20:20 +00:00
Jeff Yoon
d1580d53b7
Add xcode version for Mac OS 10.15.4 in osx_sdk
...
Adding a version map entry for 10.15.6 to default to XCode 12
GM (12a7209) as machines upgrade to 10.15.
Bug: 1128042, 1128044
Change-Id: I6396b67fdce006d19be35d972602bac3bd4ae0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2422449
Reviewed-by: Dirk Pranke <dpranke@google.com >
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org >
2020-09-22 22:59:10 +00:00
recipe-roller
e0950f3cd2
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.
Please review the expectation changes, and LGTM+CQ.
recipe_engine:
https://crrev.com/fc83ebe9d2ed46c6b7147997a6987e0f42d962f4 (mohrr@google.com )
[recipe_modules/cipd] Use -max-threads by default
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=recipe-roller@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7cf134b39e333cecc54868416a13248e104ca386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2140624
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
2020-04-14 22:32:41 +00:00
Robert Iannucci
f31cb801f2
[recipe_modules/osx_sdk] Better default XCode versions depending on host OS.
...
This uses the macOS<->XCode mapping from wikipedia to set the default XCode
version to the highest supported XCode version supported by the current
host OS.
R=justincohen@google.com , tandrii@chromium.org
Bug: 1026340
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: I524d08f81a7778404c60a64b1100b4386a2ed79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1938022
Reviewed-by: Andrii Shyshkalov <tandrii@google.com >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
2019-11-27 17:14:12 +00:00
Andrii Shyshkalov
2025b98401
recipes: update to stop using legacy properties.
...
The only exception is 'revision' of gclient's weird RevisionResolver,
which will be tackled in https://crbug.com/949334
R=ehmaldonado
Bug: 877161
Change-Id: Ic65a2d13578802cf093f2a1cfb4002fe97509b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818973
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
2019-10-02 07:11:17 +00:00
recipe-roller
b712f77706
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b5922385482112ce31df891af71854c81662d69e Remove jsonResult defaulting to null (martiniss@google.com )
R=recipe-roller@chromium.org , tandrii@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9791f5b80afe6529a6321eccbd4ae7d1a3f18a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1638960
Reviewed-by: Stephen Martinis <martiniss@chromium.org >
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org >
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org >
2019-05-31 23:01:31 +00:00
Robert Iannucci
bdb1123726
[osx_sdk] Fix properties when setting a single value.
...
Because of the (unfortunate) ways that PROPERTIES works currently,
setting defaults in the obvious way means that providing a subset of the
values as properties replaces the defaults entirely.
In this case we want to override the sdk_version without having to
override the toolchain app version.
R=jchinlee@chromium.org , tandrii@chromium.org
Change-Id: I13f4ee19e45a3bb147b37f69d10cb4ed4f734a21
Reviewed-on: https://chromium-review.googlesource.com/c/1438088
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org >
Auto-Submit: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org >
2019-01-26 21:00:34 +00:00
Stephen Martinis
9afc6490c1
Manual roll for new run logic
...
Manual roll for https://crrev.com/c/1239574/
TBR=iannucci
Recipe-Manual-Change: build
Recipe-Manual-Change: infra
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Recipe-Manual-Change: skiabuildbot
Recipe-Manual-Change: skia
Bug: 646142
Change-Id: I56f156c05a695cfb00b9e0a7f335d516153a70c7
Reviewed-on: https://chromium-review.googlesource.com/c/1305041
Commit-Queue: Stephen Martinis <martiniss@chromium.org >
Reviewed-by: Stephen Martinis <martiniss@chromium.org >
2018-10-30 22:12:16 +00:00
recipe-roller
284b5e0c60
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/bd5111dec043a367d69d85b81289e2207aa26f6e [cipd] Clean docs, pylint errors, add pkg-fetch, pkg-deploy. (iannucci@chromium.org )
R=tandrii@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I19d44529f7caa41c9577e57f6a9a35815627c4c3
Reviewed-on: https://chromium-review.googlesource.com/1170243
Commit-Queue: Recipe Roller <recipe-roller@chromium.org >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
2018-08-10 00:14:32 +00:00
Robert Iannucci
61110ec711
[osx_sdk] Add mac_toolchain based osx_sdk module.
...
R=hinoka@chromium.org , nodir@chromium.org , sergeyberezin@chromium.org
Change-Id: I92a6675a7fa81987667edb8c7189c2e827f62732
Reviewed-on: https://chromium-review.googlesource.com/1168652
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org >
Reviewed-by: Ryan Tseng <hinoka@chromium.org >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
2018-08-09 23:01:16 +00:00