Jiewei Qian
9e7d3cec55
metadata: sort discovered files and validation messages
...
Explicitly sorts the discovered metadata file, and defines
ordering of validation messages, so the tools will output
will be self-consistent.
Change-Id: I9b263a16b151c014e5950638f066376469c701df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5379678
Commit-Queue: Jiewei Qian <qjw@chromium.org >
Reviewed-by: Anne Redulla <aredulla@google.com >
2024-03-20 22:45:30 +00:00
Jiewei Qian
13d20527ff
metadata: use os.walk to speedup metadata file discovery
...
os.walk is more efficient than the current handwritten traversal.
Measured the time to scan reduced from 30s+ to 8s on p920 on
chromium/src.
`followlinks=True` is set to preserve behavior that os.path.isdir
returns True for symlink to directories, and the current traversal code
will descend into those.
Change-Id: I941eec9105a46d6538ca484fbb5249a75888e38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5379945
Reviewed-by: Anne Redulla <aredulla@google.com >
Commit-Queue: Jiewei Qian <qjw@chromium.org >
2024-03-20 05:29:24 +00:00
Anne Redulla
6715758ed9
[ssci] PEP8 formatting for metadata directory
...
All files in metadata/ are new, so they should follow the PEP-8 style.
Change-Id: I5d8424536c3d7b703e6b8087e0e2d70c06a1549c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4834909
Reviewed-by: Rachael Newitt <renewitt@google.com >
Commit-Queue: Rachael Newitt <renewitt@google.com >
2023-09-04 22:02:36 +00:00
Anne Redulla
427f0f43ad
[ssci] Script to run validation on all metadata files
...
Adds script metadata/scan.py which can be used to search for and
validate Chromium dependency metadata files, given a repository
root directory.
Bug: b:277147404
Change-Id: Ibde0eeb7babe0b1e3f9c7f887bece629d390974a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4823596
Commit-Queue: Anne Redulla <aredulla@google.com >
Reviewed-by: Rachael Newitt <renewitt@google.com >
2023-08-31 03:46:17 +00:00
Anne Redulla
b9d7c85582
[ssci] Added CheckChromiumDependencyMetadata in presubmit_canned_checks
...
This CL adds a new function `CheckChromiumDependencyMetadata` in
`presubmit_canned_checks.py`. It can be used to check that files satisfy
the format defined by `README.chromium.template`
(https://chromium.googlesource.com/chromium/src/+/main/third_party/README.chromium.template ).
The code for metadata validation can be found in `//metadata`. Note that
all metadata validation issues will be returned as warnings only for
now, while the quality of metadata is being uplifted.
Bug: b:277147404
Change-Id: Iacf1b3a11219ab752549f6dc6e882c93c0fbe780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4812578
Commit-Queue: Anne Redulla <aredulla@google.com >
Reviewed-by: Rachael Newitt <renewitt@google.com >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
2023-08-29 23:54:27 +00:00
