InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

siso: set GOOGLE_API_USE_CLIENT_CERTIFICATE for googlers that run siso.py without running autoninja.py

Browse Source 
apply_telemetry_flags runs only for googlers, so we don't check if it's the googler running the code again.

Additionally amend the comment.

Bug: b/348530235
Change-Id: I3b1ef1edc8c03a4aba11bdc474560de66a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7143899
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
This commit is contained in:
Alex Ovsienko
2025-11-11 22:33:43 -08:00
committed by LUCI CQ
parent 345a14adf0
commit f107245af8
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
autoninja.py
View File

@@ -293,11 +293,9 @@ def _main_inner(input_args,
# and keep workspace clean.
if not os.environ.get("PYTHONPYCACHEPREFIX"):
os.environ.setdefault("PYTHONDONTWRITEBYTECODE", "1")
# Workaround for reproxy timing out on startup due to the Google Cloud
# Go SDK making a call to user.Current(), which can be slow on Googler
# machines due to go.dev/issue/68312. This can be removed once Go 1.24
# has been released, and reproxy + other tools have been rebuilt with
# that.
# Despite go.dev/issue/68312 being fixed, the issue is still reproducible
# for googlers. Due to this, the flag is still applied while the
# issue is being investigated.
if _is_google_corp_machine():
os.environ.setdefault("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false")
# The -t tools are incompatible with -j