InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

siso: always set the collector address, do not assume default behavior.

Browse Source 
Bug: b/455433899
Change-Id: Ib8c0c3041cac5491e70986c0e7a60d386a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7367697
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
This commit is contained in:
Alex Ovsienko
2026-01-06 00:14:32 -08:00
committed by LUCI CQ
parent daf2602023
commit e04940f5e8
2 changed files with 41 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
siso.py
View File

@@ -180,6 +180,8 @@ def _start_collector(siso_path: str, sockets_file: Optional[str],
cmd = [siso_path, "collector", "--project", project]
if sockets_file:
cmd += ["--collector_address", f"unix://{sockets_file}"]
else:
cmd += ["--collector_address", _OTLP_DEFAULT_TCP_ENDPOINT]
subprocess.Popen(
cmd,
stdout=subprocess.DEVNULL,
@@ -358,6 +360,8 @@ def _handle_collector_args(siso_path: str, args: list[str],
if started:
if sockets_file:
args.append(f"--collector_address=unix://{sockets_file}")
else:
args.append(f"--collector_address={_OTLP_DEFAULT_TCP_ENDPOINT}")
else:
print("Collector never came to life", file=sys.stderr)
if "-enable_collector" in args: