InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ninjalog] fully anonymize build stats before sending

Browse Source 
We cannot send PII data.

This CL tried to remove following data,
* build config that can contain build directory path
* build directory path
* hostname
* cwd

I use per build uuid instead of per user uuid.


Bug: 900161
Change-Id: Id533762749806ad8616b7dc07f21b27dfe632c9a
Reviewed-on: https://chromium-review.googlesource.com/c/1369473
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
This commit is contained in:
Takuto Ikuta
2019-01-09 06:24:56 +00:00
committed by Commit Bot
parent b61b09f11d
commit c8069af594
3 changed files with 81 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/ninjalog_uploader_test.py
View File

@@ -25,7 +25,14 @@ class NinjalogUploaderTest(unittest.TestCase):
'default': {'value': 'false'},
'name': 'is_component_build'
},
])), {'is_component_build': 'true'})
{
'default': {'value': '"x64"'},
'name': 'host_cpu'
},
])), {
'is_component_build': 'true',
'host_cpu': '"x64"',
})
self.assertEqual(ninjalog_uploader.ParseGNArgs(json.dumps([
{
@@ -85,6 +92,28 @@ class NinjalogUploaderTest(unittest.TestCase):
self.assertEqual(ninjalog_uploader.GetBuildTargetFromCommandLine(
['ninja', '-C', 'out/Release', 'chrome', 'all']), ['chrome', 'all'])
def test_get_j_flag(self):
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja']), None)
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja','-j', '1000']), 1000)
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja','-j', '1000a']), None)
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja','-j', 'a']), None)
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja','-j1000']), 1000)
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja','-ja']), None)
self.assertEqual(ninjalog_uploader.GetJflag(
['ninja','-j']), None)
if __name__ == '__main__':
unittest.main()