InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

owners_finder: Don't print comments for owners

Browse Source 
This feature will not be supported when using Gerrit
Code-Owners plugin.

Change-Id: I7ad0d5bf004ba39818e57fc00e40592a44d1d11f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638140
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
This commit is contained in:
Edward Lesmes
2021-01-19 20:19:14 +00:00
committed by LUCI CQ
parent 0489cc12af
commit c3c15a1f6b
2 changed files with 2 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
owners_finder.py
View File

@@ -82,7 +82,6 @@ class OwnersFinder(object):
self.all_possible_owners, files)
self.original_files_to_owners = copy.deepcopy(self.files_to_owners)
self.comments = self.db.comments
# This is the queue that will be shown in the interactive questions.
# It is initially sorted by the score in descending order. In the
@@ -220,30 +219,6 @@ class OwnersFinder(object):
continues = True
break
def print_comments(self, owner):
if owner not in self.comments:
self.writeln(self.bold_name(owner))
else:
self.writeln(self.bold_name(owner) + ' is commented as:')
self.indent()
if owners_module.GLOBAL_STATUS in self.comments[owner]:
self.writeln(
self.greyed(self.comments[owner][owners_module.GLOBAL_STATUS]) +
' (global status)')
if len(self.comments[owner]) == 1:
self.unindent()
return
for path in self.comments[owner]:
if path == owners_module.GLOBAL_STATUS:
continue
elif len(self.comments[owner][path]) > 0:
self.writeln(self.greyed(self.comments[owner][path]) +
' (at ' + self.bold(path or '<root>') + ')')
else:
self.writeln(self.greyed('[No comment] ') + ' (at ' +
self.bold(path or '<root>') + ')')
self.unindent()
def print_file_info(self, file_name, except_owner=''):
if file_name not in self.unreviewed_files:
self.writeln(self.greyed(file_name +
@@ -277,7 +252,7 @@ class OwnersFinder(object):
def print_owned_files_for(self, owner):
# Print owned files
self.print_comments(owner)
self.writeln(self.bold_name(owner))
self.writeln(self.bold_name(owner) + ' owns ' +
str(len(self.owners_to_files[owner])) + ' file(s):')
self.indent()
@@ -291,7 +266,7 @@ class OwnersFinder(object):
len(self.selected_owners)) > 3:
for ow in owners_queue:
if ow not in self.deselected_owners and ow not in self.selected_owners:
self.print_comments(ow)
self.writeln(self.bold_name(ow))
else:
for ow in owners_queue:
if ow not in self.deselected_owners and ow not in self.selected_owners: