InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

[gclient] remove output_file from gcs object setdep

Browse Source 
We now ask users to preserve the order of objects since there are now
two fields that don't need to updated (output_file and condition).

R=kimstephanie@google.com

Change-Id: Ic2e8c0b350060247458e733f14466145c2af435f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539331
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
This commit is contained in:
Josip Sokcevic
2024-05-14 20:29:50 +00:00
committed by LUCI CQ
parent e6a370ee1d
commit adfd994f98
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gclient_eval.py
View File

@@ -813,8 +813,7 @@ def SetGCS(gclient_dict, dep_name, new_objects):
"number of objects.")
# Allow only `keys_to_update` to be updated.
keys_to_update = ('object_name', 'sha256sum', 'size_bytes', 'generation',
'output_file')
keys_to_update = ('object_name', 'sha256sum', 'size_bytes', 'generation')
for index, object_node in enumerate(objects_node.elts):
for key, value in zip(object_node.keys, object_node.values):
if key.s not in keys_to_update: