InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

post_build_ninja_summary: run siso.py instead of siso command

Browse Source 
Passing args via siso.bat is problematic.
Invoke 'python3 siso.py' instead.

Bug: 323780528
Change-Id: I991aeab375068d790f9e1f9fd264db9c1003f9dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6247814
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
This commit is contained in:
Fumitoshi Ukai
2025-02-09 23:21:47 -08:00
committed by LUCI CQ
parent 9e4336f5fb
commit a5519ca872
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
post_build_ninja_summary.py
View File

@@ -57,6 +57,8 @@ import os
import subprocess import subprocess
import sys import sys
THIS_DIR = os.path.dirname(__file__)
# The number of long build times to report: # The number of long build times to report:
long_count = 10 long_count = 10
# The number of long times by extension to report # The number of long times by extension to report
@@ -362,8 +364,7 @@ def main():
long_ext_count += len(args.step_types.split(";")) long_ext_count += len(args.step_types.split(";"))
if os.path.exists(metrics_file): if os.path.exists(metrics_file):
# Automatically handle summarizing siso builds. cmd = [sys.executable, os.path.join(THIS_DIR, "siso.py")]
cmd = ["siso.bat" if "win32" in sys.platform else "siso"]
cmd.extend(["metrics", "summary"]) cmd.extend(["metrics", "summary"])
if args.build_directory: if args.build_directory:
cmd.extend(["-C", args.build_directory]) cmd.extend(["-C", args.build_directory])