InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Validate infra configs on presubmit

Browse Source 
Try to parse json files on presubmit and add warning it if unable to
parse.

R=apolito@google.com

Bug: 1223923
Change-Id: I67ab4702cb9b995aace6527f4a04f1a1068db7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3019692
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
This commit is contained in:
Josip Sokcevic
2021-07-13 17:38:53 +00:00
committed by LUCI CQ
parent 4256846f2a
commit 9eee47a8e9
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
PRESUBMIT.py
View File

@@ -70,7 +70,9 @@ def DepotToolsPylint(input_api, output_api):
def CommonChecks(input_api, output_api, tests_to_skip_list):
input_api.SetTimeout(TEST_TIMEOUT_S)
results = []
file_filter = lambda x: x.LocalPath() == 'infra/config/recipes.cfg'
results = input_api.canned_checks.CheckJsonParses(input_api, output_api,
file_filter=file_filter)
# The tests here are assuming this is not defined, so raise an error
# if it is.