InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete paths inside .<object-name>_content_names

Browse Source 
When installing a gcs dep entry, record the getnames() output to
.<object_name>_content_names. When updating the object(s) of a gcs
entry, it'll clear all files related to that gcs entry including:
.<object_name>_content_names and the paths inside it,
.<object_name>_hash, and .<object_name>_is_first_class_gcs

Bug: b/324418194
Change-Id: Ieb56623ce929b715ed103af9560efcf66b46a9c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5454646
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
This commit is contained in:
Stephanie Kim
2024-04-15 20:40:22 +00:00
committed by LUCI CQ
parent 1460e77929
commit 8b40b1b381
2 changed files with 48 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
gclient_scm.py
View File

@@ -6,6 +6,7 @@
import collections
import contextlib
import errno
import glob
import json
import logging
import os
@@ -2004,13 +2005,45 @@ class GcsRoot(object):
full_path = os.path.join(self.root_dir, path)
if (len(resolved_objects) != len(parsed_objects)
and os.path.exists(full_path)):
gclient_utils.rmtree(full_path)
self.clobber_tar_content_names(full_path)
self.clobber_hash_files(full_path)
self.clobber_migration_files(full_path)
def clobber_tar_content_names(self, entry_directory):
"""Delete paths written in .*_content_names files"""
content_names_files = glob.glob(
os.path.join(entry_directory, '.*_content_names'))
for file in content_names_files:
with open(file, 'r') as f:
names = json.loads(f.read().strip())
for name in names:
name_path = os.path.join(entry_directory, name)
if os.path.isdir(
name_path) or not os.path.exists(name_path):
continue
os.remove(os.path.join(entry_directory, name))
os.remove(file)
def clobber_hash_files(self, entry_directory):
files = glob.glob(os.path.join(entry_directory, '.*_hash'))
for f in files:
os.remove(f)
def clobber_migration_files(self, entry_directory):
files = glob.glob(os.path.join(entry_directory,
'.*_is_first_class_gcs'))
for f in files:
os.remove(f)
def clobber(self):
"""Remove all dep path directories and clear .gcs_entries"""
"""Remove all dep path gcs items and clear .gcs_entries"""
for _, objects_dict in self._gcs_entries.items():
for dep_path, _ in objects_dict.items():
gclient_utils.rmtree(os.path.join(self.root_dir, dep_path))
full_path = os.path.join(self.root_dir, dep_path)
self.clobber_tar_content_names(full_path)
self.clobber_hash_files(full_path)
self.clobber_migration_files(full_path)
if os.path.exists(self._gcs_entries_file):
os.remove(self._gcs_entries_file)
with self._mutator_lock: