InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix code check in upload to google storage.

Browse Source 
The check was inverted, and was generating suprious error messages.

Bug: None
Change-Id: I139bb9e7d15e51fbec8c5703b26ed60e1ed1fab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3884910
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
This commit is contained in:
Jamie Madill
2022-09-09 16:00:47 +00:00
committed by LUCI CQ
parent 443f9851a4
commit 787e71ac8b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
upload_to_google_storage.py
View File

@@ -120,7 +120,7 @@ def _upload_worker(
if os.stat(filename).st_mode & stat.S_IEXEC:
code, _, err = gsutil.check_call_with_retries(
'setmeta', '-h', 'x-goog-meta-executable:1', file_url)
if not code:
if code != 0:
ret_codes.put(
(code,
'Encountered error on setting metadata on %s\n%s' %