InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop running presubmit unittests with python2.

Browse Source 
R=ajp@google.com, aravindvasudev@google.com, bryner

Bug: 1441784, 1359438
Change-Id: I8ea7b1aee2df016d15d9bf9d630728b76d1e77cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4521757
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
This commit is contained in:
Robert Iannucci
2023-05-10 23:37:36 +00:00
committed by LUCI CQ
parent 330de93b15
commit 716022354a
2 changed files with 8 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
PRESUBMIT.py
View File

@@ -109,18 +109,6 @@ def CheckUnitTestsOnCommit(input_api, output_api):
input_api.SetTimeout(TEST_TIMEOUT_S)
# We still support python2 presubmit tests, so we need to test them. We don't
# run py3 here as the code below will start those tests
tests = input_api.canned_checks.GetUnitTestsInDirectory(
input_api,
output_api,
'tests',
files_to_check=[
r'.*presubmit_unittest\.py$',
],
run_on_python2=True,
run_on_python3=False)
# Run only selected tests on Windows.
test_to_run_list = [r'.*test\.py$']
tests_to_skip_list = []
@@ -135,15 +123,14 @@ def CheckUnitTestsOnCommit(input_api, output_api):
r'.*recipes_test\.py$',
])
tests.extend(
input_api.canned_checks.GetUnitTestsInDirectory(
input_api,
output_api,
'tests',
files_to_check=test_to_run_list,
files_to_skip=tests_to_skip_list,
run_on_python3=True,
run_on_python2=False))
tests = input_api.canned_checks.GetUnitTestsInDirectory(
input_api,
output_api,
'tests',
files_to_check=test_to_run_list,
files_to_skip=tests_to_skip_list,
run_on_python3=True,
run_on_python2=False)
return input_api.RunTests(tests)