InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip files owned by reviewers when quering for missing owners.

Browse Source 
Bug: 728298
Change-Id: If813ff41b1668a2cab6c26b65e424fbe574e629c
Reviewed-on: https://chromium-review.googlesource.com/899086
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
This commit is contained in:
Edward Lemur
2018-02-07 00:50:14 +01:00
committed by Commit Bot
parent 4a92cc9a1f
commit 707d70b91e
5 changed files with 57 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
owners_finder.py
View File

@@ -22,7 +22,7 @@ class OwnersFinder(object):
indentation = 0
def __init__(self, files, local_root, author,
def __init__(self, files, local_root, author, reviewers,
fopen, os_path,
email_postfix='@chromium.org',
disable_color=False,
@@ -45,9 +45,13 @@ class OwnersFinder(object):
filtered_files = files
# Eliminate files that the author can review.
reviewers = list(reviewers)
if author:
reviewers.append(author)
# Eliminate files that existing reviewers can review.
filtered_files = list(self.db.files_not_covered_by(
filtered_files, [author] if author else []))
filtered_files, reviewers))
# If some files are eliminated.
if len(filtered_files) != len(files):